diff mbox

htop: enable unicode if possible

Message ID 20161109092739.4595-1-jezz@sysmic.org
State Changes Requested
Headers show

Commit Message

Jérôme Pouiller Nov. 9, 2016, 9:27 a.m. UTC
Signed-off-by: Jérôme Pouiller <jezz@sysmic.org>
---
 package/htop/htop.mk | 2 ++
 1 file changed, 2 insertions(+)

Comments

Thomas Petazzoni Nov. 9, 2016, 8:41 p.m. UTC | #1
Hello,

On Wed,  9 Nov 2016 10:27:39 +0100, Jérôme Pouiller wrote:
> Signed-off-by: Jérôme Pouiller <jezz@sysmic.org>
> ---
>  package/htop/htop.mk | 2 ++
>  1 file changed, 2 insertions(+)
> 
> diff --git a/package/htop/htop.mk b/package/htop/htop.mk
> index 7409a78..e1a658b 100644
> --- a/package/htop/htop.mk
> +++ b/package/htop/htop.mk
> @@ -7,7 +7,9 @@
>  HTOP_VERSION = 2.0.2
>  HTOP_SITE = http://hisham.hm/htop/releases/$(HTOP_VERSION)
>  HTOP_DEPENDENCIES = ncurses
> +ifeq ($(BR2_PACKAGE_NCURSES_WCHAR),)
>  HTOP_CONF_OPTS = --disable-unicode
> +endif

We want something more explicit, like:

ifeq ($(BR2_PACKAGE_NCURSES_WCHAR),y)
HTOP_CONF_OPTS += --enable-unicode
else
HTOP_CONF_OPTS += --disable-unicode
endif

Could you try this, in both situations, and see if it works as expected?

Thanks!

Thomas
diff mbox

Patch

diff --git a/package/htop/htop.mk b/package/htop/htop.mk
index 7409a78..e1a658b 100644
--- a/package/htop/htop.mk
+++ b/package/htop/htop.mk
@@ -7,7 +7,9 @@ 
 HTOP_VERSION = 2.0.2
 HTOP_SITE = http://hisham.hm/htop/releases/$(HTOP_VERSION)
 HTOP_DEPENDENCIES = ncurses
+ifeq ($(BR2_PACKAGE_NCURSES_WCHAR),)
 HTOP_CONF_OPTS = --disable-unicode
+endif
 # Prevent htop build system from searching the host paths
 HTOP_CONF_ENV = HTOP_NCURSES_CONFIG_SCRIPT=$(STAGING_DIR)/usr/bin/ncurses5-config
 HTOP_LICENSE = GPLv2