| Message ID | 1478666130-13413-7-git-send-email-yamada.masahiro@socionext.com |
|---|---|
| State | Accepted |
| Commit | 376563917c23ec8e1d30475233f1111b307fd18b |
| Headers | show |
On 11/09/2016 05:35 AM, Masahiro Yamada wrote: > The denali->blksperchip is set, but not referenced any more. The > denali->totalblks is used only for calculating denali->blksperchip. > Both of them are unneeded. > > Signed-off-by: Masahiro Yamada <yamada.masahiro@socionext.com> Reviewed-by: Marek Vasut <marek.vasut@gmail.com> > --- > > drivers/mtd/nand/denali.c | 8 -------- > drivers/mtd/nand/denali.h | 2 -- > 2 files changed, 10 deletions(-) > > diff --git a/drivers/mtd/nand/denali.c b/drivers/mtd/nand/denali.c > index 78d795b..548278b 100644 > --- a/drivers/mtd/nand/denali.c > +++ b/drivers/mtd/nand/denali.c > @@ -1573,14 +1573,6 @@ int denali_init(struct denali_nand_info *denali) > denali->nand.ecc.bytes *= denali->devnum; > denali->nand.ecc.strength *= denali->devnum; > > - /* > - * Let driver know the total blocks number and how many blocks > - * contained by each nand chip. blksperchip will help driver to > - * know how many blocks is taken by FW. > - */ > - denali->totalblks = mtd->size >> denali->nand.phys_erase_shift; > - denali->blksperchip = denali->totalblks / denali->nand.numchips; > - > /* override the default read operations */ > denali->nand.ecc.size = ECC_SECTOR_SIZE * denali->devnum; > denali->nand.ecc.read_page = denali_read_page; > diff --git a/drivers/mtd/nand/denali.h b/drivers/mtd/nand/denali.h > index 7c0800d..ea22191 100644 > --- a/drivers/mtd/nand/denali.h > +++ b/drivers/mtd/nand/denali.h > @@ -462,8 +462,6 @@ struct denali_nand_info { > int irq; > > uint32_t devnum; /* represent how many nands connected */ > - uint32_t totalblks; > - uint32_t blksperchip; > uint32_t bbtskipbytes; > uint32_t max_banks; > }; >
diff --git a/drivers/mtd/nand/denali.c b/drivers/mtd/nand/denali.c index 78d795b..548278b 100644 --- a/drivers/mtd/nand/denali.c +++ b/drivers/mtd/nand/denali.c @@ -1573,14 +1573,6 @@ int denali_init(struct denali_nand_info *denali) denali->nand.ecc.bytes *= denali->devnum; denali->nand.ecc.strength *= denali->devnum; - /* - * Let driver know the total blocks number and how many blocks - * contained by each nand chip. blksperchip will help driver to - * know how many blocks is taken by FW. - */ - denali->totalblks = mtd->size >> denali->nand.phys_erase_shift; - denali->blksperchip = denali->totalblks / denali->nand.numchips; - /* override the default read operations */ denali->nand.ecc.size = ECC_SECTOR_SIZE * denali->devnum; denali->nand.ecc.read_page = denali_read_page; diff --git a/drivers/mtd/nand/denali.h b/drivers/mtd/nand/denali.h index 7c0800d..ea22191 100644 --- a/drivers/mtd/nand/denali.h +++ b/drivers/mtd/nand/denali.h @@ -462,8 +462,6 @@ struct denali_nand_info { int irq; uint32_t devnum; /* represent how many nands connected */ - uint32_t totalblks; - uint32_t blksperchip; uint32_t bbtskipbytes; uint32_t max_banks; };
The denali->blksperchip is set, but not referenced any more. The denali->totalblks is used only for calculating denali->blksperchip. Both of them are unneeded. Signed-off-by: Masahiro Yamada <yamada.masahiro@socionext.com> --- drivers/mtd/nand/denali.c | 8 -------- drivers/mtd/nand/denali.h | 2 -- 2 files changed, 10 deletions(-)