diff mbox

[2/5] package/pseudo: force rpath and pass our host CFLAGS

Message ID 48834016f35af5f0f2ab09bfe73af1a45c96ef4f.1478643505.git.yann.morin.1998@free.fr
State Accepted
Headers show

Commit Message

Yann E. MORIN Nov. 8, 2016, 10:18 p.m. UTC
pseudo whines when those are not set, and tries to find a suitable
value; this is usually correct but risk an incorrect guess in corner
cases.

Rather than leaving those in guess-mode, just force them to values we
know are correct.

Signed-off-by: "Yann E. MORIN" <yann.morin.1998@free.fr>
Cc: Gaël PORTAY <gael.portay@savoirfairelinux.com>
Cc: Patrick Keroulas <patrick.keroulas@savoirfairelinux.com>
Cc: Erico Nunes <nunes.erico@gmail.com>
Cc: Julien BOIBESSOT <julien.boibessot@free.fr>
Cc: Arnout Vandecappelle <arnout@mind.be>
Reviewed-by: Arnout Vandecappelle <arnout@mind.be>
---
 package/pseudo/pseudo.mk | 5 +++++
 1 file changed, 5 insertions(+)

Comments

Thomas Petazzoni Nov. 9, 2016, 10:29 p.m. UTC | #1
Hello,

On Tue,  8 Nov 2016 23:18:32 +0100, Yann E. MORIN wrote:
> pseudo whines when those are not set, and tries to find a suitable
> value; this is usually correct but risk an incorrect guess in corner
> cases.
> 
> Rather than leaving those in guess-mode, just force them to values we
> know are correct.
> 
> Signed-off-by: "Yann E. MORIN" <yann.morin.1998@free.fr>
> Cc: Gaël PORTAY <gael.portay@savoirfairelinux.com>
> Cc: Patrick Keroulas <patrick.keroulas@savoirfairelinux.com>
> Cc: Erico Nunes <nunes.erico@gmail.com>
> Cc: Julien BOIBESSOT <julien.boibessot@free.fr>
> Cc: Arnout Vandecappelle <arnout@mind.be>
> Reviewed-by: Arnout Vandecappelle <arnout@mind.be>
> ---
>  package/pseudo/pseudo.mk | 5 +++++
>  1 file changed, 5 insertions(+)

Applied to master, after changing the single quotes to double quotes,
since that's what we use pretty much everywhere in BR.

Thanks!

Thomas
diff mbox

Patch

diff --git a/package/pseudo/pseudo.mk b/package/pseudo/pseudo.mk
index 92de2c6..4be5154 100644
--- a/package/pseudo/pseudo.mk
+++ b/package/pseudo/pseudo.mk
@@ -16,7 +16,12 @@  HOST_PSEUDO_DEPENDENCIES = host-attr host-sqlite
 
 # configure script is not generated by autoconf, so passing --libdir
 # is necessary, even if the infrastructure passes --prefix already.
+# It also does not use CFLAGS from the environment, they need to be
+# specified with a custom --cflags option. Also force rpath to avoid
+# a warning at configure time.
 HOST_PSEUDO_CONF_OPTS = \
+	--cflags='$(HOSTCFLAGS)' \
+	--with-rpath=$(HOST_DIR)/usr/lib \
 	--bits=$(if $(filter %64,$(HOSTARCH)),64,32) \
 	--libdir=$(HOST_DIR)/usr/lib \
 	--with-sqlite=$(HOST_DIR)/usr