| Message ID | 20161108154028.13334-1-tklauser@distanz.ch |
|---|---|
| State | Accepted, archived |
| Delegated to: | David Miller |
| Headers | show |
On Tue, Nov 08, 2016 at 04:40:28PM +0100, Tobias Klauser wrote: > Remove the unused but set variables min_set and max_set in > adjust_reg_min_max_vals to fix the following warning when building with > 'W=1': > > kernel/bpf/verifier.c:1483:7: warning: variable ‘min_set’ set but not used [-Wunused-but-set-variable] > > There is no warning about max_set being unused, but since it is only > used in the assignment of min_set it can be removed as well. > > They were introduced in commit 484611357c19 ("bpf: allow access into map > value arrays") but seem to have never been used. > > Cc: Josef Bacik <jbacik@fb.com> > Signed-off-by: Tobias Klauser <tklauser@distanz.ch> > --- Acked-by: Alexei Starovoitov <ast@kernel.org>
From: Tobias Klauser <tklauser@distanz.ch> Date: Tue, 8 Nov 2016 16:40:28 +0100 > Remove the unused but set variables min_set and max_set in > adjust_reg_min_max_vals to fix the following warning when building with > 'W=1': > > kernel/bpf/verifier.c:1483:7: warning: variable ‘min_set’ set but not used [-Wunused-but-set-variable] > > There is no warning about max_set being unused, but since it is only > used in the assignment of min_set it can be removed as well. > > They were introduced in commit 484611357c19 ("bpf: allow access into map > value arrays") but seem to have never been used. > > Cc: Josef Bacik <jbacik@fb.com> > Signed-off-by: Tobias Klauser <tklauser@distanz.ch> Applied to net-next, thanks.
diff --git a/kernel/bpf/verifier.c b/kernel/bpf/verifier.c index 846d7ceaf202..14345be4a2d2 100644 --- a/kernel/bpf/verifier.c +++ b/kernel/bpf/verifier.c @@ -1480,7 +1480,6 @@ static void adjust_reg_min_max_vals(struct bpf_verifier_env *env, { struct bpf_reg_state *regs = env->cur_state.regs, *dst_reg; u64 min_val = BPF_REGISTER_MIN_RANGE, max_val = BPF_REGISTER_MAX_RANGE; - bool min_set = false, max_set = false; u8 opcode = BPF_OP(insn->code); dst_reg = ®s[insn->dst_reg]; @@ -1503,7 +1502,6 @@ static void adjust_reg_min_max_vals(struct bpf_verifier_env *env, } else if (insn->imm < BPF_REGISTER_MAX_RANGE && (s64)insn->imm > BPF_REGISTER_MIN_RANGE) { min_val = max_val = insn->imm; - min_set = max_set = true; } /* We don't know anything about what was done to this register, mark it
Remove the unused but set variables min_set and max_set in adjust_reg_min_max_vals to fix the following warning when building with 'W=1': kernel/bpf/verifier.c:1483:7: warning: variable ‘min_set’ set but not used [-Wunused-but-set-variable] There is no warning about max_set being unused, but since it is only used in the assignment of min_set it can be removed as well. They were introduced in commit 484611357c19 ("bpf: allow access into map value arrays") but seem to have never been used. Cc: Josef Bacik <jbacik@fb.com> Signed-off-by: Tobias Klauser <tklauser@distanz.ch> --- kernel/bpf/verifier.c | 2 -- 1 file changed, 2 deletions(-)