| Message ID | 1478616394-45964-1-git-send-email-abrodkin@synopsys.com |
|---|---|
| State | Changes Requested |
| Delegated to: | John Crispin |
| Headers | show |
On 2016-11-08 15:46, Alexey Brodkin wrote: > TI wl18xx and wl12xx are Wi-Fi/Bluetooth combo modules > that could be found on different existing boards. > > But it is possible to get those modules as a separate > component and use with existing boards as well as > new boards equipped with either module may appear so we > remove dependency on OMAP. > > Signed-off-by: Alexey Brodkin <abrodkin@synopsys.com> > Cc: Jo-Philipp Wich <jo@mein.io> > Cc: Felix Fietkau <nbd@nbd.name> > Cc: Imre Kaloz <kaloz@openwrt.org> > --- > package/kernel/mac80211/Makefile | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/package/kernel/mac80211/Makefile b/package/kernel/mac80211/Makefile > index 25adbfb..b0c040c 100644 > --- a/package/kernel/mac80211/Makefile > +++ b/package/kernel/mac80211/Makefile > @@ -1378,7 +1378,7 @@ endef > define KernelPackage/wlcore > $(call KernelPackage/mac80211/Default) > TITLE:=TI common driver part > - DEPENDS+= @TARGET_omap +kmod-mac80211 +@DRIVER_11N_SUPPORT > + DEPENDS+= +kmod-mac80211 +@DRIVER_11N_SUPPORT I think this will cause build failures unless you add the missing dependencies on mmc support (which omap enables in the kernel image, but other platforms don't). - Felix
Hi Felix, On Tue, 2016-11-08 at 16:08 +0100, Felix Fietkau wrote: > On 2016-11-08 15:46, Alexey Brodkin wrote: > > > > TI wl18xx and wl12xx are Wi-Fi/Bluetooth combo modules > > that could be found on different existing boards. > > > > But it is possible to get those modules as a separate > > component and use with existing boards as well as > > new boards equipped with either module may appear so we > > remove dependency on OMAP. > > > > Signed-off-by: Alexey Brodkin <abrodkin@synopsys.com> > > Cc: Jo-Philipp Wich <jo@mein.io> > > Cc: Felix Fietkau <nbd@nbd.name> > > Cc: Imre Kaloz <kaloz@openwrt.org> > > --- > > package/kernel/mac80211/Makefile | 2 +- > > 1 file changed, 1 insertion(+), 1 deletion(-) > > > > diff --git a/package/kernel/mac80211/Makefile b/package/kernel/mac80211/Makefile > > index 25adbfb..b0c040c 100644 > > --- a/package/kernel/mac80211/Makefile > > +++ b/package/kernel/mac80211/Makefile > > @@ -1378,7 +1378,7 @@ endef > > define KernelPackage/wlcore > > $(call KernelPackage/mac80211/Default) > > TITLE:=TI common driver part > > - DEPENDS+= @TARGET_omap +kmod-mac80211 +@DRIVER_11N_SUPPORT > > + DEPENDS+= +kmod-mac80211 +@DRIVER_11N_SUPPORT > I think this will cause build failures unless you add the missing > dependencies on mmc support (which omap enables in the kernel image, but > other platforms don't). Right! I did build test for Synopsys boards and here as well we have MMC support enabled by default. So let me add that dependency explicitly in the respin. -Alexey
diff --git a/package/kernel/mac80211/Makefile b/package/kernel/mac80211/Makefile index 25adbfb..b0c040c 100644 --- a/package/kernel/mac80211/Makefile +++ b/package/kernel/mac80211/Makefile @@ -1378,7 +1378,7 @@ endef define KernelPackage/wlcore $(call KernelPackage/mac80211/Default) TITLE:=TI common driver part - DEPENDS+= @TARGET_omap +kmod-mac80211 +@DRIVER_11N_SUPPORT + DEPENDS+= +kmod-mac80211 +@DRIVER_11N_SUPPORT FILES:= \ $(PKG_BUILD_DIR)/drivers/net/wireless/ti/wlcore/wlcore.ko \ $(PKG_BUILD_DIR)/drivers/net/wireless/ti/wlcore/wlcore_sdio.ko
TI wl18xx and wl12xx are Wi-Fi/Bluetooth combo modules that could be found on different existing boards. But it is possible to get those modules as a separate component and use with existing boards as well as new boards equipped with either module may appear so we remove dependency on OMAP. Signed-off-by: Alexey Brodkin <abrodkin@synopsys.com> Cc: Jo-Philipp Wich <jo@mein.io> Cc: Felix Fietkau <nbd@nbd.name> Cc: Imre Kaloz <kaloz@openwrt.org> --- package/kernel/mac80211/Makefile | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)