| Message ID | 1478607473-25851-4-git-send-email-thuth@redhat.com |
|---|---|
| State | New |
| Headers | show |
Le 08/11/2016 à 13:17, Thomas Huth a écrit : > disas/m68k.c obviously belong to the m68k CPU section in > the MAINTAINERS file, but remove the hw/m68k/ directory > here since it only contains machine (not CPU) related > files, as requested by Laurent. Add the machine related > files to the right machine sections instead. I think you can also add include/hw/m68k/mcf.h in the machine section. Thanks, Laurent > > Signed-off-by: Thomas Huth <thuth@redhat.com> > --- > MAINTAINERS | 6 +++++- > 1 file changed, 5 insertions(+), 1 deletion(-) > > diff --git a/MAINTAINERS b/MAINTAINERS > index 451e7cc..5d8b584 100644 > --- a/MAINTAINERS > +++ b/MAINTAINERS > @@ -148,7 +148,7 @@ M68K > M: Laurent Vivier <laurent@vivier.eu> > S: Maintained > F: target-m68k/ > -F: hw/m68k/ > +F: disas/m68k.c > > MicroBlaze > M: Edgar E. Iglesias <edgar.iglesias@gmail.com> > @@ -550,6 +550,7 @@ M68K Machines > an5206 > S: Orphan > F: hw/m68k/an5206.c > +F: hw/m68k/mcf5206.c > > dummy_m68k > S: Orphan > @@ -558,6 +559,9 @@ F: hw/m68k/dummy_m68k.c > mcf5208 > S: Orphan > F: hw/m68k/mcf5208.c > +F: hw/m68k/mcf_intc.c > +F: hw/char/mcf_uart.c > +F: hw/net/mcf_fec.c > > MicroBlaze Machines > ------------------- >
On 08.11.2016 13:21, Laurent Vivier wrote: > Le 08/11/2016 à 13:17, Thomas Huth a écrit : >> disas/m68k.c obviously belong to the m68k CPU section in >> the MAINTAINERS file, but remove the hw/m68k/ directory >> here since it only contains machine (not CPU) related >> files, as requested by Laurent. Add the machine related >> files to the right machine sections instead. > > I think you can also add include/hw/m68k/mcf.h in the machine section. That header currently contains prototypes for both, the 5206 and the 5208 machine... and I'd like to avoid adding that twice. We should likely clean that up one day, but since it's currently orphaned anyway, it's IMHO not that important to have this listed right now. Thomas
Le 08/11/2016 à 13:17, Thomas Huth a écrit : > disas/m68k.c obviously belong to the m68k CPU section in > the MAINTAINERS file, but remove the hw/m68k/ directory > here since it only contains machine (not CPU) related > files, as requested by Laurent. Add the machine related > files to the right machine sections instead. > > Signed-off-by: Thomas Huth <thuth@redhat.com> Reviewed-by: Laurent Vivier <laurent@vivier.eu> > --- > MAINTAINERS | 6 +++++- > 1 file changed, 5 insertions(+), 1 deletion(-) > > diff --git a/MAINTAINERS b/MAINTAINERS > index 451e7cc..5d8b584 100644 > --- a/MAINTAINERS > +++ b/MAINTAINERS > @@ -148,7 +148,7 @@ M68K > M: Laurent Vivier <laurent@vivier.eu> > S: Maintained > F: target-m68k/ > -F: hw/m68k/ > +F: disas/m68k.c > > MicroBlaze > M: Edgar E. Iglesias <edgar.iglesias@gmail.com> > @@ -550,6 +550,7 @@ M68K Machines > an5206 > S: Orphan > F: hw/m68k/an5206.c > +F: hw/m68k/mcf5206.c > > dummy_m68k > S: Orphan > @@ -558,6 +559,9 @@ F: hw/m68k/dummy_m68k.c > mcf5208 > S: Orphan > F: hw/m68k/mcf5208.c > +F: hw/m68k/mcf_intc.c > +F: hw/char/mcf_uart.c > +F: hw/net/mcf_fec.c > > MicroBlaze Machines > ------------------- >
diff --git a/MAINTAINERS b/MAINTAINERS index 451e7cc..5d8b584 100644 --- a/MAINTAINERS +++ b/MAINTAINERS @@ -148,7 +148,7 @@ M68K M: Laurent Vivier <laurent@vivier.eu> S: Maintained F: target-m68k/ -F: hw/m68k/ +F: disas/m68k.c MicroBlaze M: Edgar E. Iglesias <edgar.iglesias@gmail.com> @@ -550,6 +550,7 @@ M68K Machines an5206 S: Orphan F: hw/m68k/an5206.c +F: hw/m68k/mcf5206.c dummy_m68k S: Orphan @@ -558,6 +559,9 @@ F: hw/m68k/dummy_m68k.c mcf5208 S: Orphan F: hw/m68k/mcf5208.c +F: hw/m68k/mcf_intc.c +F: hw/char/mcf_uart.c +F: hw/net/mcf_fec.c MicroBlaze Machines -------------------
disas/m68k.c obviously belong to the m68k CPU section in the MAINTAINERS file, but remove the hw/m68k/ directory here since it only contains machine (not CPU) related files, as requested by Laurent. Add the machine related files to the right machine sections instead. Signed-off-by: Thomas Huth <thuth@redhat.com> --- MAINTAINERS | 6 +++++- 1 file changed, 5 insertions(+), 1 deletion(-)