| Message ID | 1478557339-16039-1-git-send-email-minipli@googlemail.com |
|---|---|
| State | Accepted, archived |
| Delegated to: | David Miller |
| Headers | show |
From: Mathias Krause <minipli@googlemail.com> Date: Mon, 7 Nov 2016 23:22:19 +0100 > To avoid having dangling function pointers left behind, reset calcit in > rtnl_unregister(), too. > > This is no issue so far, as only the rtnl core registers a netlink > handler with a calcit hook which won't be unregistered, but may become > one if new code makes use of the calcit hook. > > Fixes: c7ac8679bec9 ("rtnetlink: Compute and store minimum ifinfo...") > Cc: Jeff Kirsher <jeffrey.t.kirsher@intel.com> > Cc: Greg Rose <gregory.v.rose@intel.com> > Signed-off-by: Mathias Krause <minipli@googlemail.com> Applied, thanks.
diff --git a/net/core/rtnetlink.c b/net/core/rtnetlink.c index 189cc78c77eb..d4c601604bf7 100644 --- a/net/core/rtnetlink.c +++ b/net/core/rtnetlink.c @@ -275,6 +275,7 @@ int rtnl_unregister(int protocol, int msgtype) rtnl_msg_handlers[protocol][msgindex].doit = NULL; rtnl_msg_handlers[protocol][msgindex].dumpit = NULL; + rtnl_msg_handlers[protocol][msgindex].calcit = NULL; return 0; }
To avoid having dangling function pointers left behind, reset calcit in rtnl_unregister(), too. This is no issue so far, as only the rtnl core registers a netlink handler with a calcit hook which won't be unregistered, but may become one if new code makes use of the calcit hook. Fixes: c7ac8679bec9 ("rtnetlink: Compute and store minimum ifinfo...") Cc: Jeff Kirsher <jeffrey.t.kirsher@intel.com> Cc: Greg Rose <gregory.v.rose@intel.com> Signed-off-by: Mathias Krause <minipli@googlemail.com> --- net/core/rtnetlink.c | 1 + 1 file changed, 1 insertion(+)