[OpenWrt-Devel,packages] fuse: Remove update-rc.d call on package installation
diff mbox

Message ID HE1PR10MB0041151600C03CE4F758F70FEDA70@HE1PR10MB0041.EURPRD10.PROD.OUTLOOK.COM
State Changes Requested
Delegated to: John Crispin
Headers show

Commit Message

Adrien Ricciardi Nov. 7, 2016, 1:37 p.m. UTC
Hi OpenWRT team,


I am building trunk OpenWRT version on Debian Testing. When installing the fuse package on the target rootfs, the following makefile rule is called :

install-exec-local:
    $(MKDIR_P) $(DESTDIR)$(MOUNT_FUSE_PATH)
    $(INSTALL_PROGRAM) $(builddir)/mount.fuse $(DESTDIR)$(MOUNT_FUSE_PATH)/mount.fuse
    $(MKDIR_P) $(DESTDIR)$(INIT_D_PATH)
    $(INSTALL_SCRIPT) $(srcdir)/init_script $(DESTDIR)$(INIT_D_PATH)/fuse
    @if test -x /usr/sbin/update-rc.d; then \
        echo "/usr/sbin/update-rc.d fuse start 34 S . start 41 0 6 . || true"; \
        /usr/sbin/update-rc.d fuse start 34 S . start 41 0 6 . || true; \
    fi

This rule calls update-rc.d on the host machine, trying to install the init.d service, whereas we just want to copy some files to the rootfs. On Debian Testing, this triggers a window telling that systemd wants to reload.
The provided patch removes the update-rc.d call. I don't think there is any side effect due to these lines removal.

It's my first post to OpenWRT mailing list, I'm not sure I followed all rules. Tell me if something is wrong or if the patch is useless.

Regards,
Adrien

Patch
diff mbox

--- a/util/Makefile.in
+++ b/util/Makefile.in
@@ -687,10 +687,6 @@  install-exec-local:
 	$(INSTALL_PROGRAM) $(builddir)/mount.fuse $(DESTDIR)$(MOUNT_FUSE_PATH)/mount.fuse
 	$(MKDIR_P) $(DESTDIR)$(INIT_D_PATH)
 	$(INSTALL_SCRIPT) $(srcdir)/init_script $(DESTDIR)$(INIT_D_PATH)/fuse
-	@if test -x /usr/sbin/update-rc.d; then \
-		echo "/usr/sbin/update-rc.d fuse start 34 S . start 41 0 6 . || true"; \
-		/usr/sbin/update-rc.d fuse start 34 S . start 41 0 6 . || true; \
-	fi
 
 install-data-local:
 	$(MKDIR_P) $(DESTDIR)$(UDEV_RULES_PATH)