| Message ID | 1478514205-29497-1-git-send-email-yegorslists@googlemail.com |
|---|---|
| State | Superseded |
| Headers | show |
Hi Yegor, On Mon, Nov 07, 2016 at 11:23:25AM +0100, yegorslists@googlemail.com wrote: > From: Yegor Yefremov <yegorslists@googlemail.com> > > Signed-off-by: Yegor Yefremov <yegorslists@googlemail.com> > --- > package/wpa_supplicant/Config.in | 7 +++++++ > package/wpa_supplicant/wpa_supplicant.mk | 6 ++++++ > 2 files changed, 13 insertions(+) > > diff --git a/package/wpa_supplicant/Config.in b/package/wpa_supplicant/Config.in > index 454541f..9250a3b 100644 > --- a/package/wpa_supplicant/Config.in > +++ b/package/wpa_supplicant/Config.in > @@ -45,6 +45,13 @@ config BR2_PACKAGE_WPA_SUPPLICANT_WIFI_DISPLAY > help > Enable support for Wi-Fi Display > > +config BR2_PACKAGE_WPA_SUPPLICANT_MESH_NETWORKING > + bool "Enable mesh networking" > + depends on BR2_PACKAGE_WPA_SUPPLICANT_AP_SUPPORT > + help > + Enable support for open and secured mesh networking > + (IEEE 802.11s) > + > config BR2_PACKAGE_WPA_SUPPLICANT_AUTOSCAN > bool "Enable autoscan" > help > diff --git a/package/wpa_supplicant/wpa_supplicant.mk b/package/wpa_supplicant/wpa_supplicant.mk > index 3c3317b..29ef362 100644 > --- a/package/wpa_supplicant/wpa_supplicant.mk > +++ b/package/wpa_supplicant/wpa_supplicant.mk > @@ -73,6 +73,12 @@ ifeq ($(BR2_PACKAGE_WPA_SUPPLICANT_WIFI_DISPLAY),y) > WPA_SUPPLICANT_CONFIG_ENABLE += CONFIG_WIFI_DISPLAY > endif > > +ifeq ($(BR2_PACKAGE_WPA_SUPPLICANT_MESH_NETWORKING),y) > +WPA_SUPPLICANT_CONFIG_SET += CONFIG_IEEE80211W \ > + CONFIG_MESH \ > + CONFIG_SAE CONFIG_IEEE80211W appears commented out in wpa_supplicant/defconfig, so maybe use WPA_SUPPLICANT_CONFIG_ENABLE for that. Though I'm not sure about the reason for the distinction between WPA_SUPPLICANT_CONFIG and WPA_SUPPLICANT_CONFIG_SET. Isn't WPA_SUPPLICANT_CONFIG_SET enough for everything? baruch > +endif > + > ifeq ($(BR2_PACKAGE_WPA_SUPPLICANT_AUTOSCAN),y) > WPA_SUPPLICANT_CONFIG_ENABLE += \ > CONFIG_AUTOSCAN_EXPONENTIAL \
Hi Baruch, On Mon, Nov 7, 2016 at 11:50 AM, Baruch Siach <baruch@tkos.co.il> wrote: > Hi Yegor, > > On Mon, Nov 07, 2016 at 11:23:25AM +0100, yegorslists@googlemail.com wrote: >> From: Yegor Yefremov <yegorslists@googlemail.com> >> >> Signed-off-by: Yegor Yefremov <yegorslists@googlemail.com> >> --- >> package/wpa_supplicant/Config.in | 7 +++++++ >> package/wpa_supplicant/wpa_supplicant.mk | 6 ++++++ >> 2 files changed, 13 insertions(+) >> >> diff --git a/package/wpa_supplicant/Config.in b/package/wpa_supplicant/Config.in >> index 454541f..9250a3b 100644 >> --- a/package/wpa_supplicant/Config.in >> +++ b/package/wpa_supplicant/Config.in >> @@ -45,6 +45,13 @@ config BR2_PACKAGE_WPA_SUPPLICANT_WIFI_DISPLAY >> help >> Enable support for Wi-Fi Display >> >> +config BR2_PACKAGE_WPA_SUPPLICANT_MESH_NETWORKING >> + bool "Enable mesh networking" >> + depends on BR2_PACKAGE_WPA_SUPPLICANT_AP_SUPPORT >> + help >> + Enable support for open and secured mesh networking >> + (IEEE 802.11s) >> + >> config BR2_PACKAGE_WPA_SUPPLICANT_AUTOSCAN >> bool "Enable autoscan" >> help >> diff --git a/package/wpa_supplicant/wpa_supplicant.mk b/package/wpa_supplicant/wpa_supplicant.mk >> index 3c3317b..29ef362 100644 >> --- a/package/wpa_supplicant/wpa_supplicant.mk >> +++ b/package/wpa_supplicant/wpa_supplicant.mk >> @@ -73,6 +73,12 @@ ifeq ($(BR2_PACKAGE_WPA_SUPPLICANT_WIFI_DISPLAY),y) >> WPA_SUPPLICANT_CONFIG_ENABLE += CONFIG_WIFI_DISPLAY >> endif >> >> +ifeq ($(BR2_PACKAGE_WPA_SUPPLICANT_MESH_NETWORKING),y) >> +WPA_SUPPLICANT_CONFIG_SET += CONFIG_IEEE80211W \ >> + CONFIG_MESH \ >> + CONFIG_SAE > > CONFIG_IEEE80211W appears commented out in wpa_supplicant/defconfig, so maybe > use WPA_SUPPLICANT_CONFIG_ENABLE for that. Though I'm not sure about the > reason for the distinction between WPA_SUPPLICANT_CONFIG and > WPA_SUPPLICANT_CONFIG_SET. Isn't WPA_SUPPLICANT_CONFIG_SET enough for > everything? Good catch. WPA_SUPPLICANT_CONFIG_ENABLE ensures we don't have the same CONFIG option twice. Especially if it wasn't commented. Yegor
Hi Yegor, On Mon, Nov 07, 2016 at 12:19:37PM +0100, Yegor Yefremov wrote: > On Mon, Nov 7, 2016 at 11:50 AM, Baruch Siach <baruch@tkos.co.il> wrote: > > On Mon, Nov 07, 2016 at 11:23:25AM +0100, yegorslists@googlemail.com > > wrote: > >> +ifeq ($(BR2_PACKAGE_WPA_SUPPLICANT_MESH_NETWORKING),y) > >> +WPA_SUPPLICANT_CONFIG_SET += CONFIG_IEEE80211W \ > >> + CONFIG_MESH \ > >> + CONFIG_SAE > > > > CONFIG_IEEE80211W appears commented out in wpa_supplicant/defconfig, so maybe > > use WPA_SUPPLICANT_CONFIG_ENABLE for that. Though I'm not sure about the > > reason for the distinction between WPA_SUPPLICANT_CONFIG and > > WPA_SUPPLICANT_CONFIG_SET. Isn't WPA_SUPPLICANT_CONFIG_SET enough for > > everything? > > Good catch. > > WPA_SUPPLICANT_CONFIG_ENABLE ensures we don't have the same CONFIG > option twice. Especially if it wasn't commented. What is wrong with having the same CONFIG option twice? baruch
diff --git a/package/wpa_supplicant/Config.in b/package/wpa_supplicant/Config.in index 454541f..9250a3b 100644 --- a/package/wpa_supplicant/Config.in +++ b/package/wpa_supplicant/Config.in @@ -45,6 +45,13 @@ config BR2_PACKAGE_WPA_SUPPLICANT_WIFI_DISPLAY help Enable support for Wi-Fi Display +config BR2_PACKAGE_WPA_SUPPLICANT_MESH_NETWORKING + bool "Enable mesh networking" + depends on BR2_PACKAGE_WPA_SUPPLICANT_AP_SUPPORT + help + Enable support for open and secured mesh networking + (IEEE 802.11s) + config BR2_PACKAGE_WPA_SUPPLICANT_AUTOSCAN bool "Enable autoscan" help diff --git a/package/wpa_supplicant/wpa_supplicant.mk b/package/wpa_supplicant/wpa_supplicant.mk index 3c3317b..29ef362 100644 --- a/package/wpa_supplicant/wpa_supplicant.mk +++ b/package/wpa_supplicant/wpa_supplicant.mk @@ -73,6 +73,12 @@ ifeq ($(BR2_PACKAGE_WPA_SUPPLICANT_WIFI_DISPLAY),y) WPA_SUPPLICANT_CONFIG_ENABLE += CONFIG_WIFI_DISPLAY endif +ifeq ($(BR2_PACKAGE_WPA_SUPPLICANT_MESH_NETWORKING),y) +WPA_SUPPLICANT_CONFIG_SET += CONFIG_IEEE80211W \ + CONFIG_MESH \ + CONFIG_SAE +endif + ifeq ($(BR2_PACKAGE_WPA_SUPPLICANT_AUTOSCAN),y) WPA_SUPPLICANT_CONFIG_ENABLE += \ CONFIG_AUTOSCAN_EXPONENTIAL \