From patchwork Mon Oct 25 20:57:04 2010 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: Mike Frysinger X-Patchwork-Id: 69140 Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@bilbo.ozlabs.org Received: from canuck.infradead.org (canuck.infradead.org [134.117.69.58]) (using TLSv1 with cipher DHE-RSA-AES256-SHA (256/256 bits)) (Client did not present a certificate) by ozlabs.org (Postfix) with ESMTPS id C8210B6F07 for ; Tue, 26 Oct 2010 08:00:30 +1100 (EST) Received: from localhost ([127.0.0.1] helo=canuck.infradead.org) by canuck.infradead.org with esmtp (Exim 4.72 #1 (Red Hat Linux)) id 1PAU6n-0006YV-JN; Mon, 25 Oct 2010 20:57:33 +0000 Received: from mail-wy0-f177.google.com ([74.125.82.177]) by canuck.infradead.org with esmtp (Exim 4.72 #1 (Red Hat Linux)) id 1PAU6k-0006Xx-Ok for linux-mtd@lists.infradead.org; Mon, 25 Oct 2010 20:57:31 +0000 Received: by wyf22 with SMTP id 22so3900175wyf.36 for ; Mon, 25 Oct 2010 13:57:29 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=gamma; h=domainkey-signature:received:mime-version:received:in-reply-to :references:from:date:message-id:subject:to:cc:content-type :content-transfer-encoding; bh=USm4ine5WHOS/IolgUGEscfqE1nt2YXvDWRQPDXqDIU=; b=m/zqXkedC0bbP0xoGfGNm3fASL++lNIA/DkWWqmrzFMlTdTTOPlvnQ4un8ZYSQcyxt s/GL7jmyIGQHsVCAChOF3LxNLNkUyZEcidVX2l+d8AM9TukwIme9k2wzAzkrQLkeCX3v BUc4xXDesuQAAhvwmyeswhlB2y6a+lnWh+9Mc= DomainKey-Signature: a=rsa-sha1; c=nofws; d=gmail.com; s=gamma; h=mime-version:in-reply-to:references:from:date:message-id:subject:to :cc:content-type:content-transfer-encoding; b=hb/2hsh/fAx4Uf36JlCy9M4RwWdfK4AP50fb3MEBIzLjF57Lvv//71KprVtTN0fG2q Q0tfL8UUI5/WT4nuxwfpgnKNoUP1P6QDdPoqlvEOrESZeEOhzW1SX9lfNw3j0r794/0v 3bxGHFOL6mmkhLYLI6h/PWeo8Hrbi2fSMLBBQ= Received: by 10.227.142.75 with SMTP id p11mr2447101wbu.27.1288040249241; Mon, 25 Oct 2010 13:57:29 -0700 (PDT) MIME-Version: 1.0 Received: by 10.216.65.131 with HTTP; Mon, 25 Oct 2010 13:57:04 -0700 (PDT) In-Reply-To: References: <201010211643.33332.manningc2@actrix.gen.nz> <1288033416.1865.2.camel@brekeke> From: Mike Frysinger Date: Mon, 25 Oct 2010 16:57:04 -0400 Message-ID: Subject: Re: Issues with ubi utils Makefile To: dedekind1@gmail.com X-CRM114-Version: 20090807-BlameThorstenAndJenny ( TRE 0.7.6 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20101025_165731_014564_C70D508A X-CRM114-Status: GOOD ( 13.30 ) X-Spam-Score: -0.1 (/) X-Spam-Report: SpamAssassin version 3.3.1 on canuck.infradead.org summary: Content analysis details: (-0.1 points) pts rule name description ---- ---------------------- -------------------------------------------------- -0.0 RCVD_IN_DNSWL_NONE RBL: Sender listed at http://www.dnswl.org/, low trust [74.125.82.177 listed in list.dnswl.org] 0.0 FREEMAIL_FROM Sender email is freemail (vapier.adi[at]gmail.com) -0.1 DKIM_VALID_AU Message has a valid DKIM or DK signature from author's domain 0.1 DKIM_SIGNED Message has a DKIM or DK signature, not necessarily valid -0.1 DKIM_VALID Message has at least one valid DKIM or DK signature 0.0 T_TO_NO_BRKTS_FREEMAIL T_TO_NO_BRKTS_FREEMAIL Cc: Charles Manning , linux-mtd@lists.infradead.org X-BeenThere: linux-mtd@lists.infradead.org X-Mailman-Version: 2.1.12 Precedence: list List-Id: Linux MTD discussion mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: linux-mtd-bounces@lists.infradead.org Errors-To: linux-mtd-bounces+incoming=patchwork.ozlabs.org@lists.infradead.org On Mon, Oct 25, 2010 at 16:45, Mike Frysinger wrote: > On Mon, Oct 25, 2010 at 15:03, Artem Bityutskiy wrote: >> Commit 96a4f76f2e9dad7fdbd6fd7740de44bc90d5769e broke 'make install'. >> Before that commit, $DESTDIR was undefined, so  ${DESTDIR}/${SBINDIR} >> was /usr/sbin, and after the commit $DESTDIR became /usr/local, so >> ${DESTDIR}/${SBINDIR} became /usr/local//usr/sbin, which is wrong. > > that isnt really true.  DESTDIR had value in makefiles before my changes. > >> Fix this by making $DESTDIR become the distination directory of installing, >> i.e. 'DESTDIR ?= /usr' and making SBINDIR become just 'sbin'. > > i'd rather we change DESTDIR to match the standard -- it's a "root" > prefix only.  so the default should be: > DESTDIR ?= i guess this is also why i never noticed before. i never do plain `make install` since i'm not root and i dont want it clobbering things. i always do `make install DESTDIR=$PWD/foo` when testing and in that regard, it works fine. so i guess we want this simple change: -mike --- a/common.mk +++ b/common.mk @@ -20,7 +20,7 @@ ifneq ($(WITHOUT_LARGEFILE), 1) CPPFLAGS += -D_FILE_OFFSET_BITS=64 endif -DESTDIR ?= /usr/local +DESTDIR?= PREFIX=/usr EXEC_PREFIX=$(PREFIX) SBINDIR=$(EXEC_PREFIX)/sbin