From patchwork Mon Oct 25 19:03:36 2010 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Artem Bityutskiy X-Patchwork-Id: 69131 Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@bilbo.ozlabs.org Received: from canuck.infradead.org (canuck.infradead.org [134.117.69.58]) (using TLSv1 with cipher DHE-RSA-AES256-SHA (256/256 bits)) (Client did not present a certificate) by ozlabs.org (Postfix) with ESMTPS id EF0ADB70A5 for ; Tue, 26 Oct 2010 06:07:49 +1100 (EST) Received: from localhost ([127.0.0.1] helo=canuck.infradead.org) by canuck.infradead.org with esmtp (Exim 4.72 #1 (Red Hat Linux)) id 1PASKm-0007Hq-BO; Mon, 25 Oct 2010 19:03:52 +0000 Received: from mail-fx0-f49.google.com ([209.85.161.49]) by canuck.infradead.org with esmtp (Exim 4.72 #1 (Red Hat Linux)) id 1PASKd-0007GS-KS for linux-mtd@lists.infradead.org; Mon, 25 Oct 2010 19:03:49 +0000 Received: by fxm15 with SMTP id 15so2653519fxm.36 for ; Mon, 25 Oct 2010 12:03:41 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=gamma; h=domainkey-signature:received:received:subject:from:reply-to:to:cc :in-reply-to:references:content-type:date:message-id:mime-version :x-mailer:content-transfer-encoding; bh=CJmWT7AzwKPT1Fzn+4E+CQ/dLYAotXz9JxZMc35d1EQ=; b=j+9x/dCb1HsqRCLRBBT6QfbCu+MlCk7CX8ho0MYSBjDsO2JZ2ZT/zr8+tMHykJbEux 0zOGmWaPPTcggdIYJYIEIeCaSA5unLBK+Nw2s74BTBOtB3qWUithPU5ySITy7FmwR57Z h5HdBPB/G/I0d9AFKEZgxMQ/ir2Iu543E53N8= DomainKey-Signature: a=rsa-sha1; c=nofws; d=gmail.com; s=gamma; h=subject:from:reply-to:to:cc:in-reply-to:references:content-type :date:message-id:mime-version:x-mailer:content-transfer-encoding; b=Ll+FT1moGSTBVn5c8mAxgLoj5f79A3q3xKBSYoE+4fUzV1AqbOq7Xa8J/MoIFsdoUu gw4Oa9j4ssqYH3HQggq5k970jTWkojsiK2po8lpdAcdUVP6VxAfA536sbtlVsGMcfQqu LPYbsKgi+8iW8Ha/FQNXN+44zAp/MbAfD0StM= Received: by 10.223.78.199 with SMTP id m7mr47106fak.11.1288033420592; Mon, 25 Oct 2010 12:03:40 -0700 (PDT) Received: from [192.168.255.16] (a91-152-69-107.elisa-laajakaista.fi [91.152.69.107]) by mx.google.com with ESMTPS id m8sm3100172faj.35.2010.10.25.12.03.38 (version=SSLv3 cipher=RC4-MD5); Mon, 25 Oct 2010 12:03:38 -0700 (PDT) Subject: Re: Issues with ubi utils Makefile From: Artem Bityutskiy To: Charles Manning , Mike Frysinger In-Reply-To: <201010211643.33332.manningc2@actrix.gen.nz> References: <201010211643.33332.manningc2@actrix.gen.nz> Date: Mon, 25 Oct 2010 22:03:36 +0300 Message-ID: <1288033416.1865.2.camel@brekeke> Mime-Version: 1.0 X-Mailer: Evolution 2.30.3 (2.30.3-1.fc13) X-CRM114-Version: 20090807-BlameThorstenAndJenny ( TRE 0.7.6 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20101025_150343_827950_493BDD18 X-CRM114-Status: GOOD ( 19.54 ) X-Spam-Score: 2.1 (++) X-Spam-Report: SpamAssassin version 3.3.1 on canuck.infradead.org summary: Content analysis details: (2.1 points) pts rule name description ---- ---------------------- -------------------------------------------------- 0.0 FREEMAIL_FROM Sender email is freemail (dedekind1[at]gmail.com) 2.2 FREEMAIL_ENVFROM_END_DIGIT Envelope-from freemail username ends in digit (dedekind1[at]gmail.com) -0.1 DKIM_VALID_AU Message has a valid DKIM or DK signature from author's domain 0.1 DKIM_SIGNED Message has a DKIM or DK signature, not necessarily valid -0.1 DKIM_VALID Message has at least one valid DKIM or DK signature -0.0 RCVD_IN_DNSWL_NONE RBL: Sender listed at http://www.dnswl.org/, low trust [209.85.161.49 listed in list.dnswl.org] Cc: linux-mtd@lists.infradead.org X-BeenThere: linux-mtd@lists.infradead.org X-Mailman-Version: 2.1.12 Precedence: list Reply-To: dedekind1@gmail.com List-Id: Linux MTD discussion mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: linux-mtd-bounces@lists.infradead.org Errors-To: linux-mtd-bounces+incoming=patchwork.ozlabs.org@lists.infradead.org On Thu, 2010-10-21 at 16:43 +1300, Charles Manning wrote: > Hi All > > I'm getting some errors trying to mount a ubinized volume with a more recent > kernel and think it might be due to problems in the ubi utils distributed > with Ubuntu Meerkat. > > I thus thought I'd build from git > > When I do a make install from inside the mtd-utils/ubi-utils it tries to place > the binaries in /usr/local//usr/sbin. > > Same happens if I try make install from mtd-utils/ > > Is something broken or am I driving it incorrectly? Looks like Mike's commit broke it: commit 96a4f76f2e9dad7fdbd6fd7740de44bc90d5769e Author: Mike Frysinger Unify all common build system parts I've quickly cooked this fix, does it work for you? Mike, are you ok with this? From 69148e5bb5b0aa546c097a76e293585b3a839e0c Mon Sep 17 00:00:00 2001 From: Artem Bityutskiy Date: Mon, 25 Oct 2010 21:54:47 +0300 Subject: [PATCH] mtd-utils: fix make install Commit 96a4f76f2e9dad7fdbd6fd7740de44bc90d5769e broke 'make install'. Before that commit, $DESTDIR was undefined, so ${DESTDIR}/${SBINDIR} was /usr/sbin, and after the commit $DESTDIR became /usr/local, so ${DESTDIR}/${SBINDIR} became /usr/local//usr/sbin, which is wrong. Fix this by making $DESTDIR become the distination directory of installing, i.e. 'DESTDIR ?= /usr' and making SBINDIR become just 'sbin'. While we are on it, fix $MANDIR similarly, and remove $PREFIX and $EXEC_PREFIX variables, which become unneeded. Signed-off-by: Artem Bityutskiy Reported-by: Charles Manning --- common.mk | 9 +++------ 1 files changed, 3 insertions(+), 6 deletions(-) diff --git a/common.mk b/common.mk index a55c548..2e4452f 100644 --- a/common.mk +++ b/common.mk @@ -20,12 +20,9 @@ ifneq ($(WITHOUT_LARGEFILE), 1) CPPFLAGS += -D_FILE_OFFSET_BITS=64 endif -DESTDIR ?= /usr/local -PREFIX=/usr -EXEC_PREFIX=$(PREFIX) -SBINDIR=$(EXEC_PREFIX)/sbin -MANDIR=$(PREFIX)/share/man -INCLUDEDIR=$(PREFIX)/include +DESTDIR ?= /usr +SBINDIR=sbin +MANDIR=share/man ifndef BUILDDIR ifeq ($(origin CROSS),undefined)