| Message ID | 1478194822-29545-3-git-send-email-johan@kernel.org |
|---|---|
| State | Accepted, archived |
| Delegated to: | David Miller |
| Headers | show |
On 11/03/2016 12:40 PM, Johan Hovold wrote: > Make sure to drop the references taken by of_get_child_by_name() and > bus_find_device() before returning from cpsw_phy_sel(). > > Note that holding a reference to the cpsw-phy-sel device does not > prevent the devres-managed private data from going away. > > Fixes: 5892cd135e16 ("drivers: net: cpsw-phy-sel: Add new driver...") > Cc: Mugunthan V N <mugunthanvnm@ti.com> > Cc: Grygorii Strashko <grygorii.strashko@ti.com> > Cc: linux-omap@vger.kernel.org > Signed-off-by: Johan Hovold <johan@kernel.org> > --- Reviewed-by: Grygorii Strashko <grygorii.strashko@ti.com> > drivers/net/ethernet/ti/cpsw-phy-sel.c | 3 +++ > 1 file changed, 3 insertions(+) > > diff --git a/drivers/net/ethernet/ti/cpsw-phy-sel.c b/drivers/net/ethernet/ti/cpsw-phy-sel.c > index 054a8dd23dae..ba1e45ff6aae 100644 > --- a/drivers/net/ethernet/ti/cpsw-phy-sel.c > +++ b/drivers/net/ethernet/ti/cpsw-phy-sel.c > @@ -176,9 +176,12 @@ void cpsw_phy_sel(struct device *dev, phy_interface_t phy_mode, int slave) > } > > dev = bus_find_device(&platform_bus_type, NULL, node, match); > + of_node_put(node); > priv = dev_get_drvdata(dev); > > priv->cpsw_phy_sel(priv, phy_mode, slave); > + > + put_device(dev); > } > EXPORT_SYMBOL_GPL(cpsw_phy_sel); > >
On Tue, Nov 08, 2016 at 05:19:29PM -0600, Grygorii Strashko wrote: > > > On 11/03/2016 12:40 PM, Johan Hovold wrote: > > Make sure to drop the references taken by of_get_child_by_name() and > > bus_find_device() before returning from cpsw_phy_sel(). > > > > Note that holding a reference to the cpsw-phy-sel device does not > > prevent the devres-managed private data from going away. > > > > Fixes: 5892cd135e16 ("drivers: net: cpsw-phy-sel: Add new driver...") > > Cc: Mugunthan V N <mugunthanvnm@ti.com> > > Cc: Grygorii Strashko <grygorii.strashko@ti.com> > > Cc: linux-omap@vger.kernel.org > > Signed-off-by: Johan Hovold <johan@kernel.org> > > --- > > Reviewed-by: Grygorii Strashko <grygorii.strashko@ti.com> Thanks for the review. Note that David has already applied these, though. Johan
diff --git a/drivers/net/ethernet/ti/cpsw-phy-sel.c b/drivers/net/ethernet/ti/cpsw-phy-sel.c index 054a8dd23dae..ba1e45ff6aae 100644 --- a/drivers/net/ethernet/ti/cpsw-phy-sel.c +++ b/drivers/net/ethernet/ti/cpsw-phy-sel.c @@ -176,9 +176,12 @@ void cpsw_phy_sel(struct device *dev, phy_interface_t phy_mode, int slave) } dev = bus_find_device(&platform_bus_type, NULL, node, match); + of_node_put(node); priv = dev_get_drvdata(dev); priv->cpsw_phy_sel(priv, phy_mode, slave); + + put_device(dev); } EXPORT_SYMBOL_GPL(cpsw_phy_sel);
Make sure to drop the references taken by of_get_child_by_name() and bus_find_device() before returning from cpsw_phy_sel(). Note that holding a reference to the cpsw-phy-sel device does not prevent the devres-managed private data from going away. Fixes: 5892cd135e16 ("drivers: net: cpsw-phy-sel: Add new driver...") Cc: Mugunthan V N <mugunthanvnm@ti.com> Cc: Grygorii Strashko <grygorii.strashko@ti.com> Cc: linux-omap@vger.kernel.org Signed-off-by: Johan Hovold <johan@kernel.org> --- drivers/net/ethernet/ti/cpsw-phy-sel.c | 3 +++ 1 file changed, 3 insertions(+)