Patchwork [RFC] msi: remove range checks

login
register
mail settings
Submitter Michael S. Tsirkin
Date Oct. 25, 2010, 6:07 a.m.
Message ID <20101025060725.GA3533@redhat.com>
Download mbox | patch
Permalink /patch/69076/
State New
Headers show

Comments

Michael S. Tsirkin - Oct. 25, 2010, 6:07 a.m.
config write handlers should be idempotent.
So no need for range checks.

Signed-off-by: Michael S. Tsirkin <mst@redhat.com>
---
 hw/msi.c |   29 -----------------------------
 1 files changed, 0 insertions(+), 29 deletions(-)

Patch

diff --git a/hw/msi.c b/hw/msi.c
index a949d82..af8ea44 100644
--- a/hw/msi.c
+++ b/hw/msi.c
@@ -257,35 +257,6 @@  void msi_write_config(PCIDevice *dev, uint32_t addr, uint32_t val, int len)
     uint32_t pending;
     int i;
 
-#ifdef MSI_DEBUG
-    if (ranges_overlap(addr, len, dev->msi_cap, msi_cap_sizeof(flags))) {
-        MSI_DEV_PRINTF(dev, "addr 0x%"PRIx32" val 0x%"PRIx32" len %d\n",
-                       addr, val, len);
-        MSI_DEV_PRINTF(dev, "ctrl: 0x%"PRIx16" address: 0x%"PRIx32,
-                       flags,
-                       pci_get_long(dev->config + msi_address_lo_off(dev)));
-        if (msi64bit) {
-            fprintf(stderr, " addrss-hi: 0x%"PRIx32,
-                    pci_get_long(dev->config + msi_address_hi_off(dev)));
-        }
-        fprintf(stderr, " data: 0x%"PRIx16,
-                pci_get_word(dev->config + msi_data_off(dev, msi64bit)));
-        if (flags & PCI_MSI_FLAGS_MASKBIT) {
-            fprintf(stderr, " mask 0x%"PRIx32" pending 0x%"PRIx32,
-                    pci_get_long(dev->config + msi_mask_off(dev, msi64bit)),
-                    pci_get_long(dev->config + msi_pending_off(dev, msi64bit)));
-        }
-        fprintf(stderr, "\n");
-    }
-#endif
-
-    /* Are we modified? */
-    if (!(ranges_overlap(addr, len, msi_flags_off(dev), 2) ||
-          (msi_per_vector_mask &&
-           ranges_overlap(addr, len, msi_mask_off(dev, msi64bit), 4)))) {
-        return;
-    }
-
     if (!(flags & PCI_MSI_FLAGS_ENABLE)) {
         return;
     }