Patchwork powerpc/mpc5200: MPC5200 ATA driver requires BMDMA to be configured

login
register
mail settings
Submitter Roman Fietze
Date Oct. 25, 2010, 7:21 a.m.
Message ID <201010250921.59640.roman.fietze@telemotive.de>
Download mbox | patch
Permalink /patch/69071/
State Accepted
Delegated to: Grant Likely
Headers show

Comments

Roman Fietze - Oct. 25, 2010, 7:21 a.m.
Hello List Members,

I updated to v2.6.34 from torvalds/master.

While playing around with ATA settings (I have problems with MWDMA2 on
a Lite5200B compatible board, the problems are not related to this
patch here), I also turned off BMDMA, which caused compile errors on
pata_mpc52xx. So my question is, is the patch below correct? Should we
only offer the pata_mpc52xx if BMDMA is configured?


Subject: [PATCH] powerpc/mpc5200: MPC5200 ATA driver requires BMDMA to be 
configured

The driver uses e.g. bmdma_setup which is only available with
ATA_BMDMA beeing configured.

Move the configuration of the driver pata_mpc52xx down in Kconfig to
the section "PATA SFF controllers with BMDMA".

Signed-off-by: Roman Fietze <roman.fietze@telemotive.de>
---
 drivers/ata/Kconfig |   20 ++++++++++----------
 1 files changed, 10 insertions(+), 10 deletions(-)

Patch

diff --git a/drivers/ata/Kconfig b/drivers/ata/Kconfig
index 11ec911..85756b8 100644
--- a/drivers/ata/Kconfig
+++ b/drivers/ata/Kconfig
@@ -128,16 +128,6 @@  config PDC_ADMA
 
 	  If unsure, say N.
 
-config PATA_MPC52xx
-	tristate "Freescale MPC52xx SoC internal IDE"
-	depends on PPC_MPC52xx && PPC_BESTCOMM
-	select PPC_BESTCOMM_ATA
-	help
-	  This option enables support for integrated IDE controller
-	  of the Freescale MPC52xx SoC.
-
-	  If unsure, say N.
-
 config PATA_OCTEON_CF
 	tristate "OCTEON Boot Bus Compact Flash support"
 	depends on CPU_CAVIUM_OCTEON
@@ -491,6 +481,16 @@  config PATA_MARVELL
 
 	  If unsure, say N.
 
+config PATA_MPC52xx
+	tristate "Freescale MPC52xx SoC internal IDE"
+	depends on PPC_MPC52xx && PPC_BESTCOMM
+	select PPC_BESTCOMM_ATA
+	help
+	  This option enables support for integrated IDE controller
+	  of the Freescale MPC52xx SoC.
+
+	  If unsure, say N.
+
 config PATA_NETCELL
 	tristate "NETCELL Revolution RAID support"
 	depends on PCI