| Message ID | 1478148061-5724-1-git-send-email-mpe@ellerman.id.au (mailing list archive) |
|---|---|
| State | Accepted |
| Headers | show |
On Thu, 2016-03-11 at 04:41:00 UTC, Michael Ellerman wrote: > If the load unaligned zeropad test takes a SEGV which can't be handled, > we increment segv_error, print the offending NIP and then return without > taking any further action. In almost all cases this means we'll just > take the SEGV again, and loop eternally spamming the console. > > Instead just abort(), it's a fatal error in the test. The test harness > will notice that the child died and print a nice message for us. > > Signed-off-by: Michael Ellerman <mpe@ellerman.id.au> Applied to powerpc next. https://git.kernel.org/powerpc/c/06236f4efb926aa433e2cb3e36e846 cheers
diff --git a/tools/testing/selftests/powerpc/primitives/load_unaligned_zeropad.c b/tools/testing/selftests/powerpc/primitives/load_unaligned_zeropad.c index 6cae06117b55..cf7a4a114a90 100644 --- a/tools/testing/selftests/powerpc/primitives/load_unaligned_zeropad.c +++ b/tools/testing/selftests/powerpc/primitives/load_unaligned_zeropad.c @@ -73,7 +73,6 @@ extern char __stop___ex_table[]; #error implement UCONTEXT_NIA #endif -static int segv_error; static void segv_handler(int signr, siginfo_t *info, void *ptr) { @@ -95,7 +94,7 @@ static void segv_handler(int signr, siginfo_t *info, void *ptr) } printf("No exception table match for NIA %lx ADDR %lx\n", *ip, addr); - segv_error++; + abort(); } static void setup_segv_handler(void) @@ -145,8 +144,6 @@ static int test_body(void) for (i = 0; i < page_size; i++) FAIL_IF(do_one_test(mem_region+i, i)); - FAIL_IF(segv_error); - return 0; }
If the load unaligned zeropad test takes a SEGV which can't be handled, we increment segv_error, print the offending NIP and then return without taking any further action. In almost all cases this means we'll just take the SEGV again, and loop eternally spamming the console. Instead just abort(), it's a fatal error in the test. The test harness will notice that the child died and print a nice message for us. Signed-off-by: Michael Ellerman <mpe@ellerman.id.au> --- tools/testing/selftests/powerpc/primitives/load_unaligned_zeropad.c | 5 +---- 1 file changed, 1 insertion(+), 4 deletions(-)