| Message ID | 1478097406-9794-1-git-send-email-Yuval.Mintz@cavium.com |
|---|---|
| State | Accepted, archived |
| Delegated to: | David Miller |
| Headers | show |
From: Yuval Mintz <Yuval.Mintz@cavium.com> Date: Wed, 2 Nov 2016 16:36:46 +0200 > Driver allocates replacement buffers before-hand to make > sure whenever an aggregation begins there would be a replacement > for the Rx buffers, as we can't release the buffer until > aggregation is terminated and driver logic assumes the Rx rings > are always full. > > For every other Rx page that's being allocated [I.e., regular] > the page is being completely mapped while for the replacement > buffers only the first portion of the page is being mapped. > This means that: > a. Once replacement buffer replenishes the regular Rx ring, > assuming there's more than a single packet on page we'd post unmapped > memory toward HW [assuming mapping is actually done in granularity > smaller than page]. > b. Unmaps are being done for the entire page, which is incorrect. > > Fixes: 55482edc25f06 ("qede: Add slowpath/fastpath support and enable hardware GRO") > Signed-off-by: Yuval Mintz <Yuval.Mintz@cavium.com> Applied.
diff --git a/drivers/net/ethernet/qlogic/qede/qede_main.c b/drivers/net/ethernet/qlogic/qede/qede_main.c index 1391776..73f2a67 100644 --- a/drivers/net/ethernet/qlogic/qede/qede_main.c +++ b/drivers/net/ethernet/qlogic/qede/qede_main.c @@ -2918,7 +2918,7 @@ static int qede_alloc_sge_mem(struct qede_dev *edev, struct qede_rx_queue *rxq) } mapping = dma_map_page(&edev->pdev->dev, replace_buf->data, 0, - rxq->rx_buf_size, DMA_FROM_DEVICE); + PAGE_SIZE, DMA_FROM_DEVICE); if (unlikely(dma_mapping_error(&edev->pdev->dev, mapping))) { DP_NOTICE(edev, "Failed to map TPA replacement buffer\n");
Driver allocates replacement buffers before-hand to make sure whenever an aggregation begins there would be a replacement for the Rx buffers, as we can't release the buffer until aggregation is terminated and driver logic assumes the Rx rings are always full. For every other Rx page that's being allocated [I.e., regular] the page is being completely mapped while for the replacement buffers only the first portion of the page is being mapped. This means that: a. Once replacement buffer replenishes the regular Rx ring, assuming there's more than a single packet on page we'd post unmapped memory toward HW [assuming mapping is actually done in granularity smaller than page]. b. Unmaps are being done for the entire page, which is incorrect. Fixes: 55482edc25f06 ("qede: Add slowpath/fastpath support and enable hardware GRO") Signed-off-by: Yuval Mintz <Yuval.Mintz@cavium.com> --- Dave, Please consider applying this to `net'. Thanks, Yuval --- drivers/net/ethernet/qlogic/qede/qede_main.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)