diff mbox

m68k: Add include/hw/m68k/ and disas/m68k.c to the MAINTAINERS file

Message ID 1478076128-11661-1-git-send-email-thuth@redhat.com
State New
Headers show

Commit Message

Thomas Huth Nov. 2, 2016, 8:42 a.m. UTC
The include/hw/m68k/ folder and disas/m68k.c obviously belong to
the m68k section in the MAINTAINERS file.

Signed-off-by: Thomas Huth <thuth@redhat.com>
---
 MAINTAINERS | 2 ++
 1 file changed, 2 insertions(+)

Comments

Laurent Vivier Nov. 2, 2016, 8:51 a.m. UTC | #1
Le 02/11/2016 à 09:42, Thomas Huth a écrit :
> The include/hw/m68k/ folder and disas/m68k.c obviously belong to
> the m68k section in the MAINTAINERS file.
> 
> Signed-off-by: Thomas Huth <thuth@redhat.com>
> ---
>  MAINTAINERS | 2 ++
>  1 file changed, 2 insertions(+)
> 
> diff --git a/MAINTAINERS b/MAINTAINERS
> index 79484ed..5d45160 100644
> --- a/MAINTAINERS
> +++ b/MAINTAINERS
> @@ -149,6 +149,8 @@ M: Laurent Vivier <laurent@vivier.eu>
>  S: Maintained
>  F: target-m68k/
>  F: hw/m68k/
> +F: include/hw/m68k/

Under this directory, we have only mcf.h, which is used by M68K
machines, not by TCG, so I think this include should be added to the
"M68K Machines" section. "hw/m68k" should also be moved to the machines
section too (hw/m68K/*.c in the machines section are overridden by this
entry).

> +F: disas/m68k.c
>  
>  MicroBlaze
>  M: Edgar E. Iglesias <edgar.iglesias@gmail.com>
> 

Thanks,
Laurent
Thomas Huth Nov. 2, 2016, 11:24 a.m. UTC | #2
On 02.11.2016 09:51, Laurent Vivier wrote:
> 
> Le 02/11/2016 à 09:42, Thomas Huth a écrit :
>> The include/hw/m68k/ folder and disas/m68k.c obviously belong to
>> the m68k section in the MAINTAINERS file.
>>
>> Signed-off-by: Thomas Huth <thuth@redhat.com>
>> ---
>>  MAINTAINERS | 2 ++
>>  1 file changed, 2 insertions(+)
>>
>> diff --git a/MAINTAINERS b/MAINTAINERS
>> index 79484ed..5d45160 100644
>> --- a/MAINTAINERS
>> +++ b/MAINTAINERS
>> @@ -149,6 +149,8 @@ M: Laurent Vivier <laurent@vivier.eu>
>>  S: Maintained
>>  F: target-m68k/
>>  F: hw/m68k/
>> +F: include/hw/m68k/
> 
> Under this directory, we have only mcf.h, which is used by M68K
> machines, not by TCG, so I think this include should be added to the
> "M68K Machines" section.

OK. But the M68k Machines are currently orphan, so I guess that's not
worth the effort for a patch here.

>> +F: disas/m68k.c

Feel free to still include that line if you like.

 Thanks,
  Thomas
diff mbox

Patch

diff --git a/MAINTAINERS b/MAINTAINERS
index 79484ed..5d45160 100644
--- a/MAINTAINERS
+++ b/MAINTAINERS
@@ -149,6 +149,8 @@  M: Laurent Vivier <laurent@vivier.eu>
 S: Maintained
 F: target-m68k/
 F: hw/m68k/
+F: include/hw/m68k/
+F: disas/m68k.c
 
 MicroBlaze
 M: Edgar E. Iglesias <edgar.iglesias@gmail.com>