| Message ID | 20161101140933.859-1-kraai@ftbfs.org |
|---|---|
| State | Changes Requested |
| Headers | show |
Hello, On Tue, 1 Nov 2016 07:09:32 -0700, Matt Kraai wrote: > Signed-off-by: Matt Kraai <kraai@ftbfs.org> > --- > package/qt5/qt5webchannel/qt5webchannel.mk | 6 ------ > 1 file changed, 6 deletions(-) Rather than removing these, we should instead make it consistent with what qt5engineio is doing, i.e install those examples. See qt5engineio.mk. Could you rework your patches accordingly? Thanks! Thomas
Hi, On Tue, Nov 01, 2016 at 03:37:01PM +0100, Thomas Petazzoni wrote: > On Tue, 1 Nov 2016 07:09:32 -0700, Matt Kraai wrote: > > Signed-off-by: Matt Kraai <kraai@ftbfs.org> > > --- > > package/qt5/qt5webchannel/qt5webchannel.mk | 6 ------ > > 1 file changed, 6 deletions(-) > > Rather than removing these, we should instead make it consistent with > what qt5engineio is doing, i.e install those examples. See > qt5engineio.mk. > > Could you rework your patches accordingly? I've sent updated patches. Thank you for the suggestion on a better approach.
diff --git a/package/qt5/qt5webchannel/qt5webchannel.mk b/package/qt5/qt5webchannel/qt5webchannel.mk index 9e94914..316b8e0 100644 --- a/package/qt5/qt5webchannel/qt5webchannel.mk +++ b/package/qt5/qt5webchannel/qt5webchannel.mk @@ -46,12 +46,6 @@ define QT5WEBCHANNEL_INSTALL_TARGET_QMLS endef endif -ifeq ($(BR2_PACKAGE_QT5BASE_EXAMPLES),y) -define QT5WEBCHANNEL_INSTALL_TARGET_EXAMPLES - cp -dpfr $(STAGING_DIR)/usr/lib/qt/examples/webchannel $(TARGET_DIR)/usr/lib/qt/examples/ -endef -endif - ifneq ($(BR2_STATIC_LIBS),y) define QT5WEBCHANNEL_INSTALL_TARGET_LIBS cp -dpf $(STAGING_DIR)/usr/lib/libQt5WebChannel.so.* $(TARGET_DIR)/usr/lib
Signed-off-by: Matt Kraai <kraai@ftbfs.org> --- package/qt5/qt5webchannel/qt5webchannel.mk | 6 ------ 1 file changed, 6 deletions(-)