| Message ID | 1477960895-1062-1-git-send-email-iboukris@gmail.com |
|---|---|
| State | Accepted, archived |
| Delegated to: | David Miller |
| Headers | show |
From: Isaac Boukris <iboukris@gmail.com> Date: Tue, 1 Nov 2016 02:41:35 +0200 > Abstract unix domain socket may embed null characters, > these should be translated to '@' when printed out to > proc the same way the null prefix is currently being > translated. > > This helps for tools such as netstat, lsof and the proc > based implementation in ss to show all the significant > bytes of the name (instead of getting cut at the first > null occurrence). > > Signed-off-by: Isaac Boukris <iboukris@gmail.com> Applied, thank you.
diff --git a/net/unix/af_unix.c b/net/unix/af_unix.c index 145082e..5d1c14a 100644 --- a/net/unix/af_unix.c +++ b/net/unix/af_unix.c @@ -2812,7 +2812,8 @@ static int unix_seq_show(struct seq_file *seq, void *v) i++; } for ( ; i < len; i++) - seq_putc(seq, u->addr->name->sun_path[i]); + seq_putc(seq, u->addr->name->sun_path[i] ?: + '@'); } unix_state_unlock(s); seq_putc(seq, '\n');
Abstract unix domain socket may embed null characters, these should be translated to '@' when printed out to proc the same way the null prefix is currently being translated. This helps for tools such as netstat, lsof and the proc based implementation in ss to show all the significant bytes of the name (instead of getting cut at the first null occurrence). Signed-off-by: Isaac Boukris <iboukris@gmail.com> --- net/unix/af_unix.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-)