| Message ID | 1477937214-20899-1-git-send-email-ashijeetacharya@gmail.com |
|---|---|
| State | New |
| Headers | show |
Am 31.10.2016 um 19:06 hat Ashijeet Acharya geschrieben: > This patch drops the unused parameter "BDRVSSHState" being passed into > the ssh_config() function and fixes the bug. > > Signed-off-by: Ashijeet Acharya <ashijeetacharya@gmail.com> The patch looks good, but why do claim that this is a bug fix rather than just a code cleanup? Kevin
On Wed, Nov 2, 2016 at 4:03 PM, Kevin Wolf <kwolf@redhat.com> wrote: > Am 31.10.2016 um 19:06 hat Ashijeet Acharya geschrieben: >> This patch drops the unused parameter "BDRVSSHState" being passed into >> the ssh_config() function and fixes the bug. >> >> Signed-off-by: Ashijeet Acharya <ashijeetacharya@gmail.com> > > The patch looks good, but why do claim that this is a bug fix rather > than just a code cleanup? Okay, I will change the commit message and include the commit id in this one too. Ashijeet > > Kevin
diff --git a/block/ssh.c b/block/ssh.c index ca071c5..15ed281 100644 --- a/block/ssh.c +++ b/block/ssh.c @@ -582,8 +582,7 @@ static bool ssh_process_legacy_socket_options(QDict *output_opts, return true; } -static InetSocketAddress *ssh_config(BDRVSSHState *s, QDict *options, - Error **errp) +static InetSocketAddress *ssh_config(QDict *options, Error **errp) { InetSocketAddress *inet = NULL; QDict *addr = NULL; @@ -661,7 +660,7 @@ static int connect_to_ssh(BDRVSSHState *s, QDict *options, } /* Pop the config into our state object, Exit if invalid */ - s->inet = ssh_config(s, options, errp); + s->inet = ssh_config(options, errp); if (!s->inet) { ret = -EINVAL; goto err;
This patch drops the unused parameter "BDRVSSHState" being passed into the ssh_config() function and fixes the bug. Signed-off-by: Ashijeet Acharya <ashijeetacharya@gmail.com> --- block/ssh.c | 5 ++--- 1 file changed, 2 insertions(+), 3 deletions(-)