Message ID | 1477918137-25258-2-git-send-email-yann.morin.1998@free.fr |
---|---|
State | Accepted |
Headers | show |
On Mon, Oct 31, 2016 at 8:48 AM, Yann E. MORIN <yann.morin.1998@free.fr> wrote: > Signed-off-by: "Yann E. MORIN" <yann.morin.1998@free.fr> > Cc: Philippe Proulx <eeppeliteloop@gmail.com> > --- > package/babeltrace/babeltrace.mk | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > > diff --git a/package/babeltrace/babeltrace.mk b/package/babeltrace/babeltrace.mk > index d178a6c..17eaaaa 100644 > --- a/package/babeltrace/babeltrace.mk > +++ b/package/babeltrace/babeltrace.mk > @@ -12,8 +12,8 @@ BABELTRACE_LICENSE_FILES = mit-license.txt gpl-2.0.txt LICENSE > BABELTRACE_DEPENDENCIES = popt util-linux libglib2 host-pkgconf > BABELTRACE_CONF_OPTS += --disable-debug-info > HOST_BABELTRACE_DEPENDENCIES = \ > - host-popt host-util-linux host-libglib2 host-pkgconf > -HOST_BABELTRACE_CONF_OPTS += --disable-debug-info > + host-popt host-util-linux host-libglib2 host-pkgconf host-elfutils > +HOST_BABELTRACE_CONF_OPTS += --ensable-debug-info Oops! > > # For 0001-configure.ac-remove-elfutils-version-test-for-Buildr.patch > BABELTRACE_AUTORECONF = YES > -- > 2.7.4 >
Hello, On Mon, 31 Oct 2016 13:48:57 +0100, Yann E. MORIN wrote: > Signed-off-by: "Yann E. MORIN" <yann.morin.1998@free.fr> > Cc: Philippe Proulx <eeppeliteloop@gmail.com> > --- > package/babeltrace/babeltrace.mk | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > > diff --git a/package/babeltrace/babeltrace.mk b/package/babeltrace/babeltrace.mk > index d178a6c..17eaaaa 100644 > --- a/package/babeltrace/babeltrace.mk > +++ b/package/babeltrace/babeltrace.mk > @@ -12,8 +12,8 @@ BABELTRACE_LICENSE_FILES = mit-license.txt gpl-2.0.txt LICENSE > BABELTRACE_DEPENDENCIES = popt util-linux libglib2 host-pkgconf > BABELTRACE_CONF_OPTS += --disable-debug-info > HOST_BABELTRACE_DEPENDENCIES = \ > - host-popt host-util-linux host-libglib2 host-pkgconf > -HOST_BABELTRACE_CONF_OPTS += --disable-debug-info > + host-popt host-util-linux host-libglib2 host-pkgconf host-elfutils Since the dependency on elfutils is not mandatory, do we really want to force building the support of debug info? Thomas
On Wed, Nov 2, 2016 at 6:29 PM, Thomas Petazzoni <thomas.petazzoni@free-electrons.com> wrote: > Hello, > > On Mon, 31 Oct 2016 13:48:57 +0100, Yann E. MORIN wrote: >> Signed-off-by: "Yann E. MORIN" <yann.morin.1998@free.fr> >> Cc: Philippe Proulx <eeppeliteloop@gmail.com> >> --- >> package/babeltrace/babeltrace.mk | 4 ++-- >> 1 file changed, 2 insertions(+), 2 deletions(-) >> >> diff --git a/package/babeltrace/babeltrace.mk b/package/babeltrace/babeltrace.mk >> index d178a6c..17eaaaa 100644 >> --- a/package/babeltrace/babeltrace.mk >> +++ b/package/babeltrace/babeltrace.mk >> @@ -12,8 +12,8 @@ BABELTRACE_LICENSE_FILES = mit-license.txt gpl-2.0.txt LICENSE >> BABELTRACE_DEPENDENCIES = popt util-linux libglib2 host-pkgconf >> BABELTRACE_CONF_OPTS += --disable-debug-info >> HOST_BABELTRACE_DEPENDENCIES = \ >> - host-popt host-util-linux host-libglib2 host-pkgconf >> -HOST_BABELTRACE_CONF_OPTS += --disable-debug-info >> + host-popt host-util-linux host-libglib2 host-pkgconf host-elfutils > > Since the dependency on elfutils is not mandatory, do we really want to > force building the support of debug info? Ideally, no. I guess we should use the same strategy as for the target package. Phil > > Thomas > -- > Thomas Petazzoni, CTO, Free Electrons > Embedded Linux and Kernel engineering > http://free-electrons.com
Hello, On Wed, 2 Nov 2016 19:07:11 -0400, Philippe Proulx wrote: > > Since the dependency on elfutils is not mandatory, do we really want to > > force building the support of debug info? > > Ideally, no. I guess we should use the same strategy as for the target package. Except we don't have Config.in options for host packages, and even if we plan to add such options, we clearly don't want to add *visible* options for every host package. So for the host-lttng-babeltrace, the only solution would be to have a sub-option to enable debug info support. But that would make it handled differently than the debug info dependency for the target lttng-babeltrace. I don't really have a good answer here, I'm afraid. Thomas
On Thu, Nov 3, 2016 at 4:25 AM, Thomas Petazzoni <thomas.petazzoni@free-electrons.com> wrote: > Hello, > > On Wed, 2 Nov 2016 19:07:11 -0400, Philippe Proulx wrote: > >> > Since the dependency on elfutils is not mandatory, do we really want to >> > force building the support of debug info? >> >> Ideally, no. I guess we should use the same strategy as for the target package. > > Except we don't have Config.in options for host packages, and even if > we plan to add such options, we clearly don't want to add *visible* > options for every host package. > > So for the host-lttng-babeltrace, the only solution would be to have a > sub-option to enable debug info support. But that would make it handled > differently than the debug info dependency for the target > lttng-babeltrace. > > I don't really have a good answer here, I'm afraid. Debug info suppot is a nice-to-have when you trace instrumented user applications. It's not the end of the world, IMO, to build host-elfutils when you need host-lttng-babeltrace anyway... one of the reasons of having lttng-babeltrace as a host package in the first place is that some distributions provide an outdated Babeltrace package, and the recent Babeltrace 1.4 offers this debug info feature. Phil > > Thomas > -- > Thomas Petazzoni, CTO, Free Electrons > Embedded Linux and Kernel engineering > http://free-electrons.com
Hello, On Mon, 31 Oct 2016 13:48:57 +0100, Yann E. MORIN wrote: > Signed-off-by: "Yann E. MORIN" <yann.morin.1998@free.fr> > Cc: Philippe Proulx <eeppeliteloop@gmail.com> > --- > package/babeltrace/babeltrace.mk | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) Applied to master after rebasing on top of master, and fixing the typo. Thanks! Thomas
diff --git a/package/babeltrace/babeltrace.mk b/package/babeltrace/babeltrace.mk index d178a6c..17eaaaa 100644 --- a/package/babeltrace/babeltrace.mk +++ b/package/babeltrace/babeltrace.mk @@ -12,8 +12,8 @@ BABELTRACE_LICENSE_FILES = mit-license.txt gpl-2.0.txt LICENSE BABELTRACE_DEPENDENCIES = popt util-linux libglib2 host-pkgconf BABELTRACE_CONF_OPTS += --disable-debug-info HOST_BABELTRACE_DEPENDENCIES = \ - host-popt host-util-linux host-libglib2 host-pkgconf -HOST_BABELTRACE_CONF_OPTS += --disable-debug-info + host-popt host-util-linux host-libglib2 host-pkgconf host-elfutils +HOST_BABELTRACE_CONF_OPTS += --ensable-debug-info # For 0001-configure.ac-remove-elfutils-version-test-for-Buildr.patch BABELTRACE_AUTORECONF = YES
Signed-off-by: "Yann E. MORIN" <yann.morin.1998@free.fr> Cc: Philippe Proulx <eeppeliteloop@gmail.com> --- package/babeltrace/babeltrace.mk | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-)