| Message ID | 20161031074624.7576-8-eeppeliteloop@gmail.com |
|---|---|
| State | Changes Requested |
| Headers | show |
Philippe, All, On 2016-10-31 03:46 -0400, Philippe Proulx spake thusly: > Although Babeltrace is available for all major Linux distributions, some > of them have a quite old version of this project. > > Signed-off-by: Philippe Proulx <eeppeliteloop@gmail.com> Reviewed-by: "Yann E. MORIN" <yann.morin.1998@free.fr> However, small nit, see below... [--SNIP--] > diff --git a/package/lttng-babeltrace/Config.in.host b/package/lttng-babeltrace/Config.in.host > new file mode 100644 > index 0000000..5da482e > --- /dev/null > +++ b/package/lttng-babeltrace/Config.in.host > @@ -0,0 +1,18 @@ > +config BR2_PACKAGE_HOST_LTTNG_BABELTRACE > + bool "host lttng-babeltrace" > + help > + The Babeltrace project provides trace read and write > + libraries, as well as a trace converter application. Plugins > + can be created for any trace format to allow its conversion > + to/from another trace format. > + > + Babeltrace is the reference implementation of the Common > + Trace Format (see <http://diamon.org/ctf/>). Babeltrace > + can decode and display LTTng traces, since the latter are > + written using the CTF format. > + > + Having this tool on the target is not mandatory. You can > + transfer the binary trace output from the target to your > + development workstation, and use babeltrace here. You can probably get rid of this paragraph, as this is the host variant of the package. Regards, Yann E. MORIN. > + http://diamon.org/babeltrace > diff --git a/package/lttng-babeltrace/lttng-babeltrace.mk b/package/lttng-babeltrace/lttng-babeltrace.mk > index da18f88..30c5f6e 100644 > --- a/package/lttng-babeltrace/lttng-babeltrace.mk > +++ b/package/lttng-babeltrace/lttng-babeltrace.mk > @@ -13,6 +13,7 @@ LTTNG_BABELTRACE_DEPENDENCIES = popt util-linux libglib2 host-pkgconf > LTTNG_BABELTRACE_CONF_OPTS += --disable-debug-info > HOST_LTTNG_BABELTRACE_DEPENDENCIES = \ > host-popt host-util-linux host-libglib2 host-pkgconf > +HOST_LTTNG_BABELTRACE_CONF_OPTS += --disable-debug-info > > # For 0001-configure.ac-remove-elfutils-version-test-for-Buildr.patch > LTTNG_BABELTRACE_AUTORECONF = YES > -- > 2.9.3 > > _______________________________________________ > buildroot mailing list > buildroot@busybox.net > http://lists.busybox.net/mailman/listinfo/buildroot
On Mon, Oct 31, 2016 at 6:14 AM, Yann E. MORIN <yann.morin.1998@free.fr> wrote: > Philippe, All, > > On 2016-10-31 03:46 -0400, Philippe Proulx spake thusly: >> Although Babeltrace is available for all major Linux distributions, some >> of them have a quite old version of this project. >> >> Signed-off-by: Philippe Proulx <eeppeliteloop@gmail.com> > > Reviewed-by: "Yann E. MORIN" <yann.morin.1998@free.fr> > > However, small nit, see below... > > [--SNIP--] >> diff --git a/package/lttng-babeltrace/Config.in.host b/package/lttng-babeltrace/Config.in.host >> new file mode 100644 >> index 0000000..5da482e >> --- /dev/null >> +++ b/package/lttng-babeltrace/Config.in.host >> @@ -0,0 +1,18 @@ >> +config BR2_PACKAGE_HOST_LTTNG_BABELTRACE >> + bool "host lttng-babeltrace" >> + help >> + The Babeltrace project provides trace read and write >> + libraries, as well as a trace converter application. Plugins >> + can be created for any trace format to allow its conversion >> + to/from another trace format. >> + >> + Babeltrace is the reference implementation of the Common >> + Trace Format (see <http://diamon.org/ctf/>). Babeltrace >> + can decode and display LTTng traces, since the latter are >> + written using the CTF format. >> + >> + Having this tool on the target is not mandatory. You can >> + transfer the binary trace output from the target to your >> + development workstation, and use babeltrace here. > > You can probably get rid of this paragraph, as this is the host variant > of the package. If the committer wants to do it, I agree. Phil > > Regards, > Yann E. MORIN. > >> + http://diamon.org/babeltrace >> diff --git a/package/lttng-babeltrace/lttng-babeltrace.mk b/package/lttng-babeltrace/lttng-babeltrace.mk >> index da18f88..30c5f6e 100644 >> --- a/package/lttng-babeltrace/lttng-babeltrace.mk >> +++ b/package/lttng-babeltrace/lttng-babeltrace.mk >> @@ -13,6 +13,7 @@ LTTNG_BABELTRACE_DEPENDENCIES = popt util-linux libglib2 host-pkgconf >> LTTNG_BABELTRACE_CONF_OPTS += --disable-debug-info >> HOST_LTTNG_BABELTRACE_DEPENDENCIES = \ >> host-popt host-util-linux host-libglib2 host-pkgconf >> +HOST_LTTNG_BABELTRACE_CONF_OPTS += --disable-debug-info >> >> # For 0001-configure.ac-remove-elfutils-version-test-for-Buildr.patch >> LTTNG_BABELTRACE_AUTORECONF = YES >> -- >> 2.9.3 >> >> _______________________________________________ >> buildroot mailing list >> buildroot@busybox.net >> http://lists.busybox.net/mailman/listinfo/buildroot > > -- > .-----------------.--------------------.------------------.--------------------. > | Yann E. MORIN | Real-Time Embedded | /"\ ASCII RIBBON | Erics' conspiracy: | > | +33 662 376 056 | Software Designer | \ / CAMPAIGN | ___ | > | +33 223 225 172 `------------.-------: X AGAINST | \e/ There is no | > | http://ymorin.is-a-geek.org/ | _/*\_ | / \ HTML MAIL | v conspiracy. | > '------------------------------^-------^------------------^--------------------'
diff --git a/package/Config.in.host b/package/Config.in.host index e33cbb5..3b115c5 100644 --- a/package/Config.in.host +++ b/package/Config.in.host @@ -22,6 +22,7 @@ menu "Host utilities" source "package/jq/Config.in.host" source "package/jsmin/Config.in.host" source "package/lpc3250loader/Config.in.host" + source "package/lttng-babeltrace/Config.in.host" source "package/mfgtools/Config.in.host" source "package/mke2img/Config.in.host" source "package/mkpasswd/Config.in.host" diff --git a/package/lttng-babeltrace/Config.in b/package/lttng-babeltrace/Config.in index 2e8d778..95b635d 100644 --- a/package/lttng-babeltrace/Config.in +++ b/package/lttng-babeltrace/Config.in @@ -20,8 +20,10 @@ config BR2_PACKAGE_LTTNG_BABELTRACE Having this tool on the target is not mandatory. You can transfer the binary trace output from the target to your - development workstation, and use babeltrace here. Babeltrace - is packaged for all major Linux distributions. + development workstation, and use babeltrace here. + + See the lttng-babeltrace host utility to install Babeltrace + on the host. http://diamon.org/babeltrace diff --git a/package/lttng-babeltrace/Config.in.host b/package/lttng-babeltrace/Config.in.host new file mode 100644 index 0000000..5da482e --- /dev/null +++ b/package/lttng-babeltrace/Config.in.host @@ -0,0 +1,18 @@ +config BR2_PACKAGE_HOST_LTTNG_BABELTRACE + bool "host lttng-babeltrace" + help + The Babeltrace project provides trace read and write + libraries, as well as a trace converter application. Plugins + can be created for any trace format to allow its conversion + to/from another trace format. + + Babeltrace is the reference implementation of the Common + Trace Format (see <http://diamon.org/ctf/>). Babeltrace + can decode and display LTTng traces, since the latter are + written using the CTF format. + + Having this tool on the target is not mandatory. You can + transfer the binary trace output from the target to your + development workstation, and use babeltrace here. + + http://diamon.org/babeltrace diff --git a/package/lttng-babeltrace/lttng-babeltrace.mk b/package/lttng-babeltrace/lttng-babeltrace.mk index da18f88..30c5f6e 100644 --- a/package/lttng-babeltrace/lttng-babeltrace.mk +++ b/package/lttng-babeltrace/lttng-babeltrace.mk @@ -13,6 +13,7 @@ LTTNG_BABELTRACE_DEPENDENCIES = popt util-linux libglib2 host-pkgconf LTTNG_BABELTRACE_CONF_OPTS += --disable-debug-info HOST_LTTNG_BABELTRACE_DEPENDENCIES = \ host-popt host-util-linux host-libglib2 host-pkgconf +HOST_LTTNG_BABELTRACE_CONF_OPTS += --disable-debug-info # For 0001-configure.ac-remove-elfutils-version-test-for-Buildr.patch LTTNG_BABELTRACE_AUTORECONF = YES
Although Babeltrace is available for all major Linux distributions, some of them have a quite old version of this project. Signed-off-by: Philippe Proulx <eeppeliteloop@gmail.com> --- This is a new patch in v3. package/Config.in.host | 1 + package/lttng-babeltrace/Config.in | 6 ++++-- package/lttng-babeltrace/Config.in.host | 18 ++++++++++++++++++ package/lttng-babeltrace/lttng-babeltrace.mk | 1 + 4 files changed, 24 insertions(+), 2 deletions(-) create mode 100644 package/lttng-babeltrace/Config.in.host -- 2.9.3