| Message ID | 20161030230247.20538-3-paul@crapouillou.net |
|---|---|
| State | Superseded |
| Headers | show |
On Mon, Oct 31, 2016 at 12:02:42AM +0100, Paul Cercueil wrote: > This commit adds documentation for the device-tree bindings of the > jz4740-rtc driver, which supports the RTC unit present in the JZ4740 and > JZ4780 SoCs from Ingenic. > > Signed-off-by: Paul Cercueil <paul@crapouillou.net> > Acked-by: Maarten ter Huurne <maarten@treewalker.org> > --- > .../devicetree/bindings/rtc/ingenic,jz4740-rtc.txt | 37 ++++++++++++++++++++++ > 1 file changed, 37 insertions(+) > create mode 100644 Documentation/devicetree/bindings/rtc/ingenic,jz4740-rtc.txt > > v2: > - Remove 'interrupt-parent' of the list of required properties > - Add the -msec suffix for the DT entries that represent time Sorry, I told you the wrong suffix. It should be '-ms' as documented in .../bindings/property-units.txt. I never can remember which is why I wrote the doc to begin with. With that fix, Acked-by: Rob Herring <robh@kernel.org>
Hello. On 10/31/2016 2:02 AM, Paul Cercueil wrote: > This commit adds documentation for the device-tree bindings of the > jz4740-rtc driver, which supports the RTC unit present in the JZ4740 and > JZ4780 SoCs from Ingenic. > > Signed-off-by: Paul Cercueil <paul@crapouillou.net> > Acked-by: Maarten ter Huurne <maarten@treewalker.org> > --- > .../devicetree/bindings/rtc/ingenic,jz4740-rtc.txt | 37 ++++++++++++++++++++++ > 1 file changed, 37 insertions(+) > create mode 100644 Documentation/devicetree/bindings/rtc/ingenic,jz4740-rtc.txt > > v2: > - Remove 'interrupt-parent' of the list of required properties > - Add the -msec suffix for the DT entries that represent time > > diff --git a/Documentation/devicetree/bindings/rtc/ingenic,jz4740-rtc.txt b/Documentation/devicetree/bindings/rtc/ingenic,jz4740-rtc.txt > new file mode 100644 > index 0000000..df97594 > --- /dev/null > +++ b/Documentation/devicetree/bindings/rtc/ingenic,jz4740-rtc.txt > @@ -0,0 +1,37 @@ [...] > +Example: > + > +rtc@10003000 { > + compatible = "ingenic,jz4740-rtc"; > + reg = <0x10003000 0x3F>; Are you sure it's not 0x40? It's a size, not a limit... [...] MBR, Sergei
diff --git a/Documentation/devicetree/bindings/rtc/ingenic,jz4740-rtc.txt b/Documentation/devicetree/bindings/rtc/ingenic,jz4740-rtc.txt new file mode 100644 index 0000000..df97594 --- /dev/null +++ b/Documentation/devicetree/bindings/rtc/ingenic,jz4740-rtc.txt @@ -0,0 +1,37 @@ +JZ4740 and similar SoCs real-time clock driver + +Required properties: + +- compatible: One of: + - "ingenic,jz4740-rtc" - for use with the JZ4740 SoC + - "ingenic,jz4780-rtc" - for use with the JZ4780 SoC +- reg: Address range of rtc register set +- interrupts: IRQ number for the alarm interrupt +- clocks: phandle to the "rtc" clock +- clock-names: must be "rtc" + +Optional properties: +- system-power-controller: To use this component as the + system power controller +- reset-pin-assert-time-msec: Reset pin low-level assertion + time after wakeup (default 60ms; range 0-125ms if RTC clock + at 32 kHz) +- min-wakeup-pin-assert-time-msec: Minimum wakeup pin assertion + time (default 100ms; range 0-2s if RTC clock at 32 kHz) + +Example: + +rtc@10003000 { + compatible = "ingenic,jz4740-rtc"; + reg = <0x10003000 0x3F>; + + interrupt-parent = <&intc>; + interrupts = <32>; + + clocks = <&rtc_clock>; + clock-names = "rtc"; + + system-power-controller; + reset-pin-assert-time-msec = <60>; + min-wakeup-pin-assert-time-msec = <100>; +};