diff mbox

binutils: add comment with bug report reference

Message ID 20161030132511.GA23794@waldemar-brodkorb.de
State Accepted
Headers show

Commit Message

Waldemar Brodkorb Oct. 30, 2016, 1:25 p.m. UTC
Add requested bug report

Signed-off-by: Waldemar Brodkorb <wbx@openadk.org>
---
 package/binutils/Config.in.host | 1 +
 1 file changed, 1 insertion(+)

Comments

Thomas Petazzoni Oct. 30, 2016, 3:43 p.m. UTC | #1
Hello,

On Sun, 30 Oct 2016 14:25:11 +0100, Waldemar Brodkorb wrote:
> Add requested bug report
> 
> Signed-off-by: Waldemar Brodkorb <wbx@openadk.org>
> ---
>  package/binutils/Config.in.host | 1 +
>  1 file changed, 1 insertion(+)
> 
> diff --git a/package/binutils/Config.in.host b/package/binutils/Config.in.host
> index a7610b4..dce6996 100644
> --- a/package/binutils/Config.in.host
> +++ b/package/binutils/Config.in.host
> @@ -18,6 +18,7 @@ choice
>  	config BR2_BINUTILS_VERSION_2_27_X
>  		bool "binutils 2.27"
>  		# supported but broken on Microblaze
> +		# see https://sourceware.org/bugzilla/show_bug.cgi?id=20748
>  		depends on !BR2_microblaze

Your bug report is about binutils 2.27 generating broken binaries for
microblaze/musl, but you disable binutils 2.27 completely for
microblaze, and not just for musl. Why so?

Thanks,

Thomas
Waldemar Brodkorb Oct. 30, 2016, 4:18 p.m. UTC | #2
Hi Thomas,
Thomas Petazzoni wrote,

> Hello,
> 
> On Sun, 30 Oct 2016 14:25:11 +0100, Waldemar Brodkorb wrote:
> > Add requested bug report
> > 
> > Signed-off-by: Waldemar Brodkorb <wbx@openadk.org>
> > ---
> >  package/binutils/Config.in.host | 1 +
> >  1 file changed, 1 insertion(+)
> > 
> > diff --git a/package/binutils/Config.in.host b/package/binutils/Config.in.host
> > index a7610b4..dce6996 100644
> > --- a/package/binutils/Config.in.host
> > +++ b/package/binutils/Config.in.host
> > @@ -18,6 +18,7 @@ choice
> >  	config BR2_BINUTILS_VERSION_2_27_X
> >  		bool "binutils 2.27"
> >  		# supported but broken on Microblaze
> > +		# see https://sourceware.org/bugzilla/show_bug.cgi?id=20748
> >  		depends on !BR2_microblaze
> 
> Your bug report is about binutils 2.27 generating broken binaries for
> microblaze/musl, but you disable binutils 2.27 completely for
> microblaze, and not just for musl. Why so?

Because the binutils bug affects musl/uClibc-ng and glibc.
I just used musl to bisect and simplified the bug report.
Furthermore I normally get very good support from the musl devs
in case of toolchain issues.

best regards
 Waldemar
Thomas Petazzoni Oct. 30, 2016, 5:10 p.m. UTC | #3
Hello,

On Sun, 30 Oct 2016 17:18:09 +0100, Waldemar Brodkorb wrote:

> > >  	config BR2_BINUTILS_VERSION_2_27_X
> > >  		bool "binutils 2.27"
> > >  		# supported but broken on Microblaze
> > > +		# see https://sourceware.org/bugzilla/show_bug.cgi?id=20748
> > >  		depends on !BR2_microblaze  
> > 
> > Your bug report is about binutils 2.27 generating broken binaries for
> > microblaze/musl, but you disable binutils 2.27 completely for
> > microblaze, and not just for musl. Why so?  
> 
> Because the binutils bug affects musl/uClibc-ng and glibc.
> I just used musl to bisect and simplified the bug report.
> Furthermore I normally get very good support from the musl devs
> in case of toolchain issues.

ACK, thanks for the explanation. But then perhaps your bug report
should be made more accurate? As it is written, one might understand
than it is a musl-specific problem. Knowing that uclibc-ng and glibc
are also affected is quite important IMO.

Thanks,

Thomas
Thomas Petazzoni Nov. 1, 2016, 3:18 p.m. UTC | #4
Hello,

On Sun, 30 Oct 2016 14:25:11 +0100, Waldemar Brodkorb wrote:
> Add requested bug report
> 
> Signed-off-by: Waldemar Brodkorb <wbx@openadk.org>
> ---
>  package/binutils/Config.in.host | 1 +
>  1 file changed, 1 insertion(+)

Applied to master, thanks.

Thomas
diff mbox

Patch

diff --git a/package/binutils/Config.in.host b/package/binutils/Config.in.host
index a7610b4..dce6996 100644
--- a/package/binutils/Config.in.host
+++ b/package/binutils/Config.in.host
@@ -18,6 +18,7 @@  choice
 	config BR2_BINUTILS_VERSION_2_27_X
 		bool "binutils 2.27"
 		# supported but broken on Microblaze
+		# see https://sourceware.org/bugzilla/show_bug.cgi?id=20748
 		depends on !BR2_microblaze
 
 endchoice