From patchwork Fri Oct 22 11:52:20 2010 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Sebastien Jan X-Patchwork-Id: 68840 X-Patchwork-Delegate: tim.gardner@canonical.com Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@bilbo.ozlabs.org Received: from chlorine.canonical.com (chlorine.canonical.com [91.189.94.204]) by ozlabs.org (Postfix) with ESMTP id E596CB70A8 for ; Fri, 22 Oct 2010 22:52:37 +1100 (EST) Received: from localhost ([127.0.0.1] helo=chlorine.canonical.com) by chlorine.canonical.com with esmtp (Exim 4.69) (envelope-from ) id 1P9GAc-00060c-4k; Fri, 22 Oct 2010 12:52:26 +0100 Received: from comal.ext.ti.com ([198.47.26.152]) by chlorine.canonical.com with esmtp (Exim 4.69) (envelope-from ) id 1P9GAZ-0005zp-Sa for kernel-team@lists.ubuntu.com; Fri, 22 Oct 2010 12:52:24 +0100 Received: from dlep33.itg.ti.com ([157.170.170.112]) by comal.ext.ti.com (8.13.7/8.13.7) with ESMTP id o9MBqLb6011122 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=NO); Fri, 22 Oct 2010 06:52:22 -0500 Received: from dlep26.itg.ti.com (localhost [127.0.0.1]) by dlep33.itg.ti.com (8.13.7/8.13.7) with ESMTP id o9MBqLuX026169; Fri, 22 Oct 2010 06:52:21 -0500 (CDT) Received: from dlee74.ent.ti.com (localhost [127.0.0.1]) by dlep26.itg.ti.com (8.13.8/8.13.8) with ESMTP id o9MBqLKR011245; Fri, 22 Oct 2010 06:52:21 -0500 (CDT) Received: from dlelxv22.itg.ti.com (172.17.1.197) by dlee74.ent.ti.com (157.170.170.8) with Microsoft SMTP Server id 8.1.358.0; Fri, 22 Oct 2010 06:52:21 -0500 Received: from [137.167.101.18] (una0918836-137167101018.emea.dhcp.ti.com [137.167.101.18]) by dlelxv22.itg.ti.com (8.13.8/8.13.8) with ESMTP id o9MBqKNW023844; Fri, 22 Oct 2010 06:52:20 -0500 Message-ID: <4CC17AF4.8080503@ti.com> Date: Fri, 22 Oct 2010 13:52:20 +0200 From: Sebastien Jan User-Agent: Mozilla/5.0 (X11; U; Linux i686; en-US; rv:1.9.1.14) Gecko/20101006 Thunderbird/3.0.9 MIME-Version: 1.0 To: Subject: [Maverick][ti-omap4] SRU: Fix blaze board crash with tiwlan package installed X-BeenThere: kernel-team@lists.ubuntu.com X-Mailman-Version: 2.1.9 Precedence: list List-Id: Kernel team discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: kernel-team-bounces@lists.ubuntu.com Errors-To: kernel-team-bounces@lists.ubuntu.com SRU justification: Impact: When booting official Maverick pre-installed images on OMAP4 blaze board, with standard wlan packages installed (tiwlan-wl1271*), the blaze board crashes on wlan driver init. Fix: The problem is fixed by registering the wlan device exclusively on pandaboard (the wlan device on blaze board is not compatible). Testcase: install the standard TI packages on the Maverick OMAP4 pre-installed image running on a blaze board. On next boot, the platform crashes while loading the wlan driver. BugLink: https://bugs.launchpad.net/ubuntu/+source/linux-ti-omap4/+bug/665039 This issue is fixed by the below (and also attached) patch. From f8c552bce2a258a080536c86fff61e5c50e0e843 Mon Sep 17 00:00:00 2001 From: Sebastien Jan Date: Mon, 18 Oct 2010 18:00:55 +0200 Subject: [PATCH] wlan: register wlan device only on pandaboard Registering the wlan device on blaze triggers the loading of user-space wlan drivers for 1271 chip. These user-space drivers are not compatible with the 1283 chip of the blaze and cause a kernel crash. The event is the same whatever the wlan controller, which prevents managing different wlan drivers in user-space. This patch registers the wlan device only on pandaboard. Long term, we would like to generate different events depending on the wlan controller. Signed-off-by: Sebastien Jan --- arch/arm/mach-omap2/board-4430sdp-wifi.c | 3 ++- 1 files changed, 2 insertions(+), 1 deletions(-) -- 1.7.0.4 From f8c552bce2a258a080536c86fff61e5c50e0e843 Mon Sep 17 00:00:00 2001 From: Sebastien Jan Date: Mon, 18 Oct 2010 18:00:55 +0200 Subject: [PATCH] wlan: register wlan device only on pandaboard Registering the wlan device on blaze triggers the loading of user-space wlan drivers for 1271 chip. These user-space drivers are not compatible with the 1283 chip of the blaze and cause a kernel crash. The event is the same whatever the wlan controller, which prevents managing different wlan drivers in user-space. This patch registers the wlan device only on pandaboard. Long term, we would like to generate different events depending on the wlan controller. Signed-off-by: Sebastien Jan --- arch/arm/mach-omap2/board-4430sdp-wifi.c | 3 ++- 1 files changed, 2 insertions(+), 1 deletions(-) diff --git a/arch/arm/mach-omap2/board-4430sdp-wifi.c b/arch/arm/mach-omap2/board-4430sdp-wifi.c index aa731ef..eea7cad 100644 --- a/arch/arm/mach-omap2/board-4430sdp-wifi.c +++ b/arch/arm/mach-omap2/board-4430sdp-wifi.c @@ -129,7 +129,8 @@ static int __init sdp4430_wifi_init(void) } gpio_direction_input(SDP4430_WIFI_IRQ_GPIO); #ifdef CONFIG_WIFI_CONTROL_FUNC - ret = platform_device_register(&sdp4430_wifi_device); + if (machine_is_omap4_panda()) + ret = platform_device_register(&sdp4430_wifi_device); #endif out: return ret; -- 1.7.0.4