diff mbox

[U-Boot,v2,1/2] mkimage: Fix missing free() in show_valid_options()

Message ID 1477612444-3232-1-git-send-email-sjg@chromium.org
State Accepted
Delegated to: Tom Rini
Headers show

Commit Message

Simon Glass Oct. 27, 2016, 11:54 p.m. UTC 
The allocated memory should be freed. Fix it.

Signed-off-by: Simon Glass <sjg@chromium.org>
Reported-by: Coverity (CID: 150963)
Reviewed-by: Tom Rini <trini@konsulko.com>
---

Changes in v2: None

 tools/mkimage.c | 1 +
 1 file changed, 1 insertion(+)

Comments

Tom Rini Nov. 2, 2016, 2:26 p.m. UTC | #1 
On Thu, Oct 27, 2016 at 05:54:03PM -0600, Simon Glass wrote:

> The allocated memory should be freed. Fix it.
> 
> Signed-off-by: Simon Glass <sjg@chromium.org>
> Reported-by: Coverity (CID: 150963)
> Reviewed-by: Tom Rini <trini@konsulko.com>

Applied to u-boot/master (before v2016.11-rc3), thanks!
diff mbox

Patch

diff --git a/tools/mkimage.c b/tools/mkimage.c
index 3c594a0..521fa80 100644
--- a/tools/mkimage.c
+++ b/tools/mkimage.c
@@ -64,6 +64,7 @@  static int show_valid_options(enum ih_category category)
 			genimg_get_cat_name(category, item));
 	}
 	fprintf(stderr, "\n");
+	free(order);
 
 	return 0;
 }