Patchwork powerpc: remove unused variable from pci_dlpar.c

login
register
mail settings
Submitter Stephen Rothwell
Date Nov. 3, 2008, 7:07 a.m.
Message ID <20081103180712.0494af2b.sfr@canb.auug.org.au>
Download mbox | patch
Permalink /patch/6874/
State Accepted, archived
Commit 454666eb78d890f5740ea1901f8b01a43c77c67c
Headers show

Comments

Stephen Rothwell - Nov. 3, 2008, 7:07 a.m.
And get rid of this build warning:

arch/powerpc/platforms/pseries/pci_dlpar.c: In function 'init_phb_dynamic':
arch/powerpc/platforms/pseries/pci_dlpar.c:192: warning: unused variable 'b'

This is one of the very few warnings left in a ppc64_defconfig build and
getting rid of it will make it easier to see future introduced ones (in
fact this was introduced very recently).

Signed-off-by: Stephen Rothwell <sfr@canb.auug.org.au>
---
 arch/powerpc/platforms/pseries/pci_dlpar.c |    1 -
 1 files changed, 0 insertions(+), 1 deletions(-)

This patch is against Linus' tree and so could go into 2.6.28 if you
think it should.  This is also fixed by one of Ben's ominbus patches
(http://patchwork.ozlabs.org/patch/6041/) but this is more suitable for
upstream merge.
Benjamin Herrenschmidt - Nov. 3, 2008, 7:26 a.m.
On Mon, 2008-11-03 at 18:07 +1100, Stephen Rothwell wrote:
> And get rid of this build warning:
> 
> arch/powerpc/platforms/pseries/pci_dlpar.c: In function 'init_phb_dynamic':
> arch/powerpc/platforms/pseries/pci_dlpar.c:192: warning: unused variable 'b'
> 
> This is one of the very few warnings left in a ppc64_defconfig build and
> getting rid of it will make it easier to see future introduced ones (in
> fact this was introduced very recently).
> 
> Signed-off-by: Stephen Rothwell <sfr@canb.auug.org.au>
> ---

Ack.

>  arch/powerpc/platforms/pseries/pci_dlpar.c |    1 -
>  1 files changed, 0 insertions(+), 1 deletions(-)
> 
> This patch is against Linus' tree and so could go into 2.6.28 if you
> think it should.  This is also fixed by one of Ben's ominbus patches
> (http://patchwork.ozlabs.org/patch/6041/) but this is more suitable for
> upstream merge.
> 
> diff --git a/arch/powerpc/platforms/pseries/pci_dlpar.c b/arch/powerpc/platforms/pseries/pci_dlpar.c
> index 31481dc..7190493 100644
> --- a/arch/powerpc/platforms/pseries/pci_dlpar.c
> +++ b/arch/powerpc/platforms/pseries/pci_dlpar.c
> @@ -189,7 +189,6 @@ struct pci_controller * __devinit init_phb_dynamic(struct device_node *dn)
>  {
>  	struct pci_controller *phb;
>  	int primary;
> -	struct pci_bus *b;
>  
>  	primary = list_empty(&hose_list);
>  	phb = pcibios_alloc_controller(dn);
> -- 
> 1.5.6.5
>

Patch

diff --git a/arch/powerpc/platforms/pseries/pci_dlpar.c b/arch/powerpc/platforms/pseries/pci_dlpar.c
index 31481dc..7190493 100644
--- a/arch/powerpc/platforms/pseries/pci_dlpar.c
+++ b/arch/powerpc/platforms/pseries/pci_dlpar.c
@@ -189,7 +189,6 @@  struct pci_controller * __devinit init_phb_dynamic(struct device_node *dn)
 {
 	struct pci_controller *phb;
 	int primary;
-	struct pci_bus *b;
 
 	primary = list_empty(&hose_list);
 	phb = pcibios_alloc_controller(dn);