| Message ID | eb4502ac9eb455678eac325824312c5a377e658e.1477501000.git.stwiss.opensource@diasemi.com |
|---|---|
| State | Changes Requested, archived |
| Headers | show |
On Wed, Oct 26, 2016 at 05:56:37PM +0100, Steve Twiss wrote: > From: Steve Twiss <stwiss.opensource@diasemi.com> > > Add binding information for DA9062 and DA9061 watchdog. > > Example bindings for both devices are added. > > The original binding for DA9062 (only) used to reside inside the > Documentation/devicetree/bindings/mfd/da9062.txt MFD document. > The da9062-watchdog section was deleted in that file and replaced > with a link to the new DA9061/62 binding information stored in this > patch. > > Signed-off-by: Steve Twiss <stwiss.opensource@diasemi.com> > > --- > This patch applies against linux-next and v4.8 > > v1 -> v2 > - Patch renamed from [PATCH V1 07/10] to [PATCH V2 02/10] -- these > changes were made to fix checkpatch warnings caused by the patch > set dependency order > - Updated the patch description to be explicit about where parts of > this binding had originally been stored > - A second example for DA9061 is provided to highlight the use of a > fall-back compatible option for the DA9062 watchdog driver > > Hi, > > This patch depends on the acceptance of DA9061 watchdog driver: > [PATCH V2 08/10] watchdog: da9061: watchdog driver > > This previous [PATCH V1 07/10] was acked-by: Rob Herring, however changes > in the Linux device driver have meant an additional binding example is > necessary to describe the use of DA9061. > > The Linux device driver changes for DA9061 were rejected after > conversations with the watchdog maintainers, specifically about > compatibility between DA9061 and DA9062 watchdog hardware components. In > the case of the watchdog the DA9062 device driver is compatible with the > DA9061 and for this reason there is minimal change required to the DA9062 > watchdog device driver and so the example for the DA9061 watchdog shows > the use of a fall-back compatible string. > > Regards, > Steve Twiss, Dialog Semiconductor Ltd. > > > .../devicetree/bindings/watchdog/da9062-wdt.txt | 21 +++++++++++++++++++++ > 1 file changed, 21 insertions(+) > create mode 100644 Documentation/devicetree/bindings/watchdog/da9062-wdt.txt > > diff --git a/Documentation/devicetree/bindings/watchdog/da9062-wdt.txt b/Documentation/devicetree/bindings/watchdog/da9062-wdt.txt > new file mode 100644 > index 0000000..1f8255c > --- /dev/null > +++ b/Documentation/devicetree/bindings/watchdog/da9062-wdt.txt > @@ -0,0 +1,21 @@ > +* Dialog Semiconductor DA9062/61 Watchdog Timer > + > +Required properties: > +- compatible: "dlg,da9062-watchdog" > + "dlg,da9061-watchdog" Similar comment here. List each valid combination. > + > +Example: DA9062 > + > + pmic0: da9062@58 { > + watchdog { > + compatible = "dlg,da9062-watchdog"; > + }; > + }; > + > +Example: DA9061 using a fall-back compatible for the DA9062 watchdog driver > + > + pmic0: da9061@58 { > + watchdog { > + compatible = "dlg,da9061-watchdog", "dlg,da9062-watchdog"; > + }; > + }; > -- > end-of-patch for PATCH V2 > -- To unsubscribe from this list: send the line "unsubscribe devicetree" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
diff --git a/Documentation/devicetree/bindings/watchdog/da9062-wdt.txt b/Documentation/devicetree/bindings/watchdog/da9062-wdt.txt new file mode 100644 index 0000000..1f8255c --- /dev/null +++ b/Documentation/devicetree/bindings/watchdog/da9062-wdt.txt @@ -0,0 +1,21 @@ +* Dialog Semiconductor DA9062/61 Watchdog Timer + +Required properties: +- compatible: "dlg,da9062-watchdog" + "dlg,da9061-watchdog" + +Example: DA9062 + + pmic0: da9062@58 { + watchdog { + compatible = "dlg,da9062-watchdog"; + }; + }; + +Example: DA9061 using a fall-back compatible for the DA9062 watchdog driver + + pmic0: da9061@58 { + watchdog { + compatible = "dlg,da9061-watchdog", "dlg,da9062-watchdog"; + }; + };