diff mbox

[U-Boot,5/6] travis-ci: don't invoke exit on success

Message ID 20161026170536.2367-5-swarren@wwwdotorg.org
State Accepted
Commit bf1c0889379f1e71a25d9b94fa5ce7cec8c36d19
Delegated to: Tom Rini
Headers show

Commit Message

Stephen Warren Oct. 26, 2016, 5:05 p.m. UTC 
From: Stephen Warren <swarren@nvidia.com>

Invoking exit prevents any subsequent build commands from running, and
future patches will add extra commands.

Signed-off-by: Stephen Warren <swarren@nvidia.com>
---
 .travis.yml | 4 +---
 1 file changed, 1 insertion(+), 3 deletions(-)

Comments

Heiko Schocher Oct. 27, 2016, 6:12 a.m. UTC | #1 
Hello Stephen,

Am 26.10.2016 um 19:05 schrieb Stephen Warren:
> From: Stephen Warren <swarren@nvidia.com>
>
> Invoking exit prevents any subsequent build commands from running, and
> future patches will add extra commands.
>
> Signed-off-by: Stephen Warren <swarren@nvidia.com>
> ---
>   .travis.yml | 4 +---
>   1 file changed, 1 insertion(+), 3 deletions(-)

Thanks!

Reviewed-by: Heiko Schocher <hs@denx.de>

bye,
Heiko

>
> diff --git a/.travis.yml b/.travis.yml
> index 6e72e0bb233f..a537f0e34dd3 100644
> --- a/.travis.yml
> +++ b/.travis.yml
> @@ -74,9 +74,7 @@ script:
>        set +e;
>        tools/buildman/buildman -P ${BUILDMAN};
>        ret=$?;
> -     if [[ $ret -eq 0 || $ret -eq 129 ]]; then
> -       exit 0;
> -     else
> +     if [[ $ret -ne 0 && $ret -ne 129 ]]; then
>          exit $ret;
>        fi;
>      fi
>
Tom Rini Oct. 29, 2016, 5:41 p.m. UTC | #2 
On Wed, Oct 26, 2016 at 11:05:35AM -0600, Stephen Warren wrote:

> From: Stephen Warren <swarren@nvidia.com>
> 
> Invoking exit prevents any subsequent build commands from running, and
> future patches will add extra commands.
> 
> Signed-off-by: Stephen Warren <swarren@nvidia.com>
> Reviewed-by: Heiko Schocher <hs@denx.de>

Applied to u-boot/master, thanks!
diff mbox

Patch

diff --git a/.travis.yml b/.travis.yml
index 6e72e0bb233f..a537f0e34dd3 100644
--- a/.travis.yml
+++ b/.travis.yml
@@ -74,9 +74,7 @@  script:
      set +e;
      tools/buildman/buildman -P ${BUILDMAN};
      ret=$?;
-     if [[ $ret -eq 0 || $ret -eq 129 ]]; then
-       exit 0;
-     else
+     if [[ $ret -ne 0 && $ret -ne 129 ]]; then
        exit $ret;
      fi;
    fi