diff mbox

PING! Re: [PATCH, Fortran] Extension: COTAN and degree-valued trig intrinsics with -fdec-math

Message ID 57f18bee-dbd3-50d4-a377-8578b0a9e12a@codesourcery.com
State New
Headers show

Commit Message

Cesar Philippidis Oct. 25, 2016, 3:37 p.m. UTC
On 10/10/2016 08:06 AM, Fritz Reese wrote:

> --- a/gcc/fortran/intrinsic.texi
> +++ b/gcc/fortran/intrinsic.texi
> @@ -23,6 +23,9 @@ Some basic guidelines for editing this document:
>  @end ignore
>  
>  @tex
> +\gdef\acosd{\mathop{\rm acosd}\nolimits}
> +\gdef\asind{\mathop{\rm asind}\nolimits}
> +\gdef\atand{\mathop{\rm atand}\nolimits}
>  \gdef\acos{\mathop{\rm acos}\nolimits}
>  \gdef\asin{\mathop{\rm asin}\nolimits}
>  \gdef\atan{\mathop{\rm atan}\nolimits}

There should be a new mathop for cosd or else ...

> +@item @emph{Return value}:
> +The return value is of the same type and kind as @var{X}. The real part
> +of the result is in degrees.  If @var{X} is of the type @code{REAL},
> +the return value lies in the range @math{ -1 \leq \cosd (x) \leq 1}.

... this will cause texinfo/pdflatex to complain about an undefined
function when you try to run 'make pdf'. The attached adds a mathop for
cosd.

Is this patch OK for trunk?

Cesar

Comments

Fritz Reese Oct. 25, 2016, 3:43 p.m. UTC | #1
On Tue, Oct 25, 2016 at 11:37 AM Cesar Philippidis
<cesar@codesourcery.com> wrote:
>
> On 10/10/2016 08:06 AM, Fritz Reese wrote:
>
> > --- a/gcc/fortran/intrinsic.texi
> > +++ b/gcc/fortran/intrinsic.texi
> > @@ -23,6 +23,9 @@ Some basic guidelines for editing this document:
> >  @end ignore
> >
> >  @tex
> > +\gdef\acosd{\mathop{\rm acosd}\nolimits}
> > +\gdef\asind{\mathop{\rm asind}\nolimits}
> > +\gdef\atand{\mathop{\rm atand}\nolimits}
> >  \gdef\acos{\mathop{\rm acos}\nolimits}
> >  \gdef\asin{\mathop{\rm asin}\nolimits}
> >  \gdef\atan{\mathop{\rm atan}\nolimits}
>
> There should be a new mathop for cosd or else ...
>
> > +@item @emph{Return value}:
> > +The return value is of the same type and kind as @var{X}. The real part
> > +of the result is in degrees.  If @var{X} is of the type @code{REAL},
> > +the return value lies in the range @math{ -1 \leq \cosd (x) \leq 1}.
>
> ... this will cause texinfo/pdflatex to complain about an undefined
> function when you try to run 'make pdf'. The attached adds a mathop for
> cosd.
>
> Is this patch OK for trunk?
>
> Cesar


Yes, I think that counts as 'obvious'. Thanks!

---
Fritz Reese
diff mbox

Patch

2016-10-25  Cesar Philippidis  <cesar@codesourcery.com>

	gcc/fortran/
	* intrinsic.texi (cosd): New mathop. 

diff --git a/gcc/fortran/intrinsic.texi b/gcc/fortran/intrinsic.texi
index 16e1d5c..85f781e 100644
--- a/gcc/fortran/intrinsic.texi
+++ b/gcc/fortran/intrinsic.texi
@@ -32,6 +32,7 @@  Some basic guidelines for editing this document:
 \gdef\acosh{\mathop{\rm acosh}\nolimits}
 \gdef\asinh{\mathop{\rm asinh}\nolimits}
 \gdef\atanh{\mathop{\rm atanh}\nolimits}
+\gdef\cosd{\mathop{\rm cosd}\nolimits}
 @end tex