| Message ID | 1477361005-18646-1-git-send-email-linux@roeck-us.net |
|---|---|
| State | New |
| Headers | show |
Le 25/10/2016 à 04:03, Guenter Roeck a écrit : > Writing the ISR register is supposed to clear interrupt status bits, > not to set them. > > This patch makes '-M sabrelite' work without devicetree changes (Linux > kernel versions 3.18 to 4.7 with imx_v6_v7_defconfig and up to v4.8 with > multi_v7_defconfig; mainline has different problems). > > Signed-off-by: Guenter Roeck <linux@roeck-us.net> > --- > hw/gpio/imx_gpio.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/hw/gpio/imx_gpio.c b/hw/gpio/imx_gpio.c > index f3574aa..c36c394 100644 > --- a/hw/gpio/imx_gpio.c > +++ b/hw/gpio/imx_gpio.c > @@ -237,7 +237,7 @@ static void imx_gpio_write(void *opaque, hwaddr offset, uint64_t value, > break; > > case ISR_ADDR: > - s->isr |= ~value; > + s->isr &= ~value; > imx_gpio_set_all_int_lines(s); > break; > acked-by: Jean-Christophe Dubois <jcd@tribudubois.net> Thanks. JC
On 25 October 2016 at 03:03, Guenter Roeck <linux@roeck-us.net> wrote: > Writing the ISR register is supposed to clear interrupt status bits, > not to set them. > > This patch makes '-M sabrelite' work without devicetree changes (Linux > kernel versions 3.18 to 4.7 with imx_v6_v7_defconfig and up to v4.8 with > multi_v7_defconfig; mainline has different problems). > > Signed-off-by: Guenter Roeck <linux@roeck-us.net> > --- > hw/gpio/imx_gpio.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/hw/gpio/imx_gpio.c b/hw/gpio/imx_gpio.c > index f3574aa..c36c394 100644 > --- a/hw/gpio/imx_gpio.c > +++ b/hw/gpio/imx_gpio.c > @@ -237,7 +237,7 @@ static void imx_gpio_write(void *opaque, hwaddr offset, uint64_t value, > break; > > case ISR_ADDR: > - s->isr |= ~value; > + s->isr &= ~value; > imx_gpio_set_all_int_lines(s); > break; Applied to target-arm.next, thanks. -- PMM
diff --git a/hw/gpio/imx_gpio.c b/hw/gpio/imx_gpio.c index f3574aa..c36c394 100644 --- a/hw/gpio/imx_gpio.c +++ b/hw/gpio/imx_gpio.c @@ -237,7 +237,7 @@ static void imx_gpio_write(void *opaque, hwaddr offset, uint64_t value, break; case ISR_ADDR: - s->isr |= ~value; + s->isr &= ~value; imx_gpio_set_all_int_lines(s); break;
Writing the ISR register is supposed to clear interrupt status bits, not to set them. This patch makes '-M sabrelite' work without devicetree changes (Linux kernel versions 3.18 to 4.7 with imx_v6_v7_defconfig and up to v4.8 with multi_v7_defconfig; mainline has different problems). Signed-off-by: Guenter Roeck <linux@roeck-us.net> --- hw/gpio/imx_gpio.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)