| Message ID | 20161024220212.8464-1-colin.king@canonical.com (mailing list archive) |
|---|---|
| State | Accepted |
| Headers | show |
On Mon, Oct 24, 2016 at 3:02 PM, Colin King <colin.king@canonical.com> wrote: > From: Colin Ian King <colin.king@canonical.com> > > trivial fix to spelling mistake in pr_debug message > > Signed-off-by: Colin Ian King <colin.king@canonical.com> > --- > arch/powerpc/platforms/pseries/hotplug-cpu.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/arch/powerpc/platforms/pseries/hotplug-cpu.c b/arch/powerpc/platforms/pseries/hotplug-cpu.c > index a1b63e0..c8929cb 100644 > --- a/arch/powerpc/platforms/pseries/hotplug-cpu.c > +++ b/arch/powerpc/platforms/pseries/hotplug-cpu.c > @@ -553,7 +553,7 @@ static ssize_t dlpar_cpu_remove(struct device_node *dn, u32 drc_index) > { > int rc; > > - pr_debug("Attemping to remove CPU %s, drc index: %x\n", > + pr_debug("Attempting to remove CPU %s, drc index: %x\n", > dn->name, drc_index); > > rc = dlpar_offline_cpu(dn); > -- > 2.9.3 Reviewed-by: Kees Cook <keescook@chromium.org> scripts/spelling.txt should likely get an addition for "attemping". It already has "attemps"... -Kees
On Mon, 2016-10-24 at 15:13 -0700, Kees Cook wrote: > On Mon, Oct 24, 2016 at 3:02 PM, Colin King <colin.king@canonical.com> wrote: > > From: Colin Ian King <colin.king@canonical.com> > > > > trivial fix to spelling mistake in pr_debug message > > > > Signed-off-by: Colin Ian King <colin.king@canonical.com> > > --- > > arch/powerpc/platforms/pseries/hotplug-cpu.c | 2 +- > > 1 file changed, 1 insertion(+), 1 deletion(-) > > > > diff --git a/arch/powerpc/platforms/pseries/hotplug-cpu.c b/arch/powerpc/platforms/pseries/hotplug-cpu.c > > index a1b63e0..c8929cb 100644 > > --- a/arch/powerpc/platforms/pseries/hotplug-cpu.c > > +++ b/arch/powerpc/platforms/pseries/hotplug-cpu.c > > @@ -553,7 +553,7 @@ static ssize_t dlpar_cpu_remove(struct device_node *dn, u32 drc_index) > > { > > int rc; > > > > - pr_debug("Attemping to remove CPU %s, drc index: %x\n", > > + pr_debug("Attempting to remove CPU %s, drc index: %x\n", > > dn->name, drc_index); > > > > rc = dlpar_offline_cpu(dn); > > -- > > 2.9.3 > > Reviewed-by: Kees Cook <keescook@chromium.org> > > scripts/spelling.txt should likely get an addition for "attemping". It > already has "attemps"... There may not be enough of these to be useful and to my knowledge Colin isn't fixing comments $ grep -rP --include=*.[ch] -wi "at+emp*t?ing" * | grep -vi attempting arch/x86/platform/uv/uv_nmi.c:/* Ping non-responding cpus attemping to force them into the NMI handler */ arch/powerpc/platforms/pseries/hotplug-cpu.c: pr_debug("Attemping to remove CPU %s, drc index: %x\n",
On 24/10/16 23:20, Joe Perches wrote: > On Mon, 2016-10-24 at 15:13 -0700, Kees Cook wrote: >> On Mon, Oct 24, 2016 at 3:02 PM, Colin King <colin.king@canonical.com> wrote: >>> From: Colin Ian King <colin.king@canonical.com> >>> >>> trivial fix to spelling mistake in pr_debug message >>> >>> Signed-off-by: Colin Ian King <colin.king@canonical.com> >>> --- >>> arch/powerpc/platforms/pseries/hotplug-cpu.c | 2 +- >>> 1 file changed, 1 insertion(+), 1 deletion(-) >>> >>> diff --git a/arch/powerpc/platforms/pseries/hotplug-cpu.c b/arch/powerpc/platforms/pseries/hotplug-cpu.c >>> index a1b63e0..c8929cb 100644 >>> --- a/arch/powerpc/platforms/pseries/hotplug-cpu.c >>> +++ b/arch/powerpc/platforms/pseries/hotplug-cpu.c >>> @@ -553,7 +553,7 @@ static ssize_t dlpar_cpu_remove(struct device_node *dn, u32 drc_index) >>> { >>> int rc; >>> >>> - pr_debug("Attemping to remove CPU %s, drc index: %x\n", >>> + pr_debug("Attempting to remove CPU %s, drc index: %x\n", >>> dn->name, drc_index); >>> >>> rc = dlpar_offline_cpu(dn); >>> -- >>> 2.9.3 >> >> Reviewed-by: Kees Cook <keescook@chromium.org> >> >> scripts/spelling.txt should likely get an addition for "attemping". It >> already has "attemps"... > > There may not be enough of these to be useful and to my > knowledge Colin isn't fixing comments Indeed, I'm just using my kernelscan tool to scrape for errors in kernel messages as these are seen by users as opposed to comments. Plus the occurrences of the mistakes I'm finding are generally very small. > > $ grep -rP --include=*.[ch] -wi "at+emp*t?ing" * | grep -vi attempting > arch/x86/platform/uv/uv_nmi.c:/* Ping non-responding cpus attemping to force them into the NMI handler */ > arch/powerpc/platforms/pseries/hotplug-cpu.c: pr_debug("Attemping to remove CPU %s, drc index: %x\n", >
On 10/24/2016 05:02 PM, Colin King wrote: > From: Colin Ian King <colin.king@canonical.com> > > trivial fix to spelling mistake in pr_debug message > > Signed-off-by: Colin Ian King <colin.king@canonical.com> Reviewed-by: Nathan Fontenot <nfont@linux.vnet.ibm.com> > --- > arch/powerpc/platforms/pseries/hotplug-cpu.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/arch/powerpc/platforms/pseries/hotplug-cpu.c b/arch/powerpc/platforms/pseries/hotplug-cpu.c > index a1b63e0..c8929cb 100644 > --- a/arch/powerpc/platforms/pseries/hotplug-cpu.c > +++ b/arch/powerpc/platforms/pseries/hotplug-cpu.c > @@ -553,7 +553,7 @@ static ssize_t dlpar_cpu_remove(struct device_node *dn, u32 drc_index) > { > int rc; > > - pr_debug("Attemping to remove CPU %s, drc index: %x\n", > + pr_debug("Attempting to remove CPU %s, drc index: %x\n", > dn->name, drc_index); > > rc = dlpar_offline_cpu(dn); >
diff --git a/arch/powerpc/platforms/pseries/hotplug-cpu.c b/arch/powerpc/platforms/pseries/hotplug-cpu.c index a1b63e0..c8929cb 100644 --- a/arch/powerpc/platforms/pseries/hotplug-cpu.c +++ b/arch/powerpc/platforms/pseries/hotplug-cpu.c @@ -553,7 +553,7 @@ static ssize_t dlpar_cpu_remove(struct device_node *dn, u32 drc_index) { int rc; - pr_debug("Attemping to remove CPU %s, drc index: %x\n", + pr_debug("Attempting to remove CPU %s, drc index: %x\n", dn->name, drc_index); rc = dlpar_offline_cpu(dn);