diff mbox

[1/2] tests: Simplify expected error checking for qmp output

Message ID 1477323383-12380-2-git-send-email-eblake@redhat.com
State New
Headers show

Commit Message

Eric Blake Oct. 24, 2016, 3:36 p.m. UTC 
Minor test cleanup noticed while writing a new test.

Signed-off-by: Eric Blake <eblake@redhat.com>
---
 tests/test-qmp-output-visitor.c | 12 ++++--------
 1 file changed, 4 insertions(+), 8 deletions(-)

Comments

Markus Armbruster Oct. 25, 2016, 11:07 a.m. UTC | #1 
Eric Blake <eblake@redhat.com> writes:

> Minor test cleanup noticed while writing a new test.
>
> Signed-off-by: Eric Blake <eblake@redhat.com>

Reviewed-by: Markus Armbruster <armbru@redhat.com>
diff mbox

Patch

diff --git a/tests/test-qmp-output-visitor.c b/tests/test-qmp-output-visitor.c
index 513d71f..f7213d2 100644
--- a/tests/test-qmp-output-visitor.c
+++ b/tests/test-qmp-output-visitor.c
@@ -141,13 +141,11 @@  static void test_visitor_out_enum_errors(TestOutputVisitorData *data,
                                          const void *unused)
 {
     EnumOne i, bad_values[] = { ENUM_ONE__MAX, -1 };
-    Error *err;
+    Error *err = NULL;

     for (i = 0; i < ARRAY_SIZE(bad_values) ; i++) {
-        err = NULL;
         visit_type_EnumOne(data->ov, "unused", &bad_values[i], &err);
-        g_assert(err);
-        error_free(err);
+        error_free_or_abort(&err);
         visitor_reset(data);
     }
 }
@@ -243,16 +241,14 @@  static void test_visitor_out_struct_errors(TestOutputVisitorData *data,
     EnumOne bad_values[] = { ENUM_ONE__MAX, -1 };
     UserDefOne u = {0};
     UserDefOne *pu = &u;
-    Error *err;
+    Error *err = NULL;
     int i;

     for (i = 0; i < ARRAY_SIZE(bad_values) ; i++) {
-        err = NULL;
         u.has_enum1 = true;
         u.enum1 = bad_values[i];
         visit_type_UserDefOne(data->ov, "unused", &pu, &err);
-        g_assert(err);
-        error_free(err);
+        error_free_or_abort(&err);
         visitor_reset(data);
     }
 }