diff mbox

[U-Boot,5/5] configs: add the CONFIG_BLK and CONFIG_DM_MMC/OPS for exynos4 series

Message ID 20161024060857.7864-5-jh80.chung@samsung.com
State Changes Requested
Delegated to: Minkyu Kang
Headers show

Commit Message

Jaehoon Chung Oct. 24, 2016, 6:08 a.m. UTC
To use the CONFIG_BLK/CONFIG_DM_MMC/CONFIG_DM_MMC_OPS, add the
configurations for exynos4 series.(by default)

Signed-off-by: Jaehoon Chung <jh80.chung@samsung.com>
---
 configs/odroid_defconfig   | 3 +++
 configs/origen_defconfig   | 3 +++
 configs/smdkv310_defconfig | 3 +++
 configs/trats2_defconfig   | 3 +++
 configs/trats_defconfig    | 3 +++
 5 files changed, 15 insertions(+)

Comments

Simon Glass Oct. 26, 2016, 4:31 p.m. UTC | #1
On 23 October 2016 at 23:08, Jaehoon Chung <jh80.chung@samsung.com> wrote:
> To use the CONFIG_BLK/CONFIG_DM_MMC/CONFIG_DM_MMC_OPS, add the
> configurations for exynos4 series.(by default)
>
> Signed-off-by: Jaehoon Chung <jh80.chung@samsung.com>
> ---
>  configs/odroid_defconfig   | 3 +++
>  configs/origen_defconfig   | 3 +++
>  configs/smdkv310_defconfig | 3 +++
>  configs/trats2_defconfig   | 3 +++
>  configs/trats_defconfig    | 3 +++
>  5 files changed, 15 insertions(+)

Reviewed-by: Simon Glass <sjg@chromium.org>

But please use savedefconfig to get the ordering correct. A recent
change should make DM_MMC and DM_MMC_OPS the default if BLK is
enabled.

- Simon
Jaehoon Chung Oct. 27, 2016, 1:58 a.m. UTC | #2
On 10/27/2016 01:31 AM, Simon Glass wrote:
> On 23 October 2016 at 23:08, Jaehoon Chung <jh80.chung@samsung.com> wrote:
>> To use the CONFIG_BLK/CONFIG_DM_MMC/CONFIG_DM_MMC_OPS, add the
>> configurations for exynos4 series.(by default)
>>
>> Signed-off-by: Jaehoon Chung <jh80.chung@samsung.com>
>> ---
>>  configs/odroid_defconfig   | 3 +++
>>  configs/origen_defconfig   | 3 +++
>>  configs/smdkv310_defconfig | 3 +++
>>  configs/trats2_defconfig   | 3 +++
>>  configs/trats_defconfig    | 3 +++
>>  5 files changed, 15 insertions(+)
> 
> Reviewed-by: Simon Glass <sjg@chromium.org>
> 
> But please use savedefconfig to get the ordering correct. A recent
> change should make DM_MMC and DM_MMC_OPS the default if BLK is
> enabled.

Got it. Thanks!

Best Regards,
Jaehoon Chung

> 
> - Simon
> 
> 
>
diff mbox

Patch

diff --git a/configs/odroid_defconfig b/configs/odroid_defconfig
index 76d0968..969d777 100644
--- a/configs/odroid_defconfig
+++ b/configs/odroid_defconfig
@@ -49,3 +49,6 @@  CONFIG_G_DNL_MANUFACTURER="Samsung"
 CONFIG_G_DNL_VENDOR_NUM=0x04e8
 CONFIG_G_DNL_PRODUCT_NUM=0x6601
 CONFIG_ERRNO_STR=y
+CONFIG_BLK=y
+CONFIG_DM_MMC=y
+CONFIG_DM_MMC_OPS=y
diff --git a/configs/origen_defconfig b/configs/origen_defconfig
index d667b0f..5b582ff 100644
--- a/configs/origen_defconfig
+++ b/configs/origen_defconfig
@@ -35,3 +35,6 @@  CONFIG_USB_GADGET_DOWNLOAD=y
 CONFIG_G_DNL_MANUFACTURER="Samsung"
 CONFIG_G_DNL_VENDOR_NUM=0x04e8
 CONFIG_G_DNL_PRODUCT_NUM=0x6601
+CONFIG_BLK=y
+CONFIG_DM_MMC=y
+CONFIG_DM_MMC_OPS=y
diff --git a/configs/smdkv310_defconfig b/configs/smdkv310_defconfig
index c8c182b..52c3cc7 100644
--- a/configs/smdkv310_defconfig
+++ b/configs/smdkv310_defconfig
@@ -24,3 +24,6 @@  CONFIG_CMD_FAT=y
 CONFIG_CMD_FS_GENERIC=y
 CONFIG_USB=y
 CONFIG_DM_USB=y
+CONFIG_BLK=y
+CONFIG_DM_MMC=y
+CONFIG_DM_MMC_OPS=y
diff --git a/configs/trats2_defconfig b/configs/trats2_defconfig
index 59b73ca..b6f6bf8 100644
--- a/configs/trats2_defconfig
+++ b/configs/trats2_defconfig
@@ -38,3 +38,6 @@  CONFIG_USB_GADGET_DOWNLOAD=y
 CONFIG_G_DNL_MANUFACTURER="Samsung"
 CONFIG_G_DNL_VENDOR_NUM=0x04e8
 CONFIG_G_DNL_PRODUCT_NUM=0x6601
+CONFIG_BLK=y
+CONFIG_DM_MMC=y
+CONFIG_DM_MMC_OPS=y
diff --git a/configs/trats_defconfig b/configs/trats_defconfig
index 2773654..26adb1f 100644
--- a/configs/trats_defconfig
+++ b/configs/trats_defconfig
@@ -37,3 +37,6 @@  CONFIG_USB_GADGET_DOWNLOAD=y
 CONFIG_G_DNL_MANUFACTURER="Samsung"
 CONFIG_G_DNL_VENDOR_NUM=0x04e8
 CONFIG_G_DNL_PRODUCT_NUM=0x6601
+CONFIG_BLK=y
+CONFIG_DM_MMC=y
+CONFIG_DM_MMC_OPS=y