| Message ID | 20161024060857.7864-3-jh80.chung@samsung.com |
|---|---|
| State | Changes Requested |
| Delegated to: | Minkyu Kang |
| Headers | show |
On 23 October 2016 at 23:08, Jaehoon Chung <jh80.chung@samsung.com> wrote: > Changed the compatible from generic thing to meaning compatible. > "samsung,exynos-mmc" should be removed. > > Signed-off-by: Jaehoon Chung <jh80.chung@samsung.com> > --- > arch/arm/dts/exynos4.dtsi | 25 +++++++++++++++---------- > 1 file changed, 15 insertions(+), 10 deletions(-) Reviewed-by: Simon Glass <sjg@chromium.org> Does the drivers need to change?
On 10/27/2016 01:31 AM, Simon Glass wrote: > On 23 October 2016 at 23:08, Jaehoon Chung <jh80.chung@samsung.com> wrote: >> Changed the compatible from generic thing to meaning compatible. >> "samsung,exynos-mmc" should be removed. >> >> Signed-off-by: Jaehoon Chung <jh80.chung@samsung.com> >> --- >> arch/arm/dts/exynos4.dtsi | 25 +++++++++++++++---------- >> 1 file changed, 15 insertions(+), 10 deletions(-) > > Reviewed-by: Simon Glass <sjg@chromium.org> > > Does the drivers need to change? Already prepared to use these. On MMC of exynos, drivers can use both with legacy and DM. When it changes to DM, i will remove everything relevant to legacy for exynos. Best Regards, Jaehoon Chung > > >
diff --git a/arch/arm/dts/exynos4.dtsi b/arch/arm/dts/exynos4.dtsi index 7de227c..312133c 100644 --- a/arch/arm/dts/exynos4.dtsi +++ b/arch/arm/dts/exynos4.dtsi @@ -111,44 +111,49 @@ interrupts = <7 63 0>; }; - sdhci@12510000 { + sdhci0: sdhci@12510000 { #address-cells = <1>; #size-cells = <0>; - compatible = "samsung,exynos-mmc"; + compatible = "samsung,exynos4412-sdhci"; reg = <0x12510000 0x1000>; interrupts = <0 75 0>; + status = "disabled"; }; - sdhci@12520000 { + sdhci1: sdhci@12520000 { #address-cells = <1>; #size-cells = <0>; - compatible = "samsung,exynos-mmc"; + compatible = "samsung,exynos4412-sdhci"; reg = <0x12520000 0x1000>; interrupts = <0 76 0>; + status = "disabled"; }; - sdhci@12530000 { + sdhci2: sdhci@12530000 { #address-cells = <1>; #size-cells = <0>; - compatible = "samsung,exynos-mmc"; + compatible = "samsung,exynos4412-sdhci"; reg = <0x12530000 0x1000>; interrupts = <0 77 0>; + status = "disabled"; }; - sdhci@12540000 { + sdhci3: sdhci@12540000 { #address-cells = <1>; #size-cells = <0>; - compatible = "samsung,exynos-mmc"; + compatible = "samsung,exynos4412-sdhci"; reg = <0x12540000 0x1000>; interrupts = <0 78 0>; + status = "disabled"; }; - dwmmc@12550000 { + mshc_0: dwmmc@12550000 { #address-cells = <1>; #size-cells = <0>; - compatible = "samsung,exynos-dwmmc"; + compatible = "samsung,exynos4412-dw-mshc"; reg = <0x12550000 0x1000>; interrupts = <0 131 0>; + status = "disabled"; }; };
Changed the compatible from generic thing to meaning compatible. "samsung,exynos-mmc" should be removed. Signed-off-by: Jaehoon Chung <jh80.chung@samsung.com> --- arch/arm/dts/exynos4.dtsi | 25 +++++++++++++++---------- 1 file changed, 15 insertions(+), 10 deletions(-)