| Message ID | 20161024060857.7864-2-jh80.chung@samsung.com |
|---|---|
| State | Changes Requested |
| Delegated to: | Minkyu Kang |
| Headers | show |
On 23 October 2016 at 23:08, Jaehoon Chung <jh80.chung@samsung.com> wrote: > mshc_0 node should be overwriten the defined node in exynos4.dtsi. I think you mean 'The mshc_0 node overwrites the defined node...' > It's meaningless. So removed this node. Instead, use the node in exynos4.dtsi. 'So remove this node' > > Signed-off-by: Jaehoon Chung <jh80.chung@samsung.com> > --- > arch/arm/dts/exynos4x12.dtsi | 13 ------------- > 1 file changed, 13 deletions(-) Reviewed-by: Simon Glass <sjg@chromium.org>
On 10/27/2016 01:31 AM, Simon Glass wrote: > On 23 October 2016 at 23:08, Jaehoon Chung <jh80.chung@samsung.com> wrote: >> mshc_0 node should be overwriten the defined node in exynos4.dtsi. > > I think you mean 'The mshc_0 node overwrites the defined node...' > >> It's meaningless. So removed this node. Instead, use the node in exynos4.dtsi. > > 'So remove this node' Will fix > >> >> Signed-off-by: Jaehoon Chung <jh80.chung@samsung.com> >> --- >> arch/arm/dts/exynos4x12.dtsi | 13 ------------- >> 1 file changed, 13 deletions(-) > > Reviewed-by: Simon Glass <sjg@chromium.org> > > >
diff --git a/arch/arm/dts/exynos4x12.dtsi b/arch/arm/dts/exynos4x12.dtsi index b83a0d3..e5ac15a 100644 --- a/arch/arm/dts/exynos4x12.dtsi +++ b/arch/arm/dts/exynos4x12.dtsi @@ -27,7 +27,6 @@ pinctrl1 = &pinctrl_1; pinctrl2 = &pinctrl_2; pinctrl3 = &pinctrl_3; - mshc0 = &mshc_0; }; pd_isp: isp-power-domain@10023CA0 { @@ -100,16 +99,4 @@ clock-names = "sclk_fimg2d", "fimg2d"; status = "disabled"; }; - - mshc_0: mmc@12550000 { - compatible = "samsung,exynos4412-dw-mshc"; - reg = <0x12550000 0x1000>; - interrupts = <0 131 0>; - #address-cells = <1>; - #size-cells = <0>; - fifo-depth = <0x80>; - clocks = <&clock 301>, <&clock 149>; - clock-names = "biu", "ciu"; - status = "disabled"; - }; };
mshc_0 node should be overwriten the defined node in exynos4.dtsi. It's meaningless. So removed this node. Instead, use the node in exynos4.dtsi. Signed-off-by: Jaehoon Chung <jh80.chung@samsung.com> --- arch/arm/dts/exynos4x12.dtsi | 13 ------------- 1 file changed, 13 deletions(-)