Patchwork pata_bf54x: fix return type of bfin_set_devctl

login
register
mail settings
Submitter Mike Frysinger
Date Oct. 21, 2010, 8 a.m.
Message ID <1287648040-19759-1-git-send-email-vapier@gentoo.org>
Download mbox | patch
Permalink /patch/68534/
State Not Applicable
Delegated to: David Miller
Headers show

Comments

Mike Frysinger - Oct. 21, 2010, 8 a.m.
The new devctl func added for us to the driver has the wrong return
type.  Which is to say there shouldn't be any.  This fixes compile
time warnings as there shouldn't be any runtime difference.

Signed-off-by: Mike Frysinger <vapier@gentoo.org>
---
 drivers/ata/pata_bf54x.c |    2 +-
 1 files changed, 1 insertions(+), 1 deletions(-)
Sergei Shtylyov - Oct. 21, 2010, 5:45 p.m.
Hello.

On 21-10-2010 12:00, Mike Frysinger wrote:

> The new devctl func added for us to the driver has the wrong return
> type.  Which is to say there shouldn't be any.  This fixes compile
> time warnings as there shouldn't be any runtime difference.

> Signed-off-by: Mike Frysinger<vapier@gentoo.org>
[...]

> diff --git a/drivers/ata/pata_bf54x.c b/drivers/ata/pata_bf54x.c
> index 9cae65d..5eeb922 100644
> --- a/drivers/ata/pata_bf54x.c
> +++ b/drivers/ata/pata_bf54x.c
> @@ -826,7 +826,7 @@ static void bfin_dev_select(struct ata_port *ap, unsigned int device)
>    *	@ctl: value to write
>    */
>
> -static u8 bfin_set_devctl(struct ata_port *ap, u8 ctl)
> +static void bfin_set_devctl(struct ata_port *ap, u8 ctl)

    Sorry about that. Don't know how 'u8' crawled in...

MBR, Sergei
--
To unsubscribe from this list: send the line "unsubscribe linux-ide" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

Patch

diff --git a/drivers/ata/pata_bf54x.c b/drivers/ata/pata_bf54x.c
index 9cae65d..5eeb922 100644
--- a/drivers/ata/pata_bf54x.c
+++ b/drivers/ata/pata_bf54x.c
@@ -826,7 +826,7 @@  static void bfin_dev_select(struct ata_port *ap, unsigned int device)
  *	@ctl: value to write
  */
 
-static u8 bfin_set_devctl(struct ata_port *ap, u8 ctl)
+static void bfin_set_devctl(struct ata_port *ap, u8 ctl)
 {
 	void __iomem *base = (void __iomem *)ap->ioaddr.ctl_addr;
 	write_atapi_register(base, ATA_REG_CTRL, ctl);