Ack+patch: [yakkety SRU] LP#1635594 -- hio driver missing

Message ID 580A1B57.9010605@canonical.com
State New
Headers show

Commit Message

Leann Ogasawara Oct. 21, 2016, 1:42 p.m.
Acked-by: Leann Ogasawara <leann.ogasawara@canonical.com>

I've also attached a patch here which should apply cleanly on top of
this pull request to add hio to the annotations file to help prevent
this from going missing again.

Thanks,
Leann

On 10/21/2016 05:25 AM, Andy Whitcroft wrote:
> It seems the Ubuntu driver hio is no longer included with the Yakkety
> kernel.  This creates a regression-release in yakkety and will cause
> corresponding issues with the HWE kernels when they are released.
> 
> Proposing the below pull-request for SRU to yakkety.
> 
> -apw
> 
> The following changes since commit 7b66e0f562be96b5b73f45dbda334935bfbea3cb:
> 
>   Linux 4.8.2 (2016-10-20 16:14:17 -0500)
> 
> are available in the git repository at:
> 
>   git://git.launchpad.net/~apw/ubuntu/+source/linux/+git/yakkety lp1635594
> 
> for you to fetch changes up to bb9757a7912dc6adf9aa8ef221441566f581ef9a:
> 
>   UBUNTU: SAUCE: hio: Makefile and Kconfig (2016-10-21 13:14:12 +0100)
> 
> ----------------------------------------------------------------
> Andy Whitcroft (1):
>       UBUNTU: SAUCE: hio: port to v4.8 base
> 
> Huawei SSD DEV Team (1):
>       UBUNTU: SAUCE: import Huawei ES3000_V2 (2.1.0.23)
> 
> Kamal Mostafa (6):
>       UBUNTU: SAUCE: hio: bio_endio() no longer takes errors arg
>       UBUNTU: SAUCE: hio: blk_queue make_request_fn now returns a blk_qc_t
>       UBUNTU: SAUCE: hio: use alloc_cpumask_var to avoid -Wframe-larger-than
>       UBUNTU: SAUCE: hio: fix mask maybe-uninitialized warning
>       UBUNTU: [config] enable CONFIG_HIO (Huawei ES3000_V2 PCIe SSD driver)
>       UBUNTU: SAUCE: hio: Makefile and Kconfig
> 
>  debian.master/config/amd64/config.common.amd64 |     1 +
>  debian.master/config/config.common.ubuntu      |     1 +
>  debian.master/config/i386/config.common.i386   |     1 +
>  debian.master/d-i/modules/block-modules        |     1 +
>  ubuntu/Kconfig                                 |     4 +
>  ubuntu/Makefile                                |     7 +
>  ubuntu/hio/Kconfig                             |     4 +
>  ubuntu/hio/Makefile                            |     1 +
>  ubuntu/hio/hio.c                               | 12566 +++++++++++++++++++++++
>  ubuntu/hio/hio.h                               |   104 +
>  10 files changed, 12690 insertions(+)
>  create mode 100644 ubuntu/hio/Kconfig
>  create mode 100644 ubuntu/hio/Makefile
>  create mode 100644 ubuntu/hio/hio.c
>  create mode 100644 ubuntu/hio/hio.h
>

Comments

Andy Whitcroft Oct. 21, 2016, 1:51 p.m. | #1
On Fri, Oct 21, 2016 at 06:42:47AM -0700, Leann Ogasawara wrote:
> Acked-by: Leann Ogasawara <leann.ogasawara@canonical.com>
> 
> I've also attached a patch here which should apply cleanly on top of
> this pull request to add hio to the annotations file to help prevent
> this from going missing again.
> 
> Thanks,
> Leann
> 
> On 10/21/2016 05:25 AM, Andy Whitcroft wrote:
> > It seems the Ubuntu driver hio is no longer included with the Yakkety
> > kernel.  This creates a regression-release in yakkety and will cause
> > corresponding issues with the HWE kernels when they are released.
> > 
> > Proposing the below pull-request for SRU to yakkety.
> > 
> > -apw
> > 
> > The following changes since commit 7b66e0f562be96b5b73f45dbda334935bfbea3cb:
> > 
> >   Linux 4.8.2 (2016-10-20 16:14:17 -0500)
> > 
> > are available in the git repository at:
> > 
> >   git://git.launchpad.net/~apw/ubuntu/+source/linux/+git/yakkety lp1635594
> > 
> > for you to fetch changes up to bb9757a7912dc6adf9aa8ef221441566f581ef9a:
> > 
> >   UBUNTU: SAUCE: hio: Makefile and Kconfig (2016-10-21 13:14:12 +0100)
> > 
> > ----------------------------------------------------------------
> > Andy Whitcroft (1):
> >       UBUNTU: SAUCE: hio: port to v4.8 base
> > 
> > Huawei SSD DEV Team (1):
> >       UBUNTU: SAUCE: import Huawei ES3000_V2 (2.1.0.23)
> > 
> > Kamal Mostafa (6):
> >       UBUNTU: SAUCE: hio: bio_endio() no longer takes errors arg
> >       UBUNTU: SAUCE: hio: blk_queue make_request_fn now returns a blk_qc_t
> >       UBUNTU: SAUCE: hio: use alloc_cpumask_var to avoid -Wframe-larger-than
> >       UBUNTU: SAUCE: hio: fix mask maybe-uninitialized warning
> >       UBUNTU: [config] enable CONFIG_HIO (Huawei ES3000_V2 PCIe SSD driver)
> >       UBUNTU: SAUCE: hio: Makefile and Kconfig
> > 
> >  debian.master/config/amd64/config.common.amd64 |     1 +
> >  debian.master/config/config.common.ubuntu      |     1 +
> >  debian.master/config/i386/config.common.i386   |     1 +
> >  debian.master/d-i/modules/block-modules        |     1 +
> >  ubuntu/Kconfig                                 |     4 +
> >  ubuntu/Makefile                                |     7 +
> >  ubuntu/hio/Kconfig                             |     4 +
> >  ubuntu/hio/Makefile                            |     1 +
> >  ubuntu/hio/hio.c                               | 12566 +++++++++++++++++++++++
> >  ubuntu/hio/hio.h                               |   104 +
> >  10 files changed, 12690 insertions(+)
> >  create mode 100644 ubuntu/hio/Kconfig
> >  create mode 100644 ubuntu/hio/Makefile
> >  create mode 100644 ubuntu/hio/hio.c
> >  create mode 100644 ubuntu/hio/hio.h
> > 
> 

> From 974628ae874f2438f5d16e4efa3c6dcbe82e3230 Mon Sep 17 00:00:00 2001
> From: Leann Ogasawara <leann.ogasawara@canonical.com>
> Date: Fri, 21 Oct 2016 06:21:37 -0700
> Subject: [PATCH] UBUNTU: [Config] Enforce CONFIG_HIO
> 
> BugLink: http://bugs.launchpad.net/bugs/1635594
> 
> Signed-off-by: Leann Ogasawara <leann.ogasawara@canonical.com>
> ---
>  debian.master/config/annotations | 3 +++
>  1 file changed, 3 insertions(+)
> 
> diff --git a/debian.master/config/annotations b/debian.master/config/annotations
> index 93765d86..cc77bd8 100644
> --- a/debian.master/config/annotations
> +++ b/debian.master/config/annotations
> @@ -10248,6 +10248,9 @@ CONFIG_SHMOBILE_TIMER_HZ                        policy<{'armhf': '128'}>
>  # Menu: System Type >> W90P910 Machines >> Architecture: arm
>  
>  # Menu: Ubuntu Supplied Third-Party Device Drivers
> +CONFIG_HIO                                      policy<{'amd64': 'm', 'arm64': 'n', 'armhf': 'n', 'i386': 'm', 'powerpc': 'n', 'ppc64el': 'n'}>
> +#
> +CONFIG_HIO                                      mark<ENFORCED> note <LP:1635594>
>  
>  # Menu: Virtualization
>  CONFIG_VIRTUALIZATION                           policy<{'amd64': 'y', 'arm64': 'y', 'armhf': 'y', 'i386': 'y', 'powerpc': 'y', 'ppc64el': 'y', 's390x': 'y'}>
> -- 
> 2.9.3

Cross-acking the annotation file update only:

Acked-by: Andy Whitcroft <apw@canonical.com>

-apw

Patch

From 974628ae874f2438f5d16e4efa3c6dcbe82e3230 Mon Sep 17 00:00:00 2001
From: Leann Ogasawara <leann.ogasawara@canonical.com>
Date: Fri, 21 Oct 2016 06:21:37 -0700
Subject: [PATCH] UBUNTU: [Config] Enforce CONFIG_HIO

BugLink: http://bugs.launchpad.net/bugs/1635594

Signed-off-by: Leann Ogasawara <leann.ogasawara@canonical.com>
---
 debian.master/config/annotations | 3 +++
 1 file changed, 3 insertions(+)

diff --git a/debian.master/config/annotations b/debian.master/config/annotations
index 93765d86..cc77bd8 100644
--- a/debian.master/config/annotations
+++ b/debian.master/config/annotations
@@ -10248,6 +10248,9 @@  CONFIG_SHMOBILE_TIMER_HZ                        policy<{'armhf': '128'}>
 # Menu: System Type >> W90P910 Machines >> Architecture: arm
 
 # Menu: Ubuntu Supplied Third-Party Device Drivers
+CONFIG_HIO                                      policy<{'amd64': 'm', 'arm64': 'n', 'armhf': 'n', 'i386': 'm', 'powerpc': 'n', 'ppc64el': 'n'}>
+#
+CONFIG_HIO                                      mark<ENFORCED> note <LP:1635594>
 
 # Menu: Virtualization
 CONFIG_VIRTUALIZATION                           policy<{'amd64': 'y', 'arm64': 'y', 'armhf': 'y', 'i386': 'y', 'powerpc': 'y', 'ppc64el': 'y', 's390x': 'y'}>
-- 
2.9.3