diff mbox

PR libgcc/78064: Add missing include directive to unwind-c.c

Message ID 119fae40-b57b-5643-8ccb-e72bd9923183@redhat.com
State New
Headers show

Commit Message

Florian Weimer Oct. 21, 2016, 10:14 a.m. UTC 
See

   https://gcc.gnu.org/ml/gcc/2016-10/msg00165.html

for the background.  This causes pthread_cond_wait in glibc to write out 
of bounds on i386.

Fix was suggested by Jim Wilson.

Tested on x86_64-redhat-linux-gnu, with no new regressions.  Also tested 
against the i386 glibc reproducer, and verified that _Unwind_GetIPInfo 
is called from the __gcc_personality_v0.

Okay for trunk?

We probably should backport this to all active branches as well.  The 
risk is fairly low because the C unwinder personality is rarely used 
(Eric Botcazou pointed out that the C++ and Ada personalities are not 
affected by this).

2016-10-21  Florian Weimer  <fweimer@redhat.com>

	PR libgcc/78064
	* unwind-c.c: Include auto-target.h.

Comments

Jakub Jelinek Oct. 24, 2016, 6:15 p.m. UTC | #1 
On Fri, Oct 21, 2016 at 12:14:50PM +0200, Florian Weimer wrote:
> See
> 
>   https://gcc.gnu.org/ml/gcc/2016-10/msg00165.html
> 
> for the background.  This causes pthread_cond_wait in glibc to write out of
> bounds on i386.
> 
> Fix was suggested by Jim Wilson.
> 
> Tested on x86_64-redhat-linux-gnu, with no new regressions.  Also tested
> against the i386 glibc reproducer, and verified that _Unwind_GetIPInfo is
> called from the __gcc_personality_v0.
> 
> Okay for trunk?

Ok, thanks.

> We probably should backport this to all active branches as well.  The risk
> is fairly low because the C unwinder personality is rarely used (Eric
> Botcazou pointed out that the C++ and Ada personalities are not affected by
> this).

I think it is ok to backport say after 14 days on the trunk (of course only
to still supported branches, 5/6).

> 2016-10-21  Florian Weimer  <fweimer@redhat.com>
> 
> 	PR libgcc/78064
> 	* unwind-c.c: Include auto-target.h.

	Jakub
diff mbox

Patch

Index: libgcc/unwind-c.c
===================================================================
--- libgcc/unwind-c.c	(revision 241395)
+++ libgcc/unwind-c.c	(working copy)
@@ -26,6 +26,7 @@ 
 
 #include "tconfig.h"
 #include "tsystem.h"
+#include "auto-target.h"
 #include "unwind.h"
 #define NO_SIZE_OF_ENCODED_VALUE
 #include "unwind-pe.h"