Message ID | e81d1dfe-bcbf-64e4-6270-4309fa6b2e78@mellanox.com |
---|---|
State | RFC, archived |
Delegated to: | David Miller |
Headers | show
Return-Path: <netdev-owner@vger.kernel.org> X-Original-To: patchwork-incoming@ozlabs.org Delivered-To: patchwork-incoming@ozlabs.org Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by ozlabs.org (Postfix) with ESMTP id 3t07dp39Zqz9sD6 for <patchwork-incoming@ozlabs.org>; Thu, 20 Oct 2016 23:38:38 +1100 (AEDT) Authentication-Results: ozlabs.org; dkim=pass (1024-bit key; unprotected) header.d=Mellanox.com header.i=@Mellanox.com header.b=cidJREAm; dkim-atps=neutral Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S932771AbcJTMie (ORCPT <rfc822;patchwork-incoming@ozlabs.org>); Thu, 20 Oct 2016 08:38:34 -0400 Received: from mail-db5eur01on0083.outbound.protection.outlook.com ([104.47.2.83]:6512 "EHLO EUR01-DB5-obe.outbound.protection.outlook.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1751873AbcJTMic (ORCPT <rfc822;netdev@vger.kernel.org>); Thu, 20 Oct 2016 08:38:32 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=Mellanox.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version; bh=IJm6t2SiKro1ySqeHiAWcAGWatPd2Ny/iLTYSoRxJA8=; b=cidJREAm5b97dmTQWj/RBs4PKKxAuRGD1sFsXtMMYhUxpxHVGvuT/G29r+MNQloB+oM5Nei3O8931Tl7jY1WcrpaBZ4i4j84uxnqhsm/woHxYfgT0TLZSsxygHPggn5XqbaS5BJY+ZJACFNYdPM64PqhW/7qzQC9tEtvHNrYl/M= Authentication-Results: spf=none (sender IP is ) smtp.mailfrom=tariqt@mellanox.com; Received: from [10.8.0.228] (193.47.165.251) by DB6PR0501MB2037.eurprd05.prod.outlook.com (10.168.9.19) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_CBC_SHA384_P384) id 15.1.669.16; Thu, 20 Oct 2016 09:07:05 +0000 Subject: Re: mlx4: panic during shutdown To: Sebastian Ott <sebott@linux.vnet.ibm.com>, Yishai Hadas <yishaih@mellanox.com> References: <alpine.LFD.2.20.1610191617400.1730@schleppi> CC: <netdev@vger.kernel.org>, <linux-kernel@vger.kernel.org> From: Tariq Toukan <tariqt@mellanox.com> Message-ID: <e81d1dfe-bcbf-64e4-6270-4309fa6b2e78@mellanox.com> Date: Thu, 20 Oct 2016 12:07:01 +0300 User-Agent: Mozilla/5.0 (Windows NT 6.1; WOW64; rv:45.0) Gecko/20100101 Thunderbird/45.4.0 MIME-Version: 1.0 In-Reply-To: <alpine.LFD.2.20.1610191617400.1730@schleppi> Content-Type: text/plain; charset="windows-1252"; format=flowed Content-Transfer-Encoding: 7bit X-Originating-IP: [193.47.165.251] X-ClientProxiedBy: AM3PR03CA044.eurprd03.prod.outlook.com (10.141.191.172) To DB6PR0501MB2037.eurprd05.prod.outlook.com (10.168.9.19) X-MS-Office365-Filtering-Correlation-Id: 117337c6-5e6a-4393-3a53-08d3f8c87703 X-Microsoft-Exchange-Diagnostics: 1; DB6PR0501MB2037; 2:dSGN/x4JHrAV8pChuyawcDiwt74Uc6mz1BHzzdcEY9m+pZIU3GkKC6HOeMPjg0hiUof7omEtUa5hG3q5LjTyLRJlrf/QlEl0x9wYS20n988yQytIgRs3dfC+BZ1Z+QhJvdoN1F/gGYgB4ruo7f6UDnqiiCBYYt3DmwbaBQfQo0EERgpDZaVfZXP/s/mjiQuEX77Kw5QVgsqgFK7yMSy15g==; 3:mqTqlwPJ3b50RBRDp1d235P6rokioodjjWqcccqCa4JoL7KCOJiOnABsDRCdVk/fEeyISssI55ncOyPk92gb+dK7yZa5W9o0UIcesejp16mnwPEwGivwy/GvuJx7xfXiuYs/n1OM7Jps3hCxERVvwg== X-Microsoft-Antispam: UriScan:;BCL:0;PCL:0;RULEID:;SRVR:DB6PR0501MB2037; X-Microsoft-Exchange-Diagnostics: 1; DB6PR0501MB2037; 25:kDcKvqzrHG5isIHu/CoqVm0dTSAawrxwWIWDzYkqYn3SJ7FnyfsA8Hiuo3rLyvNwU9vgI1pU2/yVE/9i477d70gyhQ9jdIR2VNxVDqTe76EaqlRygwT/sfUUkC66gb5oroB+Ug20LuZUUtTwe/MrRJkCErKI6py+1rmoJwOhoO6hG9+Nw5/HctNFuIQ67LXB2Y2Lg6El4AiL0j4TW6nodsgnJ3guMhCJcq1gNegUDUrAbsouDa+clK1Guen3zbzJYHCVIDTm5xrurhUcM+V6wVmiKtsSeN73ReQGe+BBJ9RNAmTpP1KoNolCuHjx/9ueiST0SzKKQIXg/KB1ftLF/wN/FyS9163697d0oJWIy2omcQsVT/6aQdepAT/2xhjYQ1lEnV1EPNf/yrDg+/GMEC6PZ2Y8RLXEUxbSFJi5rDeqZp93cMrProJpM/9+yld4qXhu0YO3164x3yIJ40qVRMVRsfh7D0fXH/c7Sv33fdyeixBGEKTr6RIwK1RR+F2LilIswPml+93RiW7TaDYDZroMqp4xMnS+afHTwL0p1QIvXjc+vKHOogZNN/U1PJHM10rEkb1PS6YKlckgSlKUcRW5ZuvZRj5q76ojND9bXDLZicO2i9qNlhFSVVSJ3pWrnNK58dLYNZFjDYxPAR4O9frormaLpkrdtr3Bc2y5InXxcgyI/dA9P0wU9SJNm1ZgWthSAL9mdtVUxDj19XDCQQmSlEwLWCGmp0GKc37agPM= X-Microsoft-Exchange-Diagnostics: 1; DB6PR0501MB2037; 31:rzKUHwefEb4hkemfNntg6HKDOw3zMzrVJSoIURrbYo25kei31DuYA9wkyCdBsg3SnQuZHTGlxmXX8yUwDO+oX8z6qsuzbG6BNOZcH4NsQIOr1cItitz4+VhE3TBLj1hHy4Fs37L/S2nftzPqU5vCC1xtYN0SmoyGZqK794rfkTrGEr5/BuheFQLV1K4hjJiGAttbBR8sZoBqvNVVIzklidB9YFQRp3pisN8HG0Fz5OeXe+tIKtGoOsU9gYeKmPjG; 20:JUAe6lCVsY1yi+gqBYIoy0yvDO8OAGSKEbM0//mglinze9a/U0Tm3H37IeT/bIj/Pi4BG2+FeZcTOuBEfHyKjn80K+lF9uGs4Xd9Tat49nGbmcL2wWu5sPpE10UxyecgtN0CdGMoFfgmJkiJWgrLfrPEns0s1vSZ/lv2EwQ9ZB2F9peAYWMnvDJHwO5cjeGukk9PPupxFpkESRNSDCTxnBLbxlorKHf26eumkhmQZLwh8zKrrmccEVpDs2IsPjTOvh7sxgdOqiSgbmhb5V1wVurNFK2xaijUdXxc5IR1/ja1FvBp+1XR9uCLM7OH0kDIv6H8lg7I/mutJoqNW7roQrn/yq+NN334vHtDdvAmX6PPzt5jBk/oa7ZbaXDizuHDi0ip8lHb8yKmtqQMXRE3f6MNuEOrBcPru4aRM0nv7Y6HKi8k+l3i90FEJydeb0Ef8n2oJ8s0MfDavWz+ppUUKPDu35jpIObMpbpDF77hBQxgnxNjvqEY3uIy0q2nFIGC X-Microsoft-Antispam-PRVS: <DB6PR0501MB20379A9684BE605ECA52E203AED50@DB6PR0501MB2037.eurprd05.prod.outlook.com> X-Exchange-Antispam-Report-Test: UriScan:; X-Exchange-Antispam-Report-CFA-Test: BCL:0; PCL:0; RULEID:(6040176)(601004)(2401047)(8121501046)(5005006)(3002001)(10201501046)(6055026); SRVR:DB6PR0501MB2037; BCL:0; PCL:0; RULEID:; SRVR:DB6PR0501MB2037; X-Microsoft-Exchange-Diagnostics: 1; DB6PR0501MB2037; 4:wPoJHF+YMIX6Iwo3R0boUEEparWzUrduBTGEEdEtZv0RwcoSNxqPtyRxwoULT5UNlF0/qDgzWwKGNQkIlHOHO6qIbVIDozk09LOs9Ros6JdnfeI+EM6yLE+YbvZ4JqNhQe/Z5qW561Lq4bBwdeXkaXwveBE8Fq+/HP7Vp39bx8P7uqYLXUAQKgN9r7x9X8t37gZrVOUQhMdbo5KIWsLwRudglP05Ai2agcfKPjjbx0BRn3/z2QliqQGo2KvrTfQ40TXS63BiOWZ+dAWcJKK5+zeNCDCBUZLZl5HQXG6hbS3un5JRbH6TkRCmVTCBIBBYlzMamsxs/P4psit3sI3w72s6KFT+2c4LeXS5hkhcs+1wcAhCr2drlXjet0rmDqxxoqmkqxdhse93sBPHyhK6dBBaSGzRbsvBXG5reVTaAWw= X-Forefront-PRVS: 01018CB5B3 X-Forefront-Antispam-Report: SFV:NSPM; SFS:(10009020)(4630300001)(979002)(6009001)(6049001)(7916002)(51914003)(199003)(377454003)(189002)(24454002)(51234002)(575784001)(86362001)(101416001)(4001350100001)(97736004)(6116002)(3846002)(5001770100001)(31696002)(586003)(47776003)(66066001)(23746002)(65806001)(92566002)(230700001)(33646002)(65956001)(2906002)(6666003)(106356001)(6862003)(83506001)(6636002)(4326007)(36756003)(64126003)(7736002)(2950100002)(65826007)(105586002)(7846002)(81166006)(77096005)(50986999)(50466002)(81156014)(31686004)(305945005)(42186005)(76176999)(68736007)(54356999)(189998001)(8676002)(5660300001)(969003)(989001)(999001)(1009001)(1019001); DIR:OUT; SFP:1101; SCL:1; SRVR:DB6PR0501MB2037; H:[10.8.0.228]; FPR:; SPF:None; PTR:InfoNoRecords; A:1; MX:1; LANG:en; Received-SPF: None (protection.outlook.com: mellanox.com does not designate permitted sender hosts) X-Microsoft-Exchange-Diagnostics: =?Windows-1252?Q?1; DB6PR0501MB2037; 23:4T6jmtiCRFbI8u0W6mDq3F7XBTXu6LtNsqN?= =?Windows-1252?Q?yYjfuavwOPlvMdBBp4aAu9LoUWsq3MNVKw0vkj6+K8Ya99MEaS0b3wsc?= =?Windows-1252?Q?RY0yIThJ2rJrddgjYXWmZ+JKecUtXMOLuztYiuIKwuOTg5uBbl7pqz7Q?= =?Windows-1252?Q?IjnWfuP3kkvoEtecpw6FEhFn+wlMnEvBcIFglHqexV+wkg/xolmBu1Nt?= =?Windows-1252?Q?pClnUh4+lDYOcIEyd26Ce0IYLaLJ/4ZZ8ihkjtzk8Z/ErVTRQo9q94ja?= =?Windows-1252?Q?ylxcR1jdlw2V58ZgrxUn/AeNgGYlgEkP5Ni/czHU62L3qeuHqCwcuyMN?= =?Windows-1252?Q?j8eFPvo0dwwY2Z3MqQBG2oJ9STMK2Gv5cusj4UZocWhve5obOI65KwNV?= =?Windows-1252?Q?FL3TZEvPNDbjIqYgBbOEEKCm6rCXMbi0nO8gWAYWzyxEg1PKConxJm//?= =?Windows-1252?Q?YYTV8OwG1oeNykrbcNrUGKj1Z6NnMdWwYI5N6ygNTbdM8xxQREEnGJ5t?= =?Windows-1252?Q?VBoCGPu8JiOm38doAF07Y3KjnlpL9UxSfHW8MWwdRLiPNdMt7q9N54+K?= =?Windows-1252?Q?70SWbSFnQNUhrlf68MLhtcUCEe7QEK0TF2nwoFouIfSm9xJ5j1KD5O+S?= =?Windows-1252?Q?TSE6Th0DSbEdJJwc4Xs6Src2tsX3qmzEoFCzXpf8O/xaKQGA2LjJdUSi?= =?Windows-1252?Q?+kLuwaRoxD7AryE3g/oD3Zb0evswQCvQQAyTF5jwp0q+COkR+RhRIArV?= =?Windows-1252?Q?BG46XT5LbiBihKmRXclociXO3wfhYLjxOsgh1zrHo+UGw1yRfQtLpQlo?= =?Windows-1252?Q?HMgtyknPOTIDU7dGGSvP/3g04TLMTEF6VLTD/XnF1GFoLBG5UXbbFReH?= =?Windows-1252?Q?SPW8ODVwvQsSU59XA/RkmCCjAoJ5DPy8vIQDePMiDxvmsoxt9EXgvzAx?= =?Windows-1252?Q?9c4PdROL0Gry25H33yC37m3CSkvr7GKeQagIgIi/GDCRO1qbC2pLVdCB?= =?Windows-1252?Q?XhsuGy9O3qHNQAsbcoH88Bc9pR0wMHRe/5UIYgYsYW0yKrOjcvs+CCwn?= =?Windows-1252?Q?GslsrrwuzFHQXZ1q7D2F5SCrp5yjTDhDLUa9CeoQPunB7r1BusqTD/8j?= =?Windows-1252?Q?RZn/ET2ren+aVIVnEbY4vujE1S6325WClsW+KMvHrOpcZrXk6WsdjG/8?= =?Windows-1252?Q?wAZaD0rkk0VEepMfUmB47a8nAuCSyvYNOKu1tzDcCrjVxQ+5KVGqmFnb?= =?Windows-1252?Q?ms4CW7eH7UGgLEc0Y0dX1kUBNLdsqM5cESV+s1tD4y1nFuOl6OKsFxxV?= =?Windows-1252?Q?dDvQMq7GmFaoPnGpciQwVwfoIwFTcQ96RxqBooH0XAYyjxSQNZ7CRAkP?= =?Windows-1252?Q?1E6f5lQOUrxFhgZLUoHjpKE5YHi3wss1i9Hfv9FZEfr9HlqZo/7FimEU?= =?Windows-1252?Q?NWgnAcKqVP3tHEdhnI8aCgo0deksdOfhgKA5vtBmuqDg9jIkMlPmaTGP?= =?Windows-1252?Q?Djq5kWP+6x928QAejiFnMoUSdw4g10Fwixx6VISAq+mJ8HuN0zFqzRzC?= =?Windows-1252?Q?fqe8P6crr4jP9e65DkcrckZPw3NTJ/lbAjHxN?= X-Microsoft-Exchange-Diagnostics: 1; DB6PR0501MB2037; 6:Y+Hrpn1cZGBKwfkxKdoPVIk/gRvKFgHva0CPuln6vOrU0nFu3/9iruwbCnMHqR24+iXh6fDkPY4Fei/T7YLB+Phum5aTDaOjUc7yvajVD2OmZwNogN93kUm8pZAJqeDQWj5xjdbBMG+YfEFrVwK9zM1No/JQrwUDyX/b07iTM76xgOigNn/YIn4fJ8SyWIl7D0NO7R82wyQ+Qas3qKuuovXxP6MkheYE9YzrmmuKssRyXzFXljFVuo53cD1yDLkMApiklbXSCo7+450hMGt3E/hZ5NvbxgNrRCNZxg9BuewhYacNX200CqB5gWdJo6ULHWcrBXIExpZaiovxivv4Xg==; 5:QvrlD4E5B+irpmWrMLYtfG/tf1mXI8e9t1Pw0p/VaM7HUh+vZ01yDPgkVHuY6UABmXA14ajvQ2uA5/xtbnRTSLiJGHzIiPPN6CEd9f9rqQdBiZReUGx0LTbTS7Wg/g/ZQr0DDFMAntSaBiQ6/D+F1w==; 24:J1RNdfRbReJBY5dz7wocRYPjqB7n+BTcfkRnscqxiprSl4U65jrQWVUR36WwajZpb8pNhyEleqiLtOS9e12O+pTq4CKEBVroVY0apv4DG6g= SpamDiagnosticOutput: 1:99 SpamDiagnosticMetadata: NSPM X-Microsoft-Exchange-Diagnostics: 1; DB6PR0501MB2037; 7:cALsXgbAVqWR+mzUYocSj/LH8SEncQKA8zC+Qxv1PKLRNIavX+XZfBt3XNMKNK/2LN0TyWzWiTxGtEwdVEcOAsapCF6i3Sb6KdBhF4afMTseWfx0ZU7wUEDdsJSO/46260R68WWddTi/LBRjTJLtAVzU7fhaHRzgIGLmVNHfc9Dwsx95f8A8v/Hr9XdhEWfOAIWiTCNKvQ5UKYYFTW7d/Sro0a9BGJBQZAgVbfDFSTYub9ontWUSLgsKQLYVpwW0GxnV9iENZTtXEbVnT/Egc9ZyQR4ovh9BsnuhM10yuxMtD/29YFM40poChRJnlYiwt4j9CKHx+4N1ETZBFbrkta0kyHMVg7j/KFZNmIv2wU4= X-OriginatorOrg: Mellanox.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 20 Oct 2016 09:07:05.7174 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-Transport-CrossTenantHeadersStamped: DB6PR0501MB2037 Sender: netdev-owner@vger.kernel.org Precedence: bulk List-ID: <netdev.vger.kernel.org> X-Mailing-List: netdev@vger.kernel.org |
--- a/net/core/dev.c +++ b/net/core/dev.c @@ -6601,6 +6601,8 @@ int dev_get_phys_port_id(struct net_device *dev, if (!ops->ndo_get_phys_port_id) return -EOPNOTSUPP; + if (!netif_device_present(dev)) + return -ENODEV; return ops->ndo_get_phys_port_id(dev, ppid); } EXPORT_SYMBOL(dev_get_phys_port_id);