diff mbox

[3/5] lib: fwts_firmware: constify feature_names

Message ID 20161019123755.29811-4-colin.king@canonical.com
State Accepted
Headers show

Commit Message

Colin Ian King Oct. 19, 2016, 12:37 p.m. UTC 
From: Colin Ian King <colin.king@canonical.com>

Signed-off-by: Colin Ian King <colin.king@canonical.com>
---
 src/lib/src/fwts_firmware.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

Comments

Alex Hung Oct. 19, 2016, 5:29 p.m. UTC | #1 
On 2016-10-19 05:37 AM, Colin King wrote:
> From: Colin Ian King <colin.king@canonical.com>
>
> Signed-off-by: Colin Ian King <colin.king@canonical.com>
> ---
>  src/lib/src/fwts_firmware.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/src/lib/src/fwts_firmware.c b/src/lib/src/fwts_firmware.c
> index 972303a..82849fb 100644
> --- a/src/lib/src/fwts_firmware.c
> +++ b/src/lib/src/fwts_firmware.c
> @@ -26,7 +26,7 @@
>  static enum firmware_type firmware_type;
>  static bool firmware_type_valid;
>
> -static struct {
> +static const struct {
>  	enum firmware_feature feature;
>  	const char name[16];
>  } feature_names[] = {
>

Acked-by: Alex Hung <alex.hung@canonical.com>
Ivan Hu Oct. 24, 2016, 8 a.m. UTC | #2 
On 2016年10月19日 20:37, Colin King wrote:
> From: Colin Ian King <colin.king@canonical.com>
>
> Signed-off-by: Colin Ian King <colin.king@canonical.com>
> ---
>  src/lib/src/fwts_firmware.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/src/lib/src/fwts_firmware.c b/src/lib/src/fwts_firmware.c
> index 972303a..82849fb 100644
> --- a/src/lib/src/fwts_firmware.c
> +++ b/src/lib/src/fwts_firmware.c
> @@ -26,7 +26,7 @@
>  static enum firmware_type firmware_type;
>  static bool firmware_type_valid;
>
> -static struct {
> +static const struct {
>  	enum firmware_feature feature;
>  	const char name[16];
>  } feature_names[] = {
>

Acked-by: Ivan Hu <ivan.hu@canonical.com>
diff mbox

Patch

diff --git a/src/lib/src/fwts_firmware.c b/src/lib/src/fwts_firmware.c
index 972303a..82849fb 100644
--- a/src/lib/src/fwts_firmware.c
+++ b/src/lib/src/fwts_firmware.c
@@ -26,7 +26,7 @@ 
 static enum firmware_type firmware_type;
 static bool firmware_type_valid;
 
-static struct {
+static const struct {
 	enum firmware_feature feature;
 	const char name[16];
 } feature_names[] = {