| Message ID | 1476824508-4679-5-git-send-email-javier@osg.samsung.com |
|---|---|
| State | Accepted |
| Headers | show |
Hi Javier Martinez Canillas, On Tue, Oct 18, 2016 at 06:01:48PM -0300, Javier Martinez Canillas wrote: > If the driver is built as a module, autoload won't work because the module > alias information is not filled. So user-space can't match the registered > device with the corresponding module. > > Export the module alias information using the MODULE_DEVICE_TABLE() macro. > > Before this patch: > > $ modinfo drivers/i2c/busses/i2c-digicolor.ko | grep alias > $ > > After this patch: > > $ modinfo drivers/i2c/busses/i2c-digicolor.ko | grep alias > alias: of:N*T*Ccnxt,cx92755-i2cC* > alias: of:N*T*Ccnxt,cx92755-i2c > > Signed-off-by: Javier Martinez Canillas <javier@osg.samsung.com> Acked-by: Baruch Siach <baruch@tkos.co.il> Thanks, baruch > drivers/i2c/busses/i2c-digicolor.c | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/drivers/i2c/busses/i2c-digicolor.c b/drivers/i2c/busses/i2c-digicolor.c > index 9604024e0eb0..49f2084f7bb5 100644 > --- a/drivers/i2c/busses/i2c-digicolor.c > +++ b/drivers/i2c/busses/i2c-digicolor.c > @@ -368,6 +368,7 @@ static const struct of_device_id dc_i2c_match[] = { > { .compatible = "cnxt,cx92755-i2c" }, > { }, > }; > +MODULE_DEVICE_TABLE(of, dc_i2c_match); > > static struct platform_driver dc_i2c_driver = { > .probe = dc_i2c_probe,
diff --git a/drivers/i2c/busses/i2c-digicolor.c b/drivers/i2c/busses/i2c-digicolor.c index 9604024e0eb0..49f2084f7bb5 100644 --- a/drivers/i2c/busses/i2c-digicolor.c +++ b/drivers/i2c/busses/i2c-digicolor.c @@ -368,6 +368,7 @@ static const struct of_device_id dc_i2c_match[] = { { .compatible = "cnxt,cx92755-i2c" }, { }, }; +MODULE_DEVICE_TABLE(of, dc_i2c_match); static struct platform_driver dc_i2c_driver = { .probe = dc_i2c_probe,
If the driver is built as a module, autoload won't work because the module alias information is not filled. So user-space can't match the registered device with the corresponding module. Export the module alias information using the MODULE_DEVICE_TABLE() macro. Before this patch: $ modinfo drivers/i2c/busses/i2c-digicolor.ko | grep alias $ After this patch: $ modinfo drivers/i2c/busses/i2c-digicolor.ko | grep alias alias: of:N*T*Ccnxt,cx92755-i2cC* alias: of:N*T*Ccnxt,cx92755-i2c Signed-off-by: Javier Martinez Canillas <javier@osg.samsung.com> --- drivers/i2c/busses/i2c-digicolor.c | 1 + 1 file changed, 1 insertion(+)