diff mbox

linux-user: Fix s390x safe-syscall for z900

Message ID 1476808936-11735-1-git-send-email-rth@twiddle.net
State New
Headers show

Commit Message

Richard Henderson Oct. 18, 2016, 4:42 p.m. UTC
The LT instruction was added in the extended immediate facility
introduced with the z9-109 processor.

Reported-by: Michael Tokarev <mjt@tls.msk.ru>
Fixes: c9bc3437a905b660561a26cd4ecc64579843267b
Signed-off-by: Richard Henderson <rth@twiddle.net>
---
 linux-user/host/s390x/safe-syscall.inc.S | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)

Comments

Thomas Huth Oct. 18, 2016, 4:51 p.m. UTC | #1
On 18.10.2016 18:42, Richard Henderson wrote:
> The LT instruction was added in the extended immediate facility
> introduced with the z9-109 processor.
> 
> Reported-by: Michael Tokarev <mjt@tls.msk.ru>
> Fixes: c9bc3437a905b660561a26cd4ecc64579843267b
> Signed-off-by: Richard Henderson <rth@twiddle.net>
> ---
>  linux-user/host/s390x/safe-syscall.inc.S | 3 ++-
>  1 file changed, 2 insertions(+), 1 deletion(-)
> 
> diff --git a/linux-user/host/s390x/safe-syscall.inc.S b/linux-user/host/s390x/safe-syscall.inc.S
> index f1b446a..61d75dc 100644
> --- a/linux-user/host/s390x/safe-syscall.inc.S
> +++ b/linux-user/host/s390x/safe-syscall.inc.S
> @@ -72,7 +72,8 @@ safe_syscall_base:
>  	 */
>  safe_syscall_start:
>  	/* if signal_pending is non-zero, don't do the call */
> -	lt	%r0,0(%r8)
> +	l	%r0,0(%r8)
> +	ltr	%r0,%r0
>  	jne	2f
>  	svc	0
>  safe_syscall_end:

Reviewed-by: Thomas Huth <thuth@redhat.com>
diff mbox

Patch

diff --git a/linux-user/host/s390x/safe-syscall.inc.S b/linux-user/host/s390x/safe-syscall.inc.S
index f1b446a..61d75dc 100644
--- a/linux-user/host/s390x/safe-syscall.inc.S
+++ b/linux-user/host/s390x/safe-syscall.inc.S
@@ -72,7 +72,8 @@  safe_syscall_base:
 	 */
 safe_syscall_start:
 	/* if signal_pending is non-zero, don't do the call */
-	lt	%r0,0(%r8)
+	l	%r0,0(%r8)
+	ltr	%r0,%r0
 	jne	2f
 	svc	0
 safe_syscall_end: