Patchwork [web] update codingconventions (was: Who owns config.rpath?)

login
register
mail settings
Submitter Ralf Wildenhues
Date Oct. 19, 2010, 6:06 p.m.
Message ID <20101019180633.GA14350@gmx.de>
Download mbox | patch
Permalink /patch/68367/
State New
Headers show

Comments

Ralf Wildenhues - Oct. 19, 2010, 6:06 p.m.
[ moving from gcc@ to -patches ]

Hi Gerald,

* Gerald Pfeifer wrote on Sun, Oct 17, 2010 at 06:44:04PM CEST:
> On Sun, 3 Oct 2010, Ralf Wildenhues wrote:
> > * Dave Korn wrote on Sun, Oct 03, 2010 at 01:42:15PM CEST:
> >>   I can't find any mention of it at the usual place for external sources
> >> (http://gcc.gnu.org/codingconventions.html#upstream), so is our version
> >> forked, or is that just an oversight?
> > It comes originally from gettext, but for all practical matters I think
> > you can consider gnulib to be upstream.
> > 
> > Contents should be kept in sync with relevant parts of libtool.m4 from
> > Libtool though.
> 
> Could I convince you to propose language for addition to
> 
>   http://gcc.gnu.org/codingconventions.html#upstream

OK to commit like this?

Thanks,
Ralf

2010-10-19  Ralf Wildenhues  <Ralf.Wildenhues@gmx.de>

	* codingconventions.html: Add entry for config.rpath.
	Update entries for Libtool files, texinfo.tex, and soft-fp
	to upstream git repositories.
Gerald Pfeifer - Oct. 25, 2010, 1:33 a.m.
On Tue, 19 Oct 2010, Ralf Wildenhues wrote:
> OK to commit like this?

Yes, apart from the first hunk where I prefer the approach below since
it is more generic.

Gerald

Index: codingconventions.html
===================================================================
RCS file: /cvs/gcc/wwwdocs/htdocs/codingconventions.html,v
retrieving revision 1.58
diff -r1.58 codingconventions.html
465c465
< ltcf-gcj.sh: The master copy of these files is the CVS repository of
---
> ltcf-gcj.sh: The master copy of these files is the source repository of
469c469
< Only after the change makes it to the libtool CVS tree should the new
---
> Only after the change makes it to the libtool source tree should the new

Patch

--- codingconventions.html	15 May 2010 23:55:00 -0000	1.58
+++ codingconventions.html	19 Oct 2010 18:02:19 -0000
@@ -462,11 +462,11 @@ 
 
 <li>ltmain.sh, libtool.m4, ltoptions.m4, ltsugar.m4, ltversion.m4,
 lt~obsolete.m4, and formerly also ltconfig, ltcf-c.sh, ltcf-cxx.sh,
-ltcf-gcj.sh: The master copy of these files is the CVS repository of
+ltcf-gcj.sh: The master copy of these files is the git repository of
 <a href="http://www.gnu.org/software/libtool/libtool.html">GNU
 libtool</a>.  Patches should be posted to <a
 href="mailto:libtool-patches@gnu.org">libtool-patches@gnu.org</a>.
-Only after the change makes it to the libtool CVS tree should the new
+Only after the change makes it to the libtool git tree should the new
 files be installed in the GCC source tree.<br />
 ltgcc.m4 is not imported from upstream.<br />
 ltconfig and ltmain.sh are generated files from ltconfig.in and
@@ -490,13 +490,20 @@ 
 symlink-tree and ylwrap:  These are copied from mainline automake, using
 <code>automake --add-missing --copy --force-missing</code>.</li>
 
+<li>Top-level config.rpath:  This comes originally from gettext, but
+gnulib can be considered upstream.  The latest version can be retrieved
+from
+<a href="http://git.savannah.gnu.org/cgit/gnulib.git/plain/build-aux/config.rpath">http://git.savannah.gnu.org/cgit/gnulib.git/plain/build-aux/config.rpath</a>.
+Contents should be kept in sync with relevant parts of libtool.m4 from
+Libtool.</li>
+
 <li>gcc/doc/include/texinfo.tex: This file is copied from texinfo,
 the latest version is at
-<a href="http://cvs.savannah.gnu.org/viewvc/gnulib/gnulib/build-aux/texinfo.tex?revision=HEAD">http://cvs.savannah.gnu.org/viewvc/gnulib/gnulib/build-aux/texinfo.tex?revision=HEAD</a>.</li>
+<a href="http://git.savannah.gnu.org/cgit/gnulib.git/plain/build-aux/texinfo.tex">http://git.savannah.gnu.org/cgit/gnulib.git/plain/build-aux/texinfo.tex</a>.</li>
 
 <li>gcc/config/soft-fp: The master sources (except for
-<code>t-softfp</code>) are in CVS glibc, and changes should go into
-CVS glibc before going into GCC.</li>
+<code>t-softfp</code>) are in git glibc, and changes should go into
+git glibc before going into GCC.</li>
 
 <li>fastjar: The master sources were at <a
 href="http://fastjar.sourceforge.net/">fastjar.sourceforge.net</a>.