Patchwork [net-next] napi: unexport napi_reuse_skb

login
register
mail settings
Submitter stephen hemminger
Date Oct. 19, 2010, 5:12 p.m.
Message ID <20101019101210.1bcff4af@nehalam>
Download mbox | patch
Permalink /patch/68360/
State Accepted
Delegated to: David Miller
Headers show

Comments

stephen hemminger - Oct. 19, 2010, 5:12 p.m.
The function napi_reuse_skb is only used inside core.

Signed-off-by: Stephen Hemminger <shemminger@vyatta.com>

---
 include/linux/netdevice.h |    2 --
 net/core/dev.c            |    3 +--
 2 files changed, 1 insertion(+), 4 deletions(-)

--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
David Miller - Oct. 21, 2010, 11:31 a.m.
From: Stephen Hemminger <shemminger@vyatta.com>
Date: Tue, 19 Oct 2010 10:12:10 -0700

> The function napi_reuse_skb is only used inside core.
> 
> Signed-off-by: Stephen Hemminger <shemminger@vyatta.com>

Applied.
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

Patch

--- a/include/linux/netdevice.h	2010-10-19 09:03:13.211106810 -0700
+++ b/include/linux/netdevice.h	2010-10-19 09:03:24.568216914 -0700
@@ -1745,8 +1745,6 @@  extern gro_result_t	napi_skb_finish(gro_
 extern gro_result_t	napi_gro_receive(struct napi_struct *napi,
 					 struct sk_buff *skb);
 extern void		napi_gro_flush(struct napi_struct *napi);
-extern void		napi_reuse_skb(struct napi_struct *napi,
-				       struct sk_buff *skb);
 extern struct sk_buff *	napi_get_frags(struct napi_struct *napi);
 extern gro_result_t	napi_frags_finish(struct napi_struct *napi,
 					  struct sk_buff *skb,
--- a/net/core/dev.c	2010-10-19 09:03:13.235109156 -0700
+++ b/net/core/dev.c	2010-10-19 09:03:58.839566666 -0700
@@ -3287,14 +3287,13 @@  gro_result_t napi_gro_receive(struct nap
 }
 EXPORT_SYMBOL(napi_gro_receive);
 
-void napi_reuse_skb(struct napi_struct *napi, struct sk_buff *skb)
+static void napi_reuse_skb(struct napi_struct *napi, struct sk_buff *skb)
 {
 	__skb_pull(skb, skb_headlen(skb));
 	skb_reserve(skb, NET_IP_ALIGN - skb_headroom(skb));
 
 	napi->skb = skb;
 }
-EXPORT_SYMBOL(napi_reuse_skb);
 
 struct sk_buff *napi_get_frags(struct napi_struct *napi)
 {