diff mbox

[36/93] 4th: use $(TARGET_MAKE_ENV) when calling $(MAKE)

Message ID 1476720440-22239-37-git-send-email-gustavo.zacarias@free-electrons.com
State Accepted
Headers show

Commit Message

gustavo.zacarias@free-electrons.com Oct. 17, 2016, 4:06 p.m. UTC 
From: Gustavo Zacarias <gustavo.zacarias@free-electrons.com>

Signed-off-by: Gustavo Zacarias <gustavo.zacarias@free-electrons.com>
---
 package/4th/4th.mk | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

Comments

Arnout Vandecappelle Oct. 18, 2016, 7:58 p.m. UTC | #1 
On 17-10-16 18:06, gustavo.zacarias@free-electrons.com wrote:
> From: Gustavo Zacarias <gustavo.zacarias@free-electrons.com>
> 
> Signed-off-by: Gustavo Zacarias <gustavo.zacarias@free-electrons.com>
> ---
>  package/4th/4th.mk | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/package/4th/4th.mk b/package/4th/4th.mk
> index 071c2d4..7828592 100644
> --- a/package/4th/4th.mk
> +++ b/package/4th/4th.mk
> @@ -17,9 +17,9 @@
>  4TH_CFLAGS = $(TARGET_CFLAGS) -DUNIX -fsigned-char
>  
>  ifeq ($(BR2_STATIC_LIBS),y)
> -4TH_MAKE_ENV = STATIC=1
> +4TH_MAKE_ENV = $(TARGET_MAKE_ENV) STATIC=1

 I would have preferred 4TH_MAKE_ENV = $(TARGET_MAKE_ENV) outside the condition
and += inside, but that's just nitpicking.

Reviewed-by: Arnout Vandecappelle (Essensium/Mind) <arnout@mind.be>


 Regards,
 Arnout

>  else
> -4TH_MAKE_ENV = SHARED=1
> +4TH_MAKE_ENV = $(TARGET_MAKE_ENV) SHARED=1
>  4TH_CFLAGS += -fPIC
>  endif
>  
>
diff mbox

Patch

diff --git a/package/4th/4th.mk b/package/4th/4th.mk
index 071c2d4..7828592 100644
--- a/package/4th/4th.mk
+++ b/package/4th/4th.mk
@@ -17,9 +17,9 @@ 
 4TH_CFLAGS = $(TARGET_CFLAGS) -DUNIX -fsigned-char
 
 ifeq ($(BR2_STATIC_LIBS),y)
-4TH_MAKE_ENV = STATIC=1
+4TH_MAKE_ENV = $(TARGET_MAKE_ENV) STATIC=1
 else
-4TH_MAKE_ENV = SHARED=1
+4TH_MAKE_ENV = $(TARGET_MAKE_ENV) SHARED=1
 4TH_CFLAGS += -fPIC
 endif