diff mbox

[U-Boot,v2,2/2] libfdt: fix fdt_stringlist_search()

Message ID 1476703354-16474-3-git-send-email-yamada.masahiro@socionext.com
State Accepted
Delegated to: Tom Rini
Headers show

Commit Message

Masahiro Yamada Oct. 17, 2016, 11:22 a.m. UTC 
If fdt_getprop() fails, negative error code should be returned.

[ DTC commit: daa75e8fa5942caa8e97931aed3a1ee0b7edd74b ]

Signed-off-by: Masahiro Yamada <yamada.masahiro@socionext.com>
Signed-off-by: David Gibson <david@gibson.dropbear.id.au>
---

 lib/libfdt/fdt_ro.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

Comments

Tom Rini Oct. 24, 2016, 3:24 p.m. UTC | #1 
On Mon, Oct 17, 2016 at 08:22:34PM +0900, Masahiro Yamada wrote:

> If fdt_getprop() fails, negative error code should be returned.
> 
> [ DTC commit: daa75e8fa5942caa8e97931aed3a1ee0b7edd74b ]
> 
> Signed-off-by: Masahiro Yamada <yamada.masahiro@socionext.com>
> Signed-off-by: David Gibson <david@gibson.dropbear.id.au>

Applied to u-boot/master, thanks!
diff mbox

Patch

diff --git a/lib/libfdt/fdt_ro.c b/lib/libfdt/fdt_ro.c
index fc08981..1be9538 100644
--- a/lib/libfdt/fdt_ro.c
+++ b/lib/libfdt/fdt_ro.c
@@ -576,7 +576,7 @@  int fdt_stringlist_search(const void *fdt, int nodeoffset, const char *property,
 
 	list = fdt_getprop(fdt, nodeoffset, property, &length);
 	if (!list)
-		return -length;
+		return length;
 
 	len = strlen(string) + 1;
 	end = list + length;