| Message ID | 1476518623-30654-2-git-send-email-thomas.petazzoni@free-electrons.com |
|---|---|
| State | Accepted |
| Headers | show |
Thomas, Joao, All, On 2016-10-15 10:03 +0200, Thomas Petazzoni spake thusly: > From: Joao Pinto <jpinto@synopsys.com> > > This commit adds a new package for the SCP (System Control Processor) > firmware for the ARM reference platforms. There will most likely be > other SCP firmware provided by other vendors, but they might be provided > in a different form, so we for now create a vendor-specific package > named vexpress-firmware. > > Since this firmware is used for booting, we create the package in boot/ > and not in package/. > > The package simply installs a single pre-built binary file into the > images directory. > > Signed-off-by: Joao Pinto <jpinto@synopsys.com> > [Thomas: > - Rename the package from scpfirmware to vexpress-firmware. > - Add a Config.in prompt for the package. > - Remove the prompt-less Config.in options to select the Git repo and > version. Since we only support the Vexpress firmware, there's no need > for configurability here, so we just use the right Git repo/version > in the .mk file. > - Use $(INSTALL) -D to install the firmware file. > - Add license information.] > Signed-off-by: Thomas Petazzoni <thomas.petazzoni@free-electrons.com> No hash file? ;-) Reviewed-by: "Yann E. MORIN" <yann.morin.1998@free.fr> Regards, Yann E. MORIN. > --- > boot/Config.in | 1 + > boot/vexpress-firmware/Config.in | 6 ++++++ > boot/vexpress-firmware/vexpress-firmware.mk | 20 ++++++++++++++++++++ > 3 files changed, 27 insertions(+) > create mode 100644 boot/vexpress-firmware/Config.in > create mode 100644 boot/vexpress-firmware/vexpress-firmware.mk > > diff --git a/boot/Config.in b/boot/Config.in > index 677e5f0..6ffacc6 100644 > --- a/boot/Config.in > +++ b/boot/Config.in > @@ -15,6 +15,7 @@ source "boot/s500-bootloader/Config.in" > source "boot/syslinux/Config.in" > source "boot/ts4800-mbrboot/Config.in" > source "boot/uboot/Config.in" > +source "boot/vexpress-firmware/Config.in" > source "boot/xloader/Config.in" > > endmenu > diff --git a/boot/vexpress-firmware/Config.in b/boot/vexpress-firmware/Config.in > new file mode 100644 > index 0000000..8479df3 > --- /dev/null > +++ b/boot/vexpress-firmware/Config.in > @@ -0,0 +1,6 @@ > +config BR2_TARGET_VEXPRESS_FIRMWARE > + bool "vexpress-firmware" > + depends on BR2_aarch64 > + help > + Versatile Express firmware from ARM, with Linaro mods last > + change. > diff --git a/boot/vexpress-firmware/vexpress-firmware.mk b/boot/vexpress-firmware/vexpress-firmware.mk > new file mode 100644 > index 0000000..693a9cb > --- /dev/null > +++ b/boot/vexpress-firmware/vexpress-firmware.mk > @@ -0,0 +1,20 @@ > +################################################################################ > +# > +# vexpress-firmware > +# > +################################################################################ > + > +VEXPRESS_FIRMWARE_VERSION = 901f81977c3b367a2e0bf3d6444be302822d97a3 > +VEXPRESS_FIRMWARE_SITE = https://git.linaro.org/arm/vexpress-firmware.git > +VEXPRESS_FIRMWARE_SITE_METHOD = git > +# The only available license files are in PDF and RTF formats, and we > +# support only plain text. > +VEXPRESS_FIRMWARE_LICENSE = ARM EULA > + > +VEXPRESS_FIRMWARE_INSTALL_IMAGES = YES > + > +define VEXPRESS_FIRMWARE_INSTALL_IMAGES_CMDS > + $(INSTALL) -D -m 0644 $(@D)/SOFTWARE/bl30.bin $(BINARIES_DIR)/scp-fw.bin > +endef > + > +$(eval $(generic-package)) > -- > 2.7.4 > > _______________________________________________ > buildroot mailing list > buildroot@busybox.net > http://lists.busybox.net/mailman/listinfo/buildroot
Hello, On Sat, 15 Oct 2016 10:03:41 +0200, Thomas Petazzoni wrote: > From: Joao Pinto <jpinto@synopsys.com> > > This commit adds a new package for the SCP (System Control Processor) > firmware for the ARM reference platforms. There will most likely be > other SCP firmware provided by other vendors, but they might be provided > in a different form, so we for now create a vendor-specific package > named vexpress-firmware. > > Since this firmware is used for booting, we create the package in boot/ > and not in package/. > > The package simply installs a single pre-built binary file into the > images directory. > > Signed-off-by: Joao Pinto <jpinto@synopsys.com> > [Thomas: > - Rename the package from scpfirmware to vexpress-firmware. > - Add a Config.in prompt for the package. > - Remove the prompt-less Config.in options to select the Git repo and > version. Since we only support the Vexpress firmware, there's no need > for configurability here, so we just use the right Git repo/version > in the .mk file. > - Use $(INSTALL) -D to install the firmware file. > - Add license information.] > Signed-off-by: Thomas Petazzoni <thomas.petazzoni@free-electrons.com> > --- > boot/Config.in | 1 + > boot/vexpress-firmware/Config.in | 6 ++++++ > boot/vexpress-firmware/vexpress-firmware.mk | 20 ++++++++++++++++++++ > 3 files changed, 27 insertions(+) > create mode 100644 boot/vexpress-firmware/Config.in > create mode 100644 boot/vexpress-firmware/vexpress-firmware.mk Applied to master, after adding a hash file, as suggested by Yann. Thomas
Hello, On Sat, 15 Oct 2016 10:03:41 +0200, Thomas Petazzoni wrote: > +VEXPRESS_FIRMWARE_VERSION = 901f81977c3b367a2e0bf3d6444be302822d97a3 > +VEXPRESS_FIRMWARE_SITE = https://git.linaro.org/arm/vexpress-firmware.git Joao, this is an old version of the firmware. Can you test with a newer version? Indeed, this old version in fact doesn't have any license file in the tree. Newer versions have license.pdf and license.rtf files. Best regards, Thomas
Hi Thomas, On 10/15/2016 12:10 PM, Thomas Petazzoni wrote: > Hello, > > On Sat, 15 Oct 2016 10:03:41 +0200, Thomas Petazzoni wrote: > >> +VEXPRESS_FIRMWARE_VERSION = 901f81977c3b367a2e0bf3d6444be302822d97a3 >> +VEXPRESS_FIRMWARE_SITE = https://git.linaro.org/arm/vexpress-firmware.git > > Joao, this is an old version of the firmware. Can you test with a newer > version? This was the version suggested by Liviu Dudau. @Liviu: Could you please confirm that there is more recent version that we can use? > > Indeed, this old version in fact doesn't have any license file in the > tree. Newer versions have license.pdf and license.rtf files. > > Best regards, > > Thomas > Thanks, Joao
Hi Thomas and Yann, Thanks for the review and extra-effort. Joao On 10/15/2016 11:50 AM, Thomas Petazzoni wrote: > Hello, > > On Sat, 15 Oct 2016 10:03:41 +0200, Thomas Petazzoni wrote: >> From: Joao Pinto <jpinto@synopsys.com> >> >> This commit adds a new package for the SCP (System Control Processor) >> firmware for the ARM reference platforms. There will most likely be >> other SCP firmware provided by other vendors, but they might be provided >> in a different form, so we for now create a vendor-specific package >> named vexpress-firmware. >> >> Since this firmware is used for booting, we create the package in boot/ >> and not in package/. >> >> The package simply installs a single pre-built binary file into the >> images directory. >> >> Signed-off-by: Joao Pinto <jpinto@synopsys.com> >> [Thomas: >> - Rename the package from scpfirmware to vexpress-firmware. >> - Add a Config.in prompt for the package. >> - Remove the prompt-less Config.in options to select the Git repo and >> version. Since we only support the Vexpress firmware, there's no need >> for configurability here, so we just use the right Git repo/version >> in the .mk file. >> - Use $(INSTALL) -D to install the firmware file. >> - Add license information.] >> Signed-off-by: Thomas Petazzoni <thomas.petazzoni@free-electrons.com> >> --- >> boot/Config.in | 1 + >> boot/vexpress-firmware/Config.in | 6 ++++++ >> boot/vexpress-firmware/vexpress-firmware.mk | 20 ++++++++++++++++++++ >> 3 files changed, 27 insertions(+) >> create mode 100644 boot/vexpress-firmware/Config.in >> create mode 100644 boot/vexpress-firmware/vexpress-firmware.mk > > Applied to master, after adding a hash file, as suggested by Yann. > > Thomas >
Hello, On Mon, 17 Oct 2016 13:15:41 +0100, Liviu Dudau wrote: > > This was the version suggested by Liviu Dudau. > > @Liviu: Could you please confirm that there is more recent version that we can use? > > I think at that time that was the latest HEAD version. You can pick any > later versions from Linaro. I suggest (for now) to use 16.08 tag. Could you send a patch doing this? It should also add the license.pdf file in the LICENSE_FILES variable. Thanks a lot! Thomas
diff --git a/boot/Config.in b/boot/Config.in index 677e5f0..6ffacc6 100644 --- a/boot/Config.in +++ b/boot/Config.in @@ -15,6 +15,7 @@ source "boot/s500-bootloader/Config.in" source "boot/syslinux/Config.in" source "boot/ts4800-mbrboot/Config.in" source "boot/uboot/Config.in" +source "boot/vexpress-firmware/Config.in" source "boot/xloader/Config.in" endmenu diff --git a/boot/vexpress-firmware/Config.in b/boot/vexpress-firmware/Config.in new file mode 100644 index 0000000..8479df3 --- /dev/null +++ b/boot/vexpress-firmware/Config.in @@ -0,0 +1,6 @@ +config BR2_TARGET_VEXPRESS_FIRMWARE + bool "vexpress-firmware" + depends on BR2_aarch64 + help + Versatile Express firmware from ARM, with Linaro mods last + change. diff --git a/boot/vexpress-firmware/vexpress-firmware.mk b/boot/vexpress-firmware/vexpress-firmware.mk new file mode 100644 index 0000000..693a9cb --- /dev/null +++ b/boot/vexpress-firmware/vexpress-firmware.mk @@ -0,0 +1,20 @@ +################################################################################ +# +# vexpress-firmware +# +################################################################################ + +VEXPRESS_FIRMWARE_VERSION = 901f81977c3b367a2e0bf3d6444be302822d97a3 +VEXPRESS_FIRMWARE_SITE = https://git.linaro.org/arm/vexpress-firmware.git +VEXPRESS_FIRMWARE_SITE_METHOD = git +# The only available license files are in PDF and RTF formats, and we +# support only plain text. +VEXPRESS_FIRMWARE_LICENSE = ARM EULA + +VEXPRESS_FIRMWARE_INSTALL_IMAGES = YES + +define VEXPRESS_FIRMWARE_INSTALL_IMAGES_CMDS + $(INSTALL) -D -m 0644 $(@D)/SOFTWARE/bl30.bin $(BINARIES_DIR)/scp-fw.bin +endef + +$(eval $(generic-package))