| Message ID | 1476472642-29871-6-git-send-email-jhugo@codeaurora.org |
|---|---|
| State | Accepted |
| Headers | show |
On 2016年10月15日 03:17, Jeffrey Hugo wrote: > If the table does not exist, the error message states the test is being > skipped, however the test is categorized as aborted. The majority of other > tests are categorized as skipped under this scenario. Update the init path > to return a SKIP error to categorize the test result similar to other tests. > > Signed-off-by: Jeffrey Hugo <jhugo@codeaurora.org> > --- > src/acpi/tpm2/tpm2.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/src/acpi/tpm2/tpm2.c b/src/acpi/tpm2/tpm2.c > index f4efd83..7c8c4dd 100644 > --- a/src/acpi/tpm2/tpm2.c > +++ b/src/acpi/tpm2/tpm2.c > @@ -33,7 +33,7 @@ static int tpm2_init(fwts_framework *fw) > } > if (table == NULL) { > fwts_log_error(fw, "ACPI TPM2 table does not exist, skipping test"); > - return FWTS_ERROR; > + return FWTS_SKIP; > } > > return FWTS_OK; > Acked-by: Ivan Hu <ivan.hu@canonical.com>
On 14/10/16 20:17, Jeffrey Hugo wrote: > If the table does not exist, the error message states the test is being > skipped, however the test is categorized as aborted. The majority of other > tests are categorized as skipped under this scenario. Update the init path > to return a SKIP error to categorize the test result similar to other tests. > > Signed-off-by: Jeffrey Hugo <jhugo@codeaurora.org> > --- > src/acpi/tpm2/tpm2.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/src/acpi/tpm2/tpm2.c b/src/acpi/tpm2/tpm2.c > index f4efd83..7c8c4dd 100644 > --- a/src/acpi/tpm2/tpm2.c > +++ b/src/acpi/tpm2/tpm2.c > @@ -33,7 +33,7 @@ static int tpm2_init(fwts_framework *fw) > } > if (table == NULL) { > fwts_log_error(fw, "ACPI TPM2 table does not exist, skipping test"); > - return FWTS_ERROR; > + return FWTS_SKIP; > } > > return FWTS_OK; > Acked-by: Colin Ian King <colin.king@canonical.com>
diff --git a/src/acpi/tpm2/tpm2.c b/src/acpi/tpm2/tpm2.c index f4efd83..7c8c4dd 100644 --- a/src/acpi/tpm2/tpm2.c +++ b/src/acpi/tpm2/tpm2.c @@ -33,7 +33,7 @@ static int tpm2_init(fwts_framework *fw) } if (table == NULL) { fwts_log_error(fw, "ACPI TPM2 table does not exist, skipping test"); - return FWTS_ERROR; + return FWTS_SKIP; } return FWTS_OK;
If the table does not exist, the error message states the test is being skipped, however the test is categorized as aborted. The majority of other tests are categorized as skipped under this scenario. Update the init path to return a SKIP error to categorize the test result similar to other tests. Signed-off-by: Jeffrey Hugo <jhugo@codeaurora.org> --- src/acpi/tpm2/tpm2.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)