| Message ID | 1476467939-17232-1-git-send-email-jhugo@codeaurora.org |
|---|---|
| State | Accepted |
| Headers | show |
On 14/10/16 18:58, Jeffrey Hugo wrote: > The gsiv field never appears in any ACPI spec from v5.0 to v6.1. This > errant field causes issues with the gtdt test checking the common_flags > field as the value pulled from the table will be incorrect and may cause > false failures. > > Signed-off-by: Jeffrey Hugo <jhugo@codeaurora.org> > --- > src/lib/include/fwts_acpi.h | 1 - > 1 file changed, 1 deletion(-) > > diff --git a/src/lib/include/fwts_acpi.h b/src/lib/include/fwts_acpi.h > index 8df4cec..ceb472d 100644 > --- a/src/lib/include/fwts_acpi.h > +++ b/src/lib/include/fwts_acpi.h > @@ -987,7 +987,6 @@ typedef struct { > uint8_t reserved[3]; /* 0 */ > uint64_t cntbase; > uint64_t cntel0base; > - uint32_t gsiv; > uint32_t phys_timer_gsiv; > uint32_t phys_timer_flags; > uint32_t virt_timer_gsiv; > Thanks Jeffrey Acked-by: Colin Ian King <colin.king@canonical.com>
On 2016年10月15日 01:58, Jeffrey Hugo wrote: > The gsiv field never appears in any ACPI spec from v5.0 to v6.1. This > errant field causes issues with the gtdt test checking the common_flags > field as the value pulled from the table will be incorrect and may cause > false failures. > > Signed-off-by: Jeffrey Hugo <jhugo@codeaurora.org> > --- > src/lib/include/fwts_acpi.h | 1 - > 1 file changed, 1 deletion(-) > > diff --git a/src/lib/include/fwts_acpi.h b/src/lib/include/fwts_acpi.h > index 8df4cec..ceb472d 100644 > --- a/src/lib/include/fwts_acpi.h > +++ b/src/lib/include/fwts_acpi.h > @@ -987,7 +987,6 @@ typedef struct { > uint8_t reserved[3]; /* 0 */ > uint64_t cntbase; > uint64_t cntel0base; > - uint32_t gsiv; > uint32_t phys_timer_gsiv; > uint32_t phys_timer_flags; > uint32_t virt_timer_gsiv; > Acked-by: Ivan Hu <ivan.hu@canonical.com>
diff --git a/src/lib/include/fwts_acpi.h b/src/lib/include/fwts_acpi.h index 8df4cec..ceb472d 100644 --- a/src/lib/include/fwts_acpi.h +++ b/src/lib/include/fwts_acpi.h @@ -987,7 +987,6 @@ typedef struct { uint8_t reserved[3]; /* 0 */ uint64_t cntbase; uint64_t cntel0base; - uint32_t gsiv; uint32_t phys_timer_gsiv; uint32_t phys_timer_flags; uint32_t virt_timer_gsiv;
The gsiv field never appears in any ACPI spec from v5.0 to v6.1. This errant field causes issues with the gtdt test checking the common_flags field as the value pulled from the table will be incorrect and may cause false failures. Signed-off-by: Jeffrey Hugo <jhugo@codeaurora.org> --- src/lib/include/fwts_acpi.h | 1 - 1 file changed, 1 deletion(-)